| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
Instead add RETURN_COPY(_VALUE) macros will the expected behavior.
RETURN_ZVAL doesn't make any sense since PHP 7, but has stuck
around, probably because the alternative was to write directly to
the return_value variable.
|
|
|
|
| |
Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.
|
| |
|
| |
|
|
|
|
| |
Except for some bigger ones: reflection, sodium, spl
|
|
|
|
|
|
|
| |
We fix the most often occuring typos according to a recent codespell
report[1] in tests, code comments and documentation.
[1] <https://fossies.org/linux/test/php-src-master-f8f48ce.191129.tar.gz/codespell.html>.
|
|
|
|
|
|
|
| |
Remove most of the `===DONE===` tags and its variations.
Keep `===DONE===` if the test output otherwise becomes empty.
Closes GH-4872.
|
| |
|
|
|
|
| |
Closes GH-4732.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The php_stream_read() and php_stream_write() functions now return
an ssize_t value, with negative results indicating failure. Functions
like fread() and fwrite() will return false in that case.
As a special case, EWOULDBLOCK and EAGAIN on non-blocking streams
should not be regarded as error conditions, and be reported as
successful zero-length reads/writes instead. The handling of EINTR
remains unclear and is internally inconsistent (e.g. some code-paths
will automatically retry on EINTR, while some won't).
I'm landing this now to make sure the stream wrapper ops API changes
make it into 7.4 -- however, if the user-facing changes turn out to
be problematic we have the option of clamping negative returns to
zero in php_stream_read() and php_stream_write() to restore the
old behavior in a relatively non-intrusive manner.
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
Remove HAVE_PQPUTCOPYEND
|
| |
| |
| |
| |
| |
| |
| | |
Symbol is not used anywhere in the code and also Postgresql 7.x is
EOL anyway.
Closes GH-4453
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
add comment about pg_config/pkgconfig
|
| | |
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
Revert "ext/pgsql: Use PKG_CHECK_MODULES to detect the pq library"
|
| |
| |
| |
| | |
This reverts commit 1e265174ed8b361c2d8b9c050f9e3b1f7034acc9.
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
ext/pgsql: Use PKG_CHECK_MODULES to detect the pq library
|
| | |
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
Cheaper checks for exceptions thrown from __toString()
|
| | |
|
|\ \
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
RFC: https://wiki.php.net/rfc/tostring_exceptions
And convert some object to string conversion related recoverable
fatal errors into Error exceptions.
Improve exception safety of internal code performing string
conversions.
|
|\ \
| |/ |
|
| |
| |
| |
| |
| |
| | |
This is our most common intermittent failure. I don't understand
why it happens and can't reproduce it, but defining an explicit
sort order seems worth a shot...
|
| |
| |
| |
| |
| | |
More type checks that are not part of zpp and should generate a
TypeError in PHP 8.
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
Remove example file for pgsql extension
|
| |
| |
| |
| |
| |
| |
| |
| | |
This removes the example script in favour of the manual:
https://www.php.net/manual/en/book.pgsql.php
Patch for integrating these functions as an example has been submitted
also to PHP manual via edit.php.net.
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
[ci skip] Migrate tests READMEs to Markdown
|
| | |
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
Normalize comments in *nix build system m4 files
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Normalization include:
- Use dnl for everything that can be ommitted when configure is built in
favor of the shell comment character # which is visible in the output.
- Line length normalized to 80 columns
- Dots for most of the one line sentences
- Macro definitions include similar pattern header comments now
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
Disable PACKAGE_* preprocessor symbols
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Autoconf defines PACKAGE_* symbols:
- PACKAGE_NAME
- PACKAGE_VERSION
- PACKAGE_TARNAME
- PACKAGE_STRING
- PACKAGE_BUGREPORT
- PACKAGE_URL
and appends them to the generated config.h.in files. With AC_INIT change
via afd52f9d9986d92dd0c63832a07ab1a16bf11d53 where package version, URL,
bug report location and similar meta data are defined, these
preprocessor macros are then non empty strings in the generated
configuration header file. When using phpize, PHP shares the config
files in extensions, warnings of redefined macros appear, such as:
- `warning: 'PACKAGE_NAME' macro redefined`
This patch now disables these non utilized symbols in the generated
config header files.
Better practice would be to include only API specific headers where
needed but this would require even more refactorings. Some extensions
such as pcre, pgsql, and pdo_pgsql solve this issue by undefining some
of these symbols before including the library configuration headers in
the code also. Because these symbols can be defined by any library which
uses Autotools.
Additionally, the unused PACKAGE_* symbols were cleaned for the bundled
libmbfl library and with this patch not needed undef code removed.
|
|\ \
| |/ |
|
| |
| |
| |
| |
| |
| |
| | |
This is unnecessary convoluted... we just want to find the position
of the dot. Using php_strtok_r requires a copy of the string, and the
implementation also relied on the specific semantics of the scratch
space that strtok_r uses.
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
Include libpq-fs.h on Windows, too
|
| |
| |
| |
| | |
That's more future proof than defining hard-coded macros.
|
|\ \
| |/ |
|
| |\ |
|
| | |\ |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Intermediate states are unreliable across versions (I think), make
sure we go through the whole connect procedure.
|
|\ \ \ \
| |/ / / |
|
| |\ \ \
| | |/ / |
|
| | |\ \
| | | |/ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When a connection is closed, we also need to remove the hash entry
from the regular_list, as it now points to freed memory. To do this
store a reverse mapping from the connection to the hash string.
It would be nicer to introduce a wrapping structure for the pgsql
link resource that could store the hash (and notices), but that would
require large changes to the extension, so I'm going for a more
minimal fix here.
|
|\ \ \ \
| |/ / / |
|
| |\ \ \
| | |/ / |
|
| | |\ \
| | | |/ |
|