summaryrefslogtreecommitdiff
path: root/ext/sqlite3
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'PHP-7.0' into PHP-7.1Anatol Belski2016-09-131-0/+37
|\ | | | | | | | | * PHP-7.0: add test for bug #73068
| * Merge branch 'PHP-5.6' into PHP-7.0Anatol Belski2016-09-131-0/+37
| |\ | | | | | | | | | | | | * PHP-5.6: add test for bug #73068
| | * add test for bug #73068Anatol Belski2016-09-131-0/+37
| | |
* | | Update to SQLite 3.14.2Christoph M. Becker2016-09-132-841/+866
| | |
* | | Merge branch 'PHP-7.0' into PHP-7.1Christoph M. Becker2016-09-031-0/+2
|\ \ \ | |/ /
| * | Merge branch 'PHP-5.6' into PHP-7.0Christoph M. Becker2016-09-031-0/+2
| |\ \ | | |/
| | * Make test case more resilientChristoph M. Becker2016-09-031-0/+2
| | | | | | | | | | | | | | | | | | | | | When ran from a root directory the test case failed, because the open_basedir restriction for "../[…]" won't kick in. Therefore we change the current working directory to the test case's directory, as discussed on internals, see <http://news.php.net/php.internals/95585>.
| * | Update to SQLite3 3.13.0Christoph M. Becker2016-07-283-12657/+56019
| | |
* | | Update to SQLite 3.14.1Christoph M. Becker2016-09-022-15/+35
| | |
* | | Update to SQLite 3.14.0Christoph M. Becker2016-08-103-2130/+3306
| | |
* | | Merge branch 'PHP-7.0' into PHP-7.1Christoph M. Becker2016-07-272-15/+9
|\ \ \ | |/ /
| * | Merge branch 'PHP-5.6' into PHP-7.0Christoph M. Becker2016-07-272-15/+9
| |\ \ | | |/ | | | | | | | | | # Resolved conflicts: # ext/sqlite3/sqlite3.c
| | * Implement #72653: SQLite should allow opening with empty filenameChristoph M. Becker2016-07-272-15/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From the [sqlite3_open](https://www.sqlite.org/c3ref/open.html) docs: | If the filename is an empty string, then a private, temporary on-disk | database will be created. This private database will be automatically | deleted as soon as the database connection is closed. We make that facility available to userland. While we're at it, we also do some minor optimizations, remove the unnecessary check for NUL characters in filename, which is already catered to by ZPP(p), and add a missing `return` in case db_obj isn't initialized.
* | | Merge branch 'PHP-7.0' into PHP-7.1Christoph M. Becker2016-07-252-6/+27
|\ \ \ | |/ /
| * | Merge branch 'PHP-5.6' into PHP-7.0Christoph M. Becker2016-07-252-6/+27
| |\ \ | | |/ | | | | | | | | | | | | # Resolved conflicts: # ext/sqlite3/sqlite3.c # ext/sqlite3/tests/bug72668.phpt
| | * Further fixes wrt. bug #72668Christoph M. Becker2016-07-252-3/+50
| | | | | | | | | | | | | | | Not only SQLite3::querySingle(), but also SQLite3::query() and SQLite3Stmt::execute() were affected.
* | | Merge branch 'PHP-7.0' into PHP-7.1Xinchen Hui2016-07-252-1/+27
|\ \ \ | |/ / | | | | | | | | | * PHP-7.0: Fixed bug #72668 (Spurious warning when exception is thrown in user defined function)
| * | Fixed bug #72668 (Spurious warning when exception is thrown in user defined ↵Xinchen Hui2016-07-252-1/+27
| | | | | | | | | | | | function)
* | | Fix SQLite3 header filesChristoph M. Becker2016-07-252-56/+1813
| | | | | | | | | | | | | | | While sqlite3.c had already been updated to 3.13.0, the header files had been forgotten.
* | | Merge branch 'PHP-7.0'Xinchen Hui2016-07-112-1/+24
|\ \ \ | |/ / | | | | | | | | | * PHP-7.0: Fixed bug #72571 (SQLite3::bindValue, SQLite3::bindParam crash)
| * | Fixed bug #72571 (SQLite3::bindValue, SQLite3::bindParam crash)Xinchen Hui2016-07-112-1/+24
| | |
* | | Merge branch 'PHP-7.0'Christoph M. Becker2016-06-272-0/+61
|\ \ \ | |/ /
| * | Merge branch 'PHP-5.6' into PHP-7.0Christoph M. Becker2016-06-272-0/+61
| |\ \ | | |/
| | * Fix #70628: Clearing bindings on an SQLite3 statement doesn't workChristoph M. Becker2016-06-272-0/+61
| | | | | | | | | | | | | | | Obiously, it isn't sufficient to call sqlite3_clear_bindings() alone, but also the bound_params of the php_sqlite3_stmt have to be cleared.
* | | Fixed compilation warningsDmitry Stogov2016-06-221-1/+2
| | |
* | | Fixed the UTF-8 and long path support in the streams on Windows.Anatol Belski2016-06-201-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since long the default PHP charset is UTF-8, however the Windows part is out of step with this important point. The current implementation in PHP doesn't technically permit to handle UTF-8 filepath and several other things. Till now, only the ANSI compatible APIs are being used. Here is more about it https://msdn.microsoft.com/en-us/library/windows/desktop/dd317752%28v=vs.85%29.aspx The patch fixes not only issues with multibyte filenames under incompatible codepages, but indirectly also issues with some other multibyte encodings like BIG5, Shift-JIS, etc. by providing a clean way to access filenames in UTF-8. Below is a small list of issues from the bug tracker, that are getting fixed: https://bugs.php.net/63401 https://bugs.php.net/41199 https://bugs.php.net/50203 https://bugs.php.net/71509 https://bugs.php.net/64699 https://bugs.php.net/64506 https://bugs.php.net/30195 https://bugs.php.net/65358 https://bugs.php.net/61315 https://bugs.php.net/70943 https://bugs.php.net/70903 https://bugs.php.net/63593 https://bugs.php.net/54977 https://bugs.php.net/54028 https://bugs.php.net/43148 https://bugs.php.net/30730 https://bugs.php.net/33350 https://bugs.php.net/35300 https://bugs.php.net/46990 https://bugs.php.net/61309 https://bugs.php.net/69333 https://bugs.php.net/45517 https://bugs.php.net/70551 https://bugs.php.net/50197 https://bugs.php.net/72200 https://bugs.php.net/37672 Yet more related tickets can for sure be found - on bugs.php.net, Stackoverflow and Github. Some of the bugs are pretty recent, some descend to early 2000th, but the user comments in there last even till today. Just for example, bug #30195 was opened in 2004, the latest comment in there was made in 2014. It is certain, that these bugs descend not only to pure PHP use cases, but get also redirected from the popular PHP based projects. Given the modern systems (and those supported by PHP) are always based on NTFS, there is no excuse to keep these issues unresolved. The internalization approach on Windows is in many ways different from UNIX and Linux, while it supports and is based on Unicode. It depends on the current system code page, APIs used and exact kind how the binary was compiled The locale doesn't affect the way Unicode or ANSI API work. PHP in particular is being compiled without _UNICODE defined and this is conditioned by the way we handle strings. Here is more about it https://msdn.microsoft.com/en-us/library/tsbaswba.aspx However, with any system code page ANSI functions automatically convert paths to UTF-16. Paths in some encodings incompatible with the current system code page, won't work correctly with ANSI APIs. PHP till now only uses the ANSI Windows APIs. For example, on a system with the current code page 1252, the paths in cp1252 are supported and transparently converted to UTF-16 by the ANSI functions. Once one wants to handle a filepath encoded with cp932 on that particular system, an ANSI or a POSIX compatible function used in PHP will produce an erroneous result. When trying to convert that cp932 path to UTF-8 and passing to the ANSI functions, an ANSI function would likely interpret the UTF-8 string as some string in the current code page and create a filepath that represents every single byte of the UTF-8 string. These behaviors are not only broken but also disregard the documented INI settings. This patch solves the issies with the multibyte paths on Windows by intelligently enforcing the usage of the Unicode aware APIs. For functions expect Unicode (fe CreateFileW, FindFirstFileW, etc.), arguments will be converted to UTF-16 wide chars. For functions returning Unicode aware data (fe GetCurrentDirectoryW, etc.), resulting wide string is converted back to char's depending on the current PHP charset settings, either to the current ANSI codepage (this is the behavior prior to this patch) or to UTF-8 (the default behavior). In a particular case, users might have to explicitly set internal_encoding or default_charset, if filenames in ANSI codepage are necessary. Current tests show no regressions and witness that this will be an exotic case, the current default UTF-8 encoding is compatible with any supported system. The dependency libraries are long switching to Unicode APIs, so some tests were also added for extensions not directly related to streams. At large, the patch brings over 150 related tests into the core. Those target and was run on various environments with European, Asian, etc. codepages. General PHP frameworks was tested and showed no regressions. The impact on the current C code base is low, the most places affected are the Windows only places in the three files tsrm_win32.c, zend_virtual_cwd.c and plain_wrapper.c. The actual implementation of the most of the wide char supporting functionality is in win32/ioutil.* and win32/codepage.*, several low level functionsare extended in place to avoid reimplementation for now. No performance impact was sighted. As previously mentioned, the ANSI APIs used prior the patch perform Unicode conversions internally. Using the Unicode APIs directly while doing custom conversions just retains the status quo. The ways to optimize it are open (fe. by implementing caching for the strings converted to wide variants). The long path implementation is user transparent. If a path exceeds the length of _MAX_PATH, it'll be automatically prefixed with \\?\. The MAXPATHLEN is set to 2048 bytes. Appreciation to Pierre Joye, Matt Ficken, @algo13 and others for tips, ideas and testing. Thanks.
* | | Implemented FR #72385 (Update SQLite bundle lib(3.13.0))Xinchen Hui2016-06-131-9751/+22342
| | |
* | | Removed "zend_fcall_info.function_table". It was assigned in many places, ↵Dmitry Stogov2016-04-271-2/+0
| | | | | | | | | | | | but is never used.
* | | Merge branch 'PHP-7.0'Anatol Belski2016-04-122-0/+101
|\ \ \ | |/ / | | | | | | | | | * PHP-7.0: Fixed bug #68849 bindValue is not using the right data type
| * | Fixed bug #68849 bindValue is not using the right data typeAnatol Belski2016-04-122-0/+101
| | |
* | | Merge branch 'PHP-7.0'Nikita Popov2016-03-032-2/+2
|\ \ \ | |/ /
| * | Move semicolon into TSRMLS_CACHE_EXTERN/DEFINENikita Popov2016-03-032-2/+2
| | | | | | | | | | | | Also re bug #71575.
* | | Removed zend_fcall_info.symbol_tableDmitry Stogov2016-03-021-2/+0
| | |
* | | Merge branch 'PHP-7.0'Nikita Popov2016-02-131-1/+2
|\ \ \ | |/ /
| * | Merge branch 'PHP-5.6' into PHP-7.0Nikita Popov2016-02-131-1/+2
| |\ \ | | |/ | | | | | | | | | Conflicts: ext/sqlite3/sqlite3.c
| | * Check length of string before comparing to :memory:Nikita Popov2016-02-131-1/+2
| | |
* | | Remove version checksNikita Popov2016-01-301-19/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHP_VERSION_ID PHP_API_VERSION ZEND_MODULE_API_NO PHP_MAJOR_VERSION, PHP_MINOR_VERSION ZEND_ENGINE_2 I've left litespeed alone, as it seems to genuinely maintain support for many PHP versions.
* | | Merge branch 'PHP-7.0'Lior Kaplan2016-01-013-3/+3
|\ \ \ | |/ / | | | | | | | | | | | | | | | * PHP-7.0: Update header to PHP Version 7 Happy new year (Update copyright to 2016) Happy new year (Update copyright to 2016)
| * | Merge branch 'PHP-5.6' into PHP-7.0Lior Kaplan2016-01-013-3/+3
| |\ \ | | |/ | | | | | | | | | * PHP-5.6: Happy new year (Update copyright to 2016)
| | * Happy new year (Update copyright to 2016)Lior Kaplan2016-01-013-3/+3
| | |
* | | Implemented FR #71159 (Upgraed bundled SQLite lib to 3.9.2)Xinchen Hui2015-12-183-6753/+35767
|/ /
* | Fixed Bug #71049 (SQLite3Stmt::execute() releases bound parameter instead ↵Xinchen Hui2015-12-072-2/+22
| | | | | | | | of internal buffer)
* | fix crash in sqlite when executing with bound stream paramAnatol Belski2015-11-052-4/+44
| | | | | | | | rel #70862
* | Fixed Conditional jump or move depends on uninitialised valueXinchen Hui2015-10-141-0/+2
| |
* | Fix a memory leak in sqlite3_do_callback.Adam Harvey2015-09-241-1/+5
| | | | | | | | | | | | | | This was very, very obvious when using a debug build of PHP to build the manual! Fixes bug #70571 (Memory leak in sqlite3_do_callback).
* | Useless ZVAL_UNDEFXinchen Hui2015-09-091-2/+1
| |
* | SQLite3::open/__construct has 2 optional argsRasmus Lerdorf2015-07-071-1/+1
| |
* | Merge branch 'PHP-5.6'Xinchen Hui2015-07-072-2/+38
|\ \ | |/ | | | | | | Conflicts: ext/sqlite3/sqlite3.c
| * Fixed bug #69972 (Use-after-free vulnerability in sqlite3SafetyCheckSickOrOk())Xinchen Hui2015-07-072-2/+38
| |
* | Switch position of ce in exception ce variable namesAaron Piotrowski2015-07-031-8/+8
| |