| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
That appears to have been forgotten for a while.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check open_basedir after the fallback to the system's temporary
directory in tempnam().
In order to preserve the current behavior of upload_tmp_dir
(do not check explicitly specified dir, but check fallback),
new flags are added to check open_basedir for explicit dir
and for fallback.
Closes GH-6526.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the case of a stream with no filters, php_stream_fill_read_buffer
only reads stream->chunk_size into the read buffer. If the stream has
filters attached, it could unnecessarily buffer a large amount of data.
With this change, php_stream_fill_read_buffer only proceeds until either
the requested size or stream->chunk_size is available in the read buffer.
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Closes GH-6444.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reading from a stream may return greater than zero, but nonetheless the
stream's EOF flag may have been set. We have to cater to this
condition by setting the close flag for filters.
We also have to cater to that change in the zlib.inflate filter:
If `inflate()` is called with flush mode `Z_FINISH`, but the output
buffer is not large enough to inflate all available data, it fails with
`Z_BUF_ERROR`. However, `Z_BUF_ERROR` is not fatal; in fact, the zlib
manual states: "If deflate returns with Z_OK or Z_BUF_ERROR, this
function must be called again with Z_FINISH and more output space
(updated avail_out) but no more input data, until it returns with
Z_STREAM_END or an error." Hence, we do so.
Closes GH-6001.
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| | |
* PHP-7.3:
Update UPGRADING
Update NEWS & UPGRADING
Do not decode cookie names anymore
Fix bug #79601 (Wrong ciphertext/tag in AES-CCM encryption for a 12 bytes IV)
|
| |\
| | |
| | |
| | |
| | |
| | |
| | | |
* PHP-7.2:
Update NEWS & UPGRADING
Do not decode cookie names anymore
Fix bug #79601 (Wrong ciphertext/tag in AES-CCM encryption for a 12 bytes IV)
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #76735: Incorrect message in fopen on invalid mode
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We have to log errors in `stream_opener` callbacks to the wrapper's
error log, because otherwise we may pick up an unrelated `errno` or a
most generic message.
Closes GH-6187.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #76943: Inconsistent stream_wrapper_restore() errors
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If restoring of any not registered built-in wrapper is requested, the
function is supposed to fail with a warning, so we have to check this
condition first.
Furthermore, to be able to detect whether a built-in wrapper has been
changed, it is not sufficient to check whether *any* userland wrapper
has been registered, but rather whether the specific wrapper has been
modified.
Closes GH-6183.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #79423: copy command is limited to size of file it can copy
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Passing `NULL` as `lpFileSizeHigh` to `GetFileSize()` gives wrong
results for files larger than 0xFFFFFFFF bytes. We fix this by using
`GetFileSizeEx()`, and let the mapping fail, if the file size is too
large for the architecture.
Closes GH-5319.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Instead of attempting to map large files into memory at once, we map
chunks of at most `PHP_STREAM_MMAP_MAX` bytes, and repeat that until we
hit the point where `php_stream_seek()` fails (see bug 54902), and copy
the rest of the file by reading and writing small chunks.
We also fix the mapping behavior for zero bytes on Windows, which did
not error (as with `mmap()`), but would have mapped the remaining file.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #80067: Omitting the port in bindto setting errors
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A recent commit[1] which fixed a memory leak introduced a regression
regarding the formerly liberal handling of IP addresses to bind to. We
fix this by reverting that commit, and fix the memory leak where it
actually occurs. In other words, this fix is less intrusive than the
former fix.
[1] <http://git.php.net/?p=php-src.git;a=commit;h=0b8c83f5936581942715d14883cdebddc18bad30>
Closes GH-6104.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #80048: Bug #69100 has not been fixed for Windows
|
| | |
| | |
| | |
| | |
| | |
| | | |
We fix the erroneous length calculation on Windows, too.
Closes GH-6067.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Instead of internal __size_t / __off64_t types use ssize_t and off64_t.
This makes it work on musl as well.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Handle bindto error
|
| | |
| | |
| | |
| | | |
Closes GH-5903.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
That has apparently been overlooked.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #79756: finfo_file crash (FILEINFO_MIME)
|
| | |
| | |
| | |
| | |
| | | |
If `ctime` or `asctime` return `NULL`, we must not attempt to copy the
buffer, but rather return `NULL` as well.
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix possibly unsupported timercmp() usage
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The `timercmp()` manpage[1] points out that some systems have a broken
implementation which does not support `>=`. This is definitely the
case for the Windows SDK, which only supports `<` and `>`.
[1] <https://linux.die.net/man/3/timercmp>
|
| | | |
|
| | |
| | |
| | |
| | | |
Seems that has been forgotten.
|
| | |
| | |
| | |
| | |
| | | |
In practise, this likely does not matter, because usually these DLLs
are installed side by side, but still we should check the proper DLL.
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* PHP-7.3:
Fix #78876: Long variables cause OOM and temp files are not cleaned
Fix #78875: Long filenames cause OOM and temp files are not cleaned
Update NEWS for 7.2.31
Update CREDITS for PHP 7.2.30
Update NEWS for PHP 7.2.30
|
| |\ \
| | |/
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* PHP-7.2:
Fix #78876: Long variables cause OOM and temp files are not cleaned
Fix #78875: Long filenames cause OOM and temp files are not cleaned
Update NEWS for 7.2.31
Update CREDITS for PHP 7.2.30
Update NEWS for PHP 7.2.30
|
| | |
| | |
| | |
| | | |
We use the proper type for size calculations, which is `size_t`.
|
| | |
| | |
| | |
| | |
| | |
| | | |
We must not cast `size_t` to `int` (unless the `size_t` value is
guaranteed to be less than or equal to `INT_MAX`). In this case we can
declare `array_len` as `size_t` in the first place.
|
| | |
| | |
| | |
| | | |
Close the stream filter resources when removing them from the stream.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix default sendmail path when not found during build
|