summaryrefslogtreecommitdiff
path: root/win32/ioutil.h
Commit message (Collapse)AuthorAgeFilesLines
* Trim trailing whitespace in source code filesPeter Kokot2018-10-131-3/+3
|
* Merge branch 'PHP-7.1' into PHP-7.2Anatol Belski2018-07-121-1/+1
|\ | | | | | | | | * PHP-7.1: Fix macro
| * Fix macroAnatol Belski2018-07-121-1/+1
| |
| * year++Xinchen Hui2018-01-021-1/+1
| |
* | year++Xinchen Hui2018-01-021-1/+1
| |
* | Merge branch 'PHP-7.1' into PHP-7.2Anatol Belski2017-12-141-1/+1
|\ \ | |/ | | | | | | * PHP-7.1: Fixed bug #75679 Path 260 character problem
| * Fixed bug #75679 Path 260 character problemAnatol Belski2017-12-141-1/+1
| |
* | Merge branch 'PHP-7.1' into PHP-7.2Anatol Belski2017-11-271-6/+6
|\ \ | |/ | | | | | | * PHP-7.1: Fix normalized path length calculation and error handling
| * Fix normalized path length calculation and error handlingAnatol Belski2017-11-271-6/+6
| |
* | Merge branch 'PHP-7.1'Anatol Belski2017-07-141-2/+18
|\ \ | |/ | | | | | | * PHP-7.1: Fixed bug #74923 Crash when crawling through network share
| * Fixed bug #74923 Crash when crawling through network shareAnatol Belski2017-07-141-2/+18
| |
* | comply with POSIX signatureAnatol Belski2017-07-091-1/+1
| |
* | fix warningAnatol Belski2017-07-091-1/+1
| |
* | Merge branch 'PHP-7.1'Anatol Belski2017-05-171-6/+18
|\ \ | |/ | | | | | | * PHP-7.1: improve error handling
| * improve error handlingAnatol Belski2017-05-171-6/+18
| |
* | Merge branch 'PHP-7.1'Anatol Belski2017-05-171-1/+1
|\ \ | |/ | | | | | | * PHP-7.1: fix wrong error check
| * fix wrong error checkAnatol Belski2017-05-171-1/+1
| |
| * Update copyright headers to 2017Sammy Kaye Powers2017-01-041-1/+1
| |
* | missing bits for php_sys_stat_ex so everything is handled with wide charsAnatol Belski2017-04-031-0/+2
| | | | | | | | rename to pathw_len
* | Update copyright headers to 2017Sammy Kaye Powers2017-01-021-1/+1
| |
* | Merge branch 'PHP-7.1'Anatol Belski2016-08-271-23/+42
|\ \ | |/ | | | | | | | | | | | | * PHP-7.1: fix leak add parentheses fix clang compat fix leak
| * fix leakAnatol Belski2016-08-271-23/+42
| |
* | Fixed compiler warning (Sorry Anatol, but this one was killing me)Kalle Sommer Nielsen2016-08-031-1/+1
|/
* set errno in ioutil access routineAnatol Belski2016-07-291-2/+6
|
* move error check to right placeAnatol Belski2016-07-291-4/+5
| | | | this only makes sense when length was passed
* fix and improve the ioutil cwd routine for ntsAnatol Belski2016-07-291-12/+11
| | | | | | - move intermediate var to stack - fix length calculation - improve error code setting
* fix compiler warningAnatol Belski2016-07-241-1/+1
|
* rework long path normalization stufAnatol Belski2016-07-241-1/+11
| | | | | | | Simplify, set error codes, ensure 32-bit is ok as well. The canonicalization part is still an issue on win7 as the API is missing there. However a partial improvement is reached there as well thanks to the slash conversion.
* Fixed bug #72625 realpath() fails on non canonical long pathAnatol Belski2016-07-231-7/+26
|
* Fixed the UTF-8 and long path support in the streams on Windows.Anatol Belski2016-06-201-0/+468
Since long the default PHP charset is UTF-8, however the Windows part is out of step with this important point. The current implementation in PHP doesn't technically permit to handle UTF-8 filepath and several other things. Till now, only the ANSI compatible APIs are being used. Here is more about it https://msdn.microsoft.com/en-us/library/windows/desktop/dd317752%28v=vs.85%29.aspx The patch fixes not only issues with multibyte filenames under incompatible codepages, but indirectly also issues with some other multibyte encodings like BIG5, Shift-JIS, etc. by providing a clean way to access filenames in UTF-8. Below is a small list of issues from the bug tracker, that are getting fixed: https://bugs.php.net/63401 https://bugs.php.net/41199 https://bugs.php.net/50203 https://bugs.php.net/71509 https://bugs.php.net/64699 https://bugs.php.net/64506 https://bugs.php.net/30195 https://bugs.php.net/65358 https://bugs.php.net/61315 https://bugs.php.net/70943 https://bugs.php.net/70903 https://bugs.php.net/63593 https://bugs.php.net/54977 https://bugs.php.net/54028 https://bugs.php.net/43148 https://bugs.php.net/30730 https://bugs.php.net/33350 https://bugs.php.net/35300 https://bugs.php.net/46990 https://bugs.php.net/61309 https://bugs.php.net/69333 https://bugs.php.net/45517 https://bugs.php.net/70551 https://bugs.php.net/50197 https://bugs.php.net/72200 https://bugs.php.net/37672 Yet more related tickets can for sure be found - on bugs.php.net, Stackoverflow and Github. Some of the bugs are pretty recent, some descend to early 2000th, but the user comments in there last even till today. Just for example, bug #30195 was opened in 2004, the latest comment in there was made in 2014. It is certain, that these bugs descend not only to pure PHP use cases, but get also redirected from the popular PHP based projects. Given the modern systems (and those supported by PHP) are always based on NTFS, there is no excuse to keep these issues unresolved. The internalization approach on Windows is in many ways different from UNIX and Linux, while it supports and is based on Unicode. It depends on the current system code page, APIs used and exact kind how the binary was compiled The locale doesn't affect the way Unicode or ANSI API work. PHP in particular is being compiled without _UNICODE defined and this is conditioned by the way we handle strings. Here is more about it https://msdn.microsoft.com/en-us/library/tsbaswba.aspx However, with any system code page ANSI functions automatically convert paths to UTF-16. Paths in some encodings incompatible with the current system code page, won't work correctly with ANSI APIs. PHP till now only uses the ANSI Windows APIs. For example, on a system with the current code page 1252, the paths in cp1252 are supported and transparently converted to UTF-16 by the ANSI functions. Once one wants to handle a filepath encoded with cp932 on that particular system, an ANSI or a POSIX compatible function used in PHP will produce an erroneous result. When trying to convert that cp932 path to UTF-8 and passing to the ANSI functions, an ANSI function would likely interpret the UTF-8 string as some string in the current code page and create a filepath that represents every single byte of the UTF-8 string. These behaviors are not only broken but also disregard the documented INI settings. This patch solves the issies with the multibyte paths on Windows by intelligently enforcing the usage of the Unicode aware APIs. For functions expect Unicode (fe CreateFileW, FindFirstFileW, etc.), arguments will be converted to UTF-16 wide chars. For functions returning Unicode aware data (fe GetCurrentDirectoryW, etc.), resulting wide string is converted back to char's depending on the current PHP charset settings, either to the current ANSI codepage (this is the behavior prior to this patch) or to UTF-8 (the default behavior). In a particular case, users might have to explicitly set internal_encoding or default_charset, if filenames in ANSI codepage are necessary. Current tests show no regressions and witness that this will be an exotic case, the current default UTF-8 encoding is compatible with any supported system. The dependency libraries are long switching to Unicode APIs, so some tests were also added for extensions not directly related to streams. At large, the patch brings over 150 related tests into the core. Those target and was run on various environments with European, Asian, etc. codepages. General PHP frameworks was tested and showed no regressions. The impact on the current C code base is low, the most places affected are the Windows only places in the three files tsrm_win32.c, zend_virtual_cwd.c and plain_wrapper.c. The actual implementation of the most of the wide char supporting functionality is in win32/ioutil.* and win32/codepage.*, several low level functionsare extended in place to avoid reimplementation for now. No performance impact was sighted. As previously mentioned, the ANSI APIs used prior the patch perform Unicode conversions internally. Using the Unicode APIs directly while doing custom conversions just retains the status quo. The ways to optimize it are open (fe. by implementing caching for the strings converted to wide variants). The long path implementation is user transparent. If a path exceeds the length of _MAX_PATH, it'll be automatically prefixed with \\?\. The MAXPATHLEN is set to 2048 bytes. Appreciation to Pierre Joye, Matt Ficken, @algo13 and others for tips, ideas and testing. Thanks.
View Lorry Controller Status