From 269d1601596341f574ff6c875a826ce2b671f1f0 Mon Sep 17 00:00:00 2001
From: Scott <scott@paragonie.com>
Date: Tue, 21 Nov 2017 22:02:07 -0500
Subject: Fix bug #75409

---
 NEWS                  |  2 ++
 ext/standard/random.c | 12 +++---------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/NEWS b/NEWS
index d2b9a05808..fd54b0376c 100644
--- a/NEWS
+++ b/NEWS
@@ -17,6 +17,8 @@ PHP                                                                        NEWS
 - Standard:
   . Fixed bug #75535 (Inappropriately parsing HTTP response leads to PHP
     segment fault). (Nikita)
+  . Fixed bug #75409 (accept EFAULT in addition to ENOSYS as indicator 
+    that getrandom() is missing). (sarciszewski)
 
 - Zip:
   . Fixed bug #75540 (Segfault with libzip 1.3.1). (Remi)
diff --git a/ext/standard/random.c b/ext/standard/random.c
index b52566cef0..a963c8f791 100644
--- a/ext/standard/random.c
+++ b/ext/standard/random.c
@@ -122,16 +122,10 @@ PHPAPI int php_random_bytes(void *bytes, size_t size, zend_bool should_throw)
 			} else if (errno == EINTR || errno == EAGAIN) {
 				/* Try again */
 				continue;
+			} else {
+			    /* If the syscall fails, fall back to reading from /dev/urandom */
+				break;
 			}
-			/*
-				If the syscall fails, we are doomed. The loop that calls
-				php_random_bytes should be terminated by the exception instead
-				of proceeding to demand more entropy.
-			*/
-			if (should_throw) {
-				zend_throw_exception(zend_ce_exception, "Could not gather sufficient random data", errno);
-			}
-			return FAILURE;
 		}
 
 		read_bytes += (size_t) n;
-- 
cgit v1.2.1