From 5f07a895cc340fea081938731f0c9c3b967f062f Mon Sep 17 00:00:00 2001 From: Tyson Andre Date: Wed, 7 Jun 2017 21:32:57 -0700 Subject: Fixes bug #74705 Wrong ReflectionInfo for Collator::getSortKey() https://secure.php.net/manual/en/collator.getsortkey.php --- ext/intl/collator/collator_class.c | 2 +- ext/intl/tests/bug74705.phpt | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 ext/intl/tests/bug74705.phpt diff --git a/ext/intl/collator/collator_class.c b/ext/intl/collator/collator_class.c index 0821cb19d8..26917fd5d7 100644 --- a/ext/intl/collator/collator_class.c +++ b/ext/intl/collator/collator_class.c @@ -119,7 +119,7 @@ zend_function_entry Collator_class_functions[] = { PHP_NAMED_FE( getLocale, ZEND_FN( collator_get_locale ), collator_1_arg ) PHP_NAMED_FE( getErrorCode, ZEND_FN( collator_get_error_code ), collator_0_args ) PHP_NAMED_FE( getErrorMessage, ZEND_FN( collator_get_error_message ), collator_0_args ) - PHP_NAMED_FE( getSortKey, ZEND_FN( collator_get_sort_key ), collator_2_args ) + PHP_NAMED_FE( getSortKey, ZEND_FN( collator_get_sort_key ), collator_1_arg ) PHP_FE_END }; /* }}} */ diff --git a/ext/intl/tests/bug74705.phpt b/ext/intl/tests/bug74705.phpt new file mode 100644 index 0000000000..f26dfe5825 --- /dev/null +++ b/ext/intl/tests/bug74705.phpt @@ -0,0 +1,22 @@ +--TEST-- +Bug #74705 Wrong reflection on Collator::getSortKey +--SKIPIF-- + += 0) die('skip for ICU < 51.2'); ?> +--FILE-- +getNumberOfParameters()); +var_dump($rm->getNumberOfRequiredParameters()); + +$rf = new ReflectionFunction('collator_get_sort_key'); +var_dump($rf->getNumberOfParameters()); +var_dump($rf->getNumberOfRequiredParameters()); +?> +===DONE=== +--EXPECT-- +int(1) +int(1) +int(2) +int(2) +===DONE=== -- cgit v1.2.1