From 5fe6d2134b45818222248b8e20694f407bb52d63 Mon Sep 17 00:00:00 2001 From: Anatol Belski Date: Thu, 12 Apr 2018 18:25:27 +0200 Subject: Fix memory leak --- ext/intl/breakiterator/rulebasedbreakiterator_methods.cpp | 1 + ext/intl/tests/rbbiter___construct_basic.phpt | 11 ++++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ext/intl/breakiterator/rulebasedbreakiterator_methods.cpp b/ext/intl/breakiterator/rulebasedbreakiterator_methods.cpp index 8ab8194b17..fbc3fe6f5c 100644 --- a/ext/intl/breakiterator/rulebasedbreakiterator_methods.cpp +++ b/ext/intl/breakiterator/rulebasedbreakiterator_methods.cpp @@ -79,6 +79,7 @@ static void _php_intlrbbi_constructor_body(INTERNAL_FUNCTION_PARAMETERS) if (U_FAILURE(status)) { intl_error_set(NULL, status, "rbbi_create_instance: unable to " "create instance from compiled rules", 0); + delete rbbi; return; } #else diff --git a/ext/intl/tests/rbbiter___construct_basic.phpt b/ext/intl/tests/rbbiter___construct_basic.phpt index 6fb584fdee..31edcd2c83 100644 --- a/ext/intl/tests/rbbiter___construct_basic.phpt +++ b/ext/intl/tests/rbbiter___construct_basic.phpt @@ -24,8 +24,17 @@ $rules = << ==DONE== --EXPECT-- string(26) "IntlRuleBasedBreakIterator" -==DONE== \ No newline at end of file +int(1) +string(93) "rbbi_create_instance: unable to create instance from compiled rules: U_ILLEGAL_ARGUMENT_ERROR" +==DONE== -- cgit v1.2.1