From 7514b5d91c01eee72837727e853183869a156a7f Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Sun, 7 Jul 2019 11:23:58 +0200 Subject: Mention that zend_parse_parameters should not be tested Also mention that --CREDITS-- section should not be included anymore. We should also change qa.php.net to stop advertising these. [ci skip] --- CONTRIBUTING.md | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f975859032..a084bdea98 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -94,6 +94,14 @@ Submitting test scripts helps us to understand what functionality has changed. It is important for the stability and maintainability of PHP that tests are comprehensive. +Failure conditions of `zend_parse_parameters`, `ZEND_PARSE_PARAMETERS()` and +similar functions should not be tested. These parameter parsing APIs are already +extensively tested, and additional tests only complicate future modifications. + +For newly created tests, a `--CREDITS--` section should no longer be included, +as test authorship is already accurately tracked by Git. If multiple authors +should be credited, the `Co-authored-by` tag in the commit message may be used. + ## Writing documentation There are two ways to contribute to the PHP manual. You can edit the manual and -- cgit v1.2.1