From d30cd7d7e7ddd0d06c18c47f43c7d2ee00de24a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Kocsis?= Date: Tue, 26 May 2020 14:10:57 +0200 Subject: Review the usage of apostrophes in error messages Closes GH-5590 --- ext/ldap/ldap.c | 2 +- ext/ldap/tests/ldap_set_option_error.phpt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'ext/ldap') diff --git a/ext/ldap/ldap.c b/ext/ldap/ldap.c index 7b74fda9b2..a7e6abacfb 100644 --- a/ext/ldap/ldap.c +++ b/ext/ldap/ldap.c @@ -284,7 +284,7 @@ static int _php_ldap_control_from_array(LDAP *ld, LDAPControl** ctrl, zval* arra size_t num_tmpstrings1 = 0, num_tmpstrings2 = 0; if ((val = zend_hash_str_find(Z_ARRVAL_P(array), "oid", sizeof("oid") - 1)) == NULL) { - php_error_docref(NULL, E_WARNING, "Control must have an oid key"); + php_error_docref(NULL, E_WARNING, "Control must have an \"oid\" key"); return -1; } diff --git a/ext/ldap/tests/ldap_set_option_error.phpt b/ext/ldap/tests/ldap_set_option_error.phpt index 079c63577d..5ef4c0b86b 100644 --- a/ext/ldap/tests/ldap_set_option_error.phpt +++ b/ext/ldap/tests/ldap_set_option_error.phpt @@ -33,7 +33,7 @@ var_dump(ldap_set_option($link, 999999, 999999)); --EXPECTF-- bool(false) -Warning: ldap_set_option(): Control must have an oid key in %s on line %d +Warning: ldap_set_option(): Control must have an "oid" key in %s on line %d bool(false) Warning: ldap_set_option(): The array value must contain only arrays, where each array is a control in %s on line %d -- cgit v1.2.1