From f1d7e3ca0b70f910fcecef0278de9c15440ca3c0 Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Mon, 15 Oct 2018 04:31:31 +0200 Subject: Sync leading and final newlines in *.phpt sections This patch adds missing newlines, trims multiple redundant final newlines into a single one, and trims redundant leading newlines in all *.phpt sections. According to POSIX, a line is a sequence of zero or more non-' ' characters plus a terminating '' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2 --- ext/libxml/tests/libxml_set_external_entity_loader_error1.phpt | 1 - ext/libxml/tests/libxml_set_external_entity_loader_variation1.phpt | 1 - ext/libxml/tests/libxml_set_external_entity_loader_variation2.phpt | 1 - 3 files changed, 3 deletions(-) (limited to 'ext/libxml') diff --git a/ext/libxml/tests/libxml_set_external_entity_loader_error1.phpt b/ext/libxml/tests/libxml_set_external_entity_loader_error1.phpt index 7f1adde613..40b31ea85d 100644 --- a/ext/libxml/tests/libxml_set_external_entity_loader_error1.phpt +++ b/ext/libxml/tests/libxml_set_external_entity_loader_error1.phpt @@ -24,7 +24,6 @@ try { } echo "Done.\n"; - --EXPECTF-- Warning: libxml_set_external_entity_loader() expects parameter 1 to be a valid callback, array must have exactly two members in %s on line %d NULL diff --git a/ext/libxml/tests/libxml_set_external_entity_loader_variation1.phpt b/ext/libxml/tests/libxml_set_external_entity_loader_variation1.phpt index 9581927043..d65f77e9f8 100644 --- a/ext/libxml/tests/libxml_set_external_entity_loader_variation1.phpt +++ b/ext/libxml/tests/libxml_set_external_entity_loader_variation1.phpt @@ -43,7 +43,6 @@ $r = $dd->loadXML($xml); var_dump($dd->validate()); echo "Done.\n"; - --EXPECTF-- string(10) "-//FOO/BAR" string(25) "http://example.com/foobar" diff --git a/ext/libxml/tests/libxml_set_external_entity_loader_variation2.phpt b/ext/libxml/tests/libxml_set_external_entity_loader_variation2.phpt index b6251bea6d..e51869cf47 100644 --- a/ext/libxml/tests/libxml_set_external_entity_loader_variation2.phpt +++ b/ext/libxml/tests/libxml_set_external_entity_loader_variation2.phpt @@ -34,7 +34,6 @@ file_put_contents(__DIR__ . "/foobar.dtd", $dtd); var_dump($dd->validate()); echo "Done.\n"; - --EXPECTF-- string(10) "-//FOO/BAR" string(%d) "%sfoobar.dtd" -- cgit v1.2.1