From 87392eff1a3b06cad2449dca8dc90942f3721900 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Sat, 13 Oct 2018 12:15:58 +0200 Subject: =?UTF-8?q?Require=20SQLite=20=E2=89=A5=203.5.0=20for=20ext/sqlite?= =?UTF-8?q?3=20and=20ext/pdo=5Fsqlite?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It is possible to pass flags when opening an SQLite database. For Sqlite < 3.5.0 these are ignored, since `sqlite3_open` doesn't support flags. Neither a warning or notice is raised in this case, nor is this behavior documented in the PHP manual. Instead of fixing it either way, we lift the requirement to SQLite 3.5.0 (released on 2007-09-04) instead of the former SQLite 3.3.9 (released on 2007-01-04). --- ext/pdo_sqlite/sqlite_driver.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'ext/pdo_sqlite/sqlite_driver.c') diff --git a/ext/pdo_sqlite/sqlite_driver.c b/ext/pdo_sqlite/sqlite_driver.c index 2cc7f72475..811f43c268 100644 --- a/ext/pdo_sqlite/sqlite_driver.c +++ b/ext/pdo_sqlite/sqlite_driver.c @@ -809,11 +809,7 @@ static int pdo_sqlite_handle_factory(pdo_dbh_t *dbh, zval *driver_options) /* {{ flags = pdo_attr_lval(driver_options, PDO_SQLITE_ATTR_OPEN_FLAGS, SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE); -#if SQLITE_VERSION_NUMBER >= 3005000 i = sqlite3_open_v2(filename, &H->db, flags, NULL); -#else - i = sqlite3_open(filename, &H->db); -#endif efree(filename); -- cgit v1.2.1