From 37713c80e49b37833dfd48a7f880fa9516ee0dd2 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Tue, 3 Sep 2019 13:11:08 +0200 Subject: Don't explicitly set return value on ZPP failure in ext/xml Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return value is useless, and also slightly confusing. --- ext/xml/xml.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ext/xml/xml.c') diff --git a/ext/xml/xml.c b/ext/xml/xml.c index d6e91b69ce..4da8f54c5c 100644 --- a/ext/xml/xml.c +++ b/ext/xml/xml.c @@ -1065,7 +1065,7 @@ static void php_xml_parser_create_impl(INTERNAL_FUNCTION_PARAMETERS, int ns_supp XML_Char *encoding; if (zend_parse_parameters(ZEND_NUM_ARGS(), (ns_support ? "|ss": "|s"), &encoding_param, &encoding_param_len, &ns_param, &ns_param_len) == FAILURE) { - RETURN_FALSE; + return; } if (encoding_param != NULL) { -- cgit v1.2.1