From 518a160b65fe1c535dc7e78972ba7428c2a4e197 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Tue, 10 Dec 2019 18:43:01 +0100 Subject: Fix #78943: mail() may release string with refcount==1 twice Since we need `headers_lc` as well as `headers_trim` in the following, we do not release the former even if they are the same string, to avoid complicating the release logic even more. A new test case is not necessary, since we already have mail_basic_alt2-win32.phpt and others. --- win32/sendmail.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'win32') diff --git a/win32/sendmail.c b/win32/sendmail.c index ea693ae1f9..273a3737c6 100644 --- a/win32/sendmail.c +++ b/win32/sendmail.c @@ -208,9 +208,6 @@ PHPAPI int TSendMail(char *host, int *error, char **error_message, /* Create a lowercased header for all the searches so we're finally case * insensitive when searching for a pattern. */ headers_lc = zend_string_tolower(headers_trim); - if (headers_lc == headers_trim) { - zend_string_release_ex(headers_lc, 0); - } } /* Fall back to sendmail_from php.ini setting */ -- cgit v1.2.1