summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBelgin Știrbu <belginstirbu@hotmail.com>2022-05-19 23:49:58 -0500
committerBelgin Știrbu <belginstirbu@hotmail.com>2022-05-19 23:49:58 -0500
commit81e38517b30aa413701cc7507f99abe52779eee8 (patch)
tree7aff85350d486c6e1dd06260ec9c3c0ce6ce772a
parent802982fdae3d1316c31b0fe5a903bb6ca334b92f (diff)
downloadpidgin-81e38517b30aa413701cc7507f99abe52779eee8.tar.gz
Fix XMPP not reconnecting after failed connection
After all the SRV hosts have been tried and they all failed, we should signal that a connection failure has occured. Testing Done: Tried connecting to test@example.com. Before the patch, it just tried once then stopped. After the patch, it keeps retrying (with a timeout of a few seconds between). Bugs closed: PIDGIN-17621 Reviewed at https://reviews.imfreedom.org/r/1455/
-rw-r--r--libpurple/protocols/jabber/jabber.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/libpurple/protocols/jabber/jabber.c b/libpurple/protocols/jabber/jabber.c
index 6654297043..8a224fff57 100644
--- a/libpurple/protocols/jabber/jabber.c
+++ b/libpurple/protocols/jabber/jabber.c
@@ -807,6 +807,10 @@ jabber_login_callback(gpointer data, gint source, const gchar *error)
if (js->srv_rec != NULL) {
purple_debug_error("jabber", "Unable to connect to server: %s. Trying next SRV record or connecting directly.\n", error);
try_srv_connect(js);
+ } else {
+ purple_connection_error_reason(js->gc,
+ PURPLE_CONNECTION_ERROR_NETWORK_ERROR,
+ _("Unable to connect"));
}
return;
}