diff options
| author | William Ehlhardt <williamehlhardt@gmail.com> | 2007-08-20 16:22:35 +0000 |
|---|---|---|
| committer | William Ehlhardt <williamehlhardt@gmail.com> | 2007-08-20 16:22:35 +0000 |
| commit | f3fae70c4fa14311728e161f480d097f26c20637 (patch) | |
| tree | fda3c0747f37924ece338093469eeebb206c42c2 | |
| parent | feaa9c58c12e5b22097ec53e2bbe33a0d67a38bc (diff) | |
| download | pidgin-f3fae70c4fa14311728e161f480d097f26c20637.tar.gz | |
- Even more TODO whacking
- Replace a strcmp with a check_subject_name
| -rw-r--r-- | libpurple/certificate.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/libpurple/certificate.c b/libpurple/certificate.c index 35af30f1b0..955bacee22 100644 --- a/libpurple/certificate.c +++ b/libpurple/certificate.c @@ -432,7 +432,6 @@ purple_certificate_pool_store(PurpleCertificatePool *pool, const gchar *id, Purp g_return_val_if_fail(id, FALSE); g_return_val_if_fail(pool->put_cert, FALSE); - /* TODO: Should this just be someone else's problem? */ /* Whether crt->scheme matches find_scheme(pool->scheme_name) is not relevant... I think... */ g_return_val_if_fail( @@ -539,8 +538,7 @@ x509_singleuse_start_verify (PurpleCertificateVerificationRequest *vrq) cn = purple_certificate_get_subject_name(crt); /* Determine whether the name matches */ - /* TODO: Worry about strcmp safety? */ - if (!strcmp(cn, vrq->subject_name)) { + if (purple_certificate_check_subject_name(crt, vrq->subject_name)) { cn_match = _(""); } else { cn_match = _("(DOES NOT MATCH)"); |