| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Add unit tests for xdg-open URI escaping
Approved-by: Eion Robb <eionrobb@gmail.com>
Approved-by: Gary Kramlich <grim@reaperworld.com>
|
| |
| |
| |
| |
| | |
Move the implementation of xdg-open URI escaping to a separate function
called purple_uri_escape_for_open and add a unit test for it.
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Do not rewrite custom buddy icons already in the cache (#17259)
Approved-by: Eion Robb <eionrobb@gmail.com>
Approved-by: Gary Kramlich <grim@reaperworld.com>
|
| |/ |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix Finch search results display (#17238)
Approved-by: Eion Robb <eionrobb@gmail.com>
Approved-by: Gary Kramlich <grim@reaperworld.com>
|
| |/ |
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Because only FsRtpParticipant instances have "cname", libpurple crashed when
PurpleMedia was created with conference_type other than "fsrtpconference"[1].
We still set "cname" for Farstream's internal use if the property is present,
but libpurple now adds its custom GObject data with key "purple-name" to the
participant instance to store and retrieve the participant name in a manner
independent of the type of Farstream conference.
[1] https://developer.pidgin.im/ticket/17246
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Respect the original SIGWINCH's handler SA_SIGINFO field
Approved-by: Gary Kramlich <grim@reaperworld.com>
Approved-by: dx <dx@dxzone.com.ar>
|
| |
| |
| |
| |
| |
| |
| | |
Imported from https://developer.pidgin.im/ticket/16680 , authored by
marcus. When chaining the original SIGWINCH, make sure to optionally
call it with the extra arguments that are available when it was
installed with SA_SIGINFO.
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Don't escape brackets in URIs passed to pidgin_notify_uri
Approved-by: Eion Robb <eionrobb@gmail.com>
Approved-by: Gary Kramlich <grim@reaperworld.com>
|
| | | |
|
| |/
| |
| |
| |
| |
| | |
Imported from https://developer.pidgin.im/ticket/16391 , authored by
cyisfor . Prevents escaping brackets in order for IPv6 links to work
properly.
|
| | |
|
|\ \
| |/
|/|
| |
| |
| |
| |
| |
| | |
Use accessors when accessing ncurses structures
Approved-by: Eion Robb <eionrobb@gmail.com>
Approved-by: Gary Kramlich <grim@reaperworld.com>
Approved-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Approved-by: dx <dx@dxzone.com.ar>
|
|/
|
|
|
| |
Imported from https://developer.pidgin.im/ticket/16764 , authored by
dimstar. Fixes build failures when ncurses defines NCURSES_OPAQUE.
|
| |
|
| |
|
|\
| |
| |
| |
| |
| | |
Fixes for dark color themes
Approved-by: Eion Robb <eionrobb@gmail.com>
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
jabber: Avoid a use-after-free in an error path
Approved-by: Gary Kramlich <grim@reaperworld.com>
Approved-by: Ethan Blanton <elb@kb8ojh.net>
Approved-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If jabber_buddy_find_resource returned NULL, 'resource' was being used
to print an error after it had already been freed. The easiest way to
prevent that is to consolidate all the local resource deallocation and
exit paths in one place.
Fixes #17200
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix configure failures due to bashisms
Approved-by: Eion Robb <eionrobb@gmail.com>
Approved-by: Gary Kramlich <grim@reaperworld.com>
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
Imported from https://developer.pidgin.im/ticket/16836 , authored by
lameventanas . This fixes failures when /bin/sh is not Bash, occuring
due to using the Bash-only == operator to compare strings.
|
|\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Fix mingw32 compilation
Approved-by: Eion Robb <eionrobb@gmail.com>
Approved-by: Gary Kramlich <grim@reaperworld.com>
|
|/ /
| |
| |
| |
| | |
Compilation with mingw32 fails due to the implicit declaration of
purple_strequal. This commit fixes this.
|
| | |
|
|/
|
|
|
| |
A cascade of unused-but-set variables in media.c and a missing
dereference in gg/buddylist.c.
|
|
|
|
| |
about purple
|
|\
| |
| |
| |
| |
| |
| |
| | |
ssl-nss: Use default NSS ciphersuites/TLS versions, fixes TLS 1.3 issues
Approved-by: Eion Robb <eionrobb@gmail.com>
Approved-by: Gary Kramlich <grim@reaperworld.com>
Approved-by: Ethan Blanton <elb@kb8ojh.net>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Recent NSS versions (3.27, 3.29) added TLS 1.3 support without enabling it in
the default configuration. But, for historical reasons, libpurple always
enables the latest TLS version, sets custom ciphersuite lists and disables all
the defaults, including ciphersuites needed for TLS 1.3 to work. This means
that connections to servers that support TLS 1.3 (for example, anything behind
cloudflare) always fail with "SSL Handshake Failed".
The solution is to just not do any of that. NSS has decent defaults, they
regularly update them and their devs will always know better than us.
Fixes #17217
The rest of the commit log is about those historical reasons.
The main user of NSS is firefox, which keeps its own ciphersuite and TLS
version preferences. In the past there were periods of time where firefox was
ahead of the NSS defaults, which caused connection issues or eyebrow-raising
ciphersuite choices. So libpurple tried to copy those prefs. I'm being told
by the NSS devs that nowadays they do a better job at keeping up.
The referenced issues in the deleted code are:
- Trac #1435 (2007), some connection issues due to disabled ciphers.
Probably NSS 3.11 or 3.12. So old it's not relevant, but interesting anyway.
The fix (hg 32a4cf358f9c) was enabling things that look like bad choices
nowadays, but the NSS defaults weren't better. Dark times. It looks like it was
effective to solve connection issues. Newer NSS versions definitely fixed this,
mostly with 3.14 (2012)
- Trac #15909 (2014), TLS 1.1 and 1.2 supported but not enabled.
NSS 3.14 (2012) introduced TLS 1.1; NSS 3.15.1 (2013) introduced TLS 1.2.
It wasn't until NSS 3.18 (2015) that they were enabled by default. The fix was
hg f4e63e354f45. This isn't needed anymore.
- Trac #16262 (2014), "Enabled ciphers in NSS unnecessarily limited"
Someone messed with ciphersuites in ejabberd and broke things. News at 11.
The ticket says "we don't have ciphers that support forward security" ignoring
that the DHE ones have that.
This was NSS 3.17 (2014). The fix (hg f26d96f03176) took the ciphersuite lists
from firefox to enable ECDHE and disable the defaults. ECDHE ciphersuites were
enabled by NSS 3.21 (2015).
- Trac #15862 (2014), "Disable Export ciphers and DES in SSL"
Windows pidgin 2.10.7 (2013) bundled NSS 3.13.6 (2012). Those were disabled by
NSS 3.14 (2012). Pidgin 2.10.8 (2014) updated to NSS 3.15.4 (2014).
---
This means that old NSS versions with bad defaults will use those bad defaults.
The earliest version in current LTS distros is 3.26, while our windows builds
have the oldest version, 3.24. These versions aren't affected by any of the
issues above.
|
|\ \
| |/
|/|
| |
| |
| |
| |
| | |
purple_markup_unescape_entity: Fix handling of hexadecimal html entities
Approved-by: Eion Robb <eionrobb@gmail.com>
Approved-by: Gary Kramlich <grim@reaperworld.com>
Approved-by: Mike Ruprecht <cmaiku@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
Somehow we were under the impression that isxdigit means hexadecimal digit and
the letter 'x' too.
Fixes #17177
|
| | |
|
|/
|
|
| |
user prefs. See ticket #16535. (ok'd by elb, etan, datallah)
|
| |
|
|
|
|
|
|
|
|
|
| |
Trac ticket #17061 says that netbsd added a function called hmac to its libc.
These are private (static) functions so it's safe to rename them. Also renaming
the hash function just in case.
Fixes #17061
|
|\ |
|
| | |
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
String comparison uniformity
Approved-by: Eion Robb <eionrobb@gmail.com>
Approved-by: Gary Kramlich <grim@reaperworld.com>
Approved-by: dx <dx@dxzone.com.ar>
|
| | |
| | |
| | |
| | | |
Already required it in configure.ac
|