summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix the infinite resizing freezeBelgin Știrbu2022-04-152-3/+206
| | | | | | | | | | | | | | | | | | | | | | | | | | This appears related to libpango somehow, as in Debian Bullseye, libpango splits URLs with dashes at the end, but in Debian Bookworm, the URLs are not split with dashes at the end, and the bug does not appear to be triggered in Bookworm. This patch makes the assumption that the gtkimhtml widgets stored in a PidginConversation normally resize in an alternating manner. However, when the bug is triggered, only the "entry" gtkimhtml member of PidginConversation resizes, so we allow "entry" to resize only up to 3 times in a row. Testing Done: Compiled and tested on several desktop environments on a few GNU/Linux distros by pasting the link mentioned here https://issues.imfreedom.org/issue/PIDGIN-17413 moving the cursor at the beginning of the buffer, and holding the spacebar pressed. Bugs closed: PIDGIN-16753, PIDGIN-16999, PIDGIN-17287, PIDGIN-17413, PIDGIN-17430, PIDGIN-17568, PIDGIN-17602 Reviewed at https://reviews.imfreedom.org/r/1342/
* Added transient-buddy back for showing the buddy menu whenBelgin Știrbu2022-04-151-0/+17
| | | | | | | | | | | right-clicking the topic bar. Testing Done: Tested on Debian and Windows. Right-clicking showed the correct context menu. Bugs closed: PIDGIN-17523 Reviewed at https://reviews.imfreedom.org/r/1381/
* Fix IRC file transfers on WindowsBelgin Știrbu2022-04-151-2/+10
| | | | | | | | | | | | This might also fix some other things, like getsockname error #10014 Testing Done: Tested on Windows and Linux. Executed some file transfers over IRC and they worked. Bugs closed: PIDGIN-17175 Reviewed at https://reviews.imfreedom.org/r/1382/
* Patch from dohmniq to properly increment the CSeq numbers in SIMPLE.Gary Kramlich2022-04-072-1/+19
| | | | | | | | | Testing Done: Compiled Bugs closed: PIDGIN-9675 Reviewed at https://reviews.imfreedom.org/r/1379/
* Fix the downloading of dictionaries in the windows installerGary Kramlich2022-03-044-130/+120
| | | | | | | | | Testing Done: * Installed en_US and some other dictionaries with both installers. * Verified they were installed properly * Verified the English dictionary worked. Reviewed at https://reviews.imfreedom.org/r/1303/
* fix typo in German translation (PIDGIN-17575)ivanhoe2022-01-271-1/+1
| | | | | | Bugs closed: PIDGIN-17575 Reviewed at https://reviews.imfreedom.org/r/1242/
* fix memory leak in pidgin_conversations_set_tab_colorsivanhoe2022-01-271-1/+4
| | | | | | | Testing Done: Opened a purple-spasm chat and detected no more leaks in valgrind coming from gdk_color_to_string. Reviewed at https://reviews.imfreedom.org/r/1244/
* Fix gentoo-819774.Gary Kramlich2022-01-242-2/+18
| | | | | | | | | | | I'm not sure if we needed the code that I duplicated but I really don't want to rock the board anymore with this function. This causes all unit tests to pass and everthing seems okay now? Testing Done: Ran the unit tests with TZ values of empty, `Asia/Kathmandu` and `Pacific/Auckland`. Reviewed at https://reviews.imfreedom.org/r/1238/
* Add Mohammed Sadiq to the COPYRIGHT file after review request 1123Gary Kramlich2021-11-051-0/+1
|
* Clear conversation typing source ID in callbackMohammed Sadiq2021-11-051-1/+5
| | | | | | | | | | | | Since the callback is run only once, the source ID should be set to 0 so that the source ID won t be an invalid value. This avoids a GLib critical on removing the invalid Source ID Testing Done: Build and run pidgin and verified that the GLib warning has gone in logs Reviewed at https://reviews.imfreedom.org/r/1123/
* Prepare for the next round of developmentGary Kramlich2021-10-143-2/+9
| | | | | | | Testing Done: Ran `make distcheck` Reviewed at https://reviews.imfreedom.org/r/1048/
* Added tag v2.14.8 for changeset 5076f03ecaaaGary Kramlich2021-10-140-0/+0
|
* Prepare for the 2.14.8 releasev2.14.8Gary Kramlich2021-10-142-4/+13
| | | | | | | Testing Done: Ran `make distcheck` Reviewed at https://reviews.imfreedom.org/r/1043/
* Add some additional tests to purple_str_to_time and address their failures.Gary Kramlich2021-10-062-60/+86
| | | | | | | | | Testing Done: Ran the unit tests with all sorts of values for `TZ` and made sure they passed. Bugs closed: PIDGIN-17552 Reviewed at https://reviews.imfreedom.org/r/931/
* Add a docs plan to convey and remove the old doxygen dockerfileGary Kramlich2021-09-292-47/+29
| | | | | | | Testing Done: Ran the plan locally and verified it was working as expected. Reviewed at https://reviews.imfreedom.org/r/958/
* Fix a double free in jabber/message.c and silence a warningGary Kramlich2021-09-231-5/+6
| | | | | | | | | | | JabberBuddyResource is handled internally, but it's free function, which is static, does in fact free the thread_id as well. Testing Done: Compiled Bugs closed: PIDGIN-17547 Reviewed at https://reviews.imfreedom.org/r/932/
* Fix the link to the support mailing list archiveGary Kramlich2021-09-171-1/+1
| | | | | | | Testing Done: Compiled Reviewed at https://reviews.imfreedom.org/r/929/
* bump the version for the next round of developmentGary Kramlich2021-09-163-3/+10
| | | | | | | Testing Done: Ran `make check` Reviewed at https://reviews.imfreedom.org/r/927/
* Added tag v2.14.7 for changeset f7894672b4e3Gary Kramlich2021-09-160-0/+0
|
* Bump the version and update ChangeLog for the 2.14.7 releasev2.14.7Gary Kramlich2021-09-163-1/+22
| | | | | | | Testing Done: Ran `make distcheck` Reviewed at https://reviews.imfreedom.org/r/925/
* Port purple_str_to_time to regex and add additional testsGary Kramlich2021-09-162-118/+176
| | | | | | | Testing Done: Ran the unit tests with the normal `./autogen.sh` as well as a setup for fuzzing. Reviewed at https://reviews.imfreedom.org/r/923/
* Clean up all of the fuzzers and add a corpus for all of themGary Kramlich2021-09-16185-85/+497
| | | | | | | Testing Done: Ran all of the fuzzers, made sure they were able to add new corpra. Reviewed at https://reviews.imfreedom.org/r/920/
* Fix an assert in purple_markup_html_to_xhtmlElliott Sales de Andrade2021-09-151-3/+6
| | | | | | | | | | | | While `g_string_free` is NULL-safe, the assert for passing it in breaks ossfuzz. This can happen if there is no `src=` in the `img` as expected. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35029 Testing Done: Ran the test case from the bug against `fuzz_html_to_xhtml` Reviewed at https://reviews.imfreedom.org/r/921/
* Fix leak in `purple_markup_find_tag` on errorElliott Sales de Andrade2021-09-151-0/+1
| | | | | | | | | | | The output is set to `NULL`, but the internal data list is not freed if it happened to get something put into it. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35816 Testing Done: Ran `pidgin_utils_fuzzer` on the test case in the bug report. Reviewed at https://reviews.imfreedom.org/r/924/
* Only run tests that require libidn when we have libidn availableGary Kramlich2021-09-141-0/+3
| | | | | | | | | This should eliminate the need for https://gitweb.gentoo.org/repo/gentoo.git/tree/net-im/pidgin/files/pidgin-2.13.0-disable-one-jid-test.patch Testing Done: Compiled with and with out `--disable-idn`, also added a `#warning` during testing to verify if the code was being include properly. Reviewed at https://reviews.imfreedom.org/r/922/
* Correctly free parse tags at end of purple_html_to_xhtml.Elliott Sales de Andrade2021-09-131-5/+5
| | | | | | | | | Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34996 Testing Done: Ran the test case from the bug against `fuzz_html_to_xhtml` Reviewed at https://reviews.imfreedom.org/r/913/
* Fix leak that may occur when xmlnode_from_str failsElliott Sales de Andrade2021-09-131-1/+8
| | | | | | | | | | | | | The failure may occur any time in the middle of parsing, and `xpd->current` may not actually be pointing to the root of the parsed tree. Thus we need to walk back up before freeing the xmlnode. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34988 Testing Done: Ran the reproducer testcase on `fuzz_xml` Reviewed at https://reviews.imfreedom.org/r/911/
* Fixing building on HaikuHaiku Ports Team2021-09-112-0/+12
| | | | | | | | | This patch came from Haiku and was part of their GSoC project for creating a libpurple UI. The original patch can be found at https://github.com/haikuports/haikuports/commit/85fd8fe1ba987c82bc94968a82531c05247b52ad Testing Done: Compile only. Reviewed at https://reviews.imfreedom.org/r/916/
* Added tag v2.14.6 for changeset 7f87a83083b0Gary Kramlich2021-07-080-0/+0
|
* Bump the version for releasev2.14.6Gary Kramlich2021-07-082-2/+4
|
* Fix an out of bounds write in purple_markup_linkify.Gary Kramlich2021-07-081-1/+2
| | | | | | | | | | This was found by Thomas Roth <code@stacksmashing.net>, Dominik Maier <mail@dmnk.co>, and Fabian Freyer <mail@fabianfreyer.de>. Testing Done: Compiled and ran the `purple_markup_linkify_fuzzer` from the google oss-fuzz project to verify the fix. Reviewed at https://reviews.imfreedom.org/r/781/
* Move the fuzzers from libpurples/tests to libpurple/fuzzers and cleanup a ↵Gary Kramlich2021-07-0816-116/+150
| | | | | | | | | bunch of little things Testing Done: Ran the fuzzers locally Reviewed at https://reviews.imfreedom.org/r/782/
* Add fuzzing support for some libpurple featuresJordy Zomer ??2021-06-2411-0/+1038
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Testing Done: Hi! I built and tested all of these fuzzers for libpurple. You can build them by first building pidgin/libpurple with `--enable-fuzzing` then going into `libpurple/tests` and run `make check`. After that you can run these fuzzers. With a dictionary if you want :) for example: ```bash $ ./fuzz_markup_strip_html -dict=dictionaries/html.dict Dictionary: 465 entries INFO: Seed: 2274862685 INFO: Loaded 1 modules (3 inline 8-bit counters): 3 [0x5a4ec0, 0x5a4ec3), INFO: Loaded 1 PC tables (3 PCs): 3 [0x568ee8,0x568f18), INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes INFO: A corpus is not provided, starting from an empty corpus #2 INITED cov: 2 ft: 2 corp: 1/1b exec/s: 0 rss: 30Mb #1048576 pulse cov: 2 ft: 2 corp: 1/1b lim: 4096 exec/s: 524288 rss: 789Mb #2097152 pulse cov: 2 ft: 2 corp: 1/1b lim: 4096 exec/s: 524288 rss: 792Mb ``` Best Regards, Jordy Zomer Reviewed at https://reviews.imfreedom.org/r/760/
* Add support for the no_proxy environment variable.Gary Kramlich2021-06-223-2/+222
| | | | | | | | | | | | This started as a patch on https://issues.imfreedom.org/issue/PIDGIN-17518 but I cleaned it up a bit as well. Testing Done: Followed the unit tests that are documented in the diff. Bugs closed: PIDGIN-17518 Reviewed at https://reviews.imfreedom.org/r/667/
* Update the current status of all developersGary Kramlich2021-06-222-37/+38
| | | | | | | Testing Done: Compiled and verified the developer information window was correct. Reviewed at https://reviews.imfreedom.org/r/773/
* Fix some include guards.Elliott Sales de Andrade2021-06-213-6/+10
| | | | | | | Testing Done: Compile only. Reviewed at https://reviews.imfreedom.org/r/771/
* Replace mentions of Freenode with Libera and move README.hg to HACKING which ↵Gary Kramlich2021-06-218-42/+42
| | | | | | | | | just directed to the website Testing Done: Compiled Reviewed at https://reviews.imfreedom.org/r/768/
* Start filling out the ChangeLog for 2.14.6Gary Kramlich2021-06-211-1/+20
| | | | | | | Testing Done: None, it's a text file. Reviewed at https://reviews.imfreedom.org/r/769/
* Finally update the websites to point to the new urlsGary Kramlich2021-06-211-2/+2
| | | | | | | Testing Done: Compiled but I grepped the code to make sure there aren't any side effects. `PURPLE_WEBSITE` is only used for opening the site or in plugin info and `PURPLE_DEVEL_WEBSITE` is disabled in the about box and spammed to the logs from `core.c` to report errors. Reviewed at https://reviews.imfreedom.org/r/766/
* Initiate XMPP stream management after binding a resourcedefanor2021-06-173-2/+7
| | | | | | Bugs closed: PIDGIN-17520 Reviewed at https://reviews.imfreedom.org/r/759/
* Add a donate link that opens https://imfreedom.org/donate/Gary Kramlich2021-06-141-0/+6
| | | | | | | Testing Done: Ran locally Reviewed at https://reviews.imfreedom.org/r/749/
* Fix a -Wlogical-not-parentheses warning in zephyrGary Kramlich2021-06-071-1/+1
| | | | | | | | | Testing Done: Compiled using clang with `-Wlogical-not-parentheses` and verified the warning was gone. Bugs closed: PIDGIN-17528 Reviewed at https://reviews.imfreedom.org/r/731/
* Replace newlines in topics with spaces.Gary Kramlich2021-06-071-2/+13
| | | | | | | | | Testing Done: Set an xmpp conference topic to "this\r\nis\r\na\r\nstupid\r\ntopic" and verified it didn't expand the infopane. Bugs closed: PIDGIN-16704 Reviewed at https://reviews.imfreedom.org/r/730/
* Check pkg-config for ncurses before manually looking for it.Gary Kramlich2021-06-071-6/+12
| | | | | | | | | | This patch originated from https://bugs.gentoo.org/461482 but is being applied by Gary Kramlich <grim@reaperworld.com> Testing Done: Configured only, worked fine on debian unstable. Reviewed at https://reviews.imfreedom.org/r/729/
* Prepare for the next round of developmentGary Kramlich2021-06-033-2/+8
| | | | | | | Testing Done: Compiled Reviewed at https://reviews.imfreedom.org/r/724/
* Added tag v2.14.5 for changeset d66ac2eb5e70Gary Kramlich2021-06-030-0/+0
|
* Prepare for the 2.14.5 releasev2.14.5Gary Kramlich2021-06-032-3/+18
| | | | | | | Testing Done: Ran make distcheck, about to test on windows Reviewed at https://reviews.imfreedom.org/r/723/
* Zero out some memory that scanbuild thought might be usedGary Kramlich2021-06-032-2/+2
| | | | | | | Testing Done: Verified that scanbuild no longer detected the errors. Reviewed at https://reviews.imfreedom.org/r/716/
* Update our mozilla.pem file and document how to do so.Gary Kramlich2021-06-035-1841/+1238
| | | | | | | | | | | Also update mk-ca-bundle.pl as the version we had was very old. Testing Done: Verified bundles updated and clean works. Bugs closed: PIDGIN-17535 Reviewed at https://reviews.imfreedom.org/r/722/
* Update pidgin-installer.nsi to work with the official nsis releaseGary Kramlich2021-06-031-2/+2
| | | | | | | | | Testing Done: Built the installer with the official nsis release and verified everything works including with mandatory aslr turned on. Bugs closed: PIDGIN-17524 Reviewed at https://reviews.imfreedom.org/r/721/