| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This appears related to libpango somehow, as in Debian
Bullseye, libpango splits URLs with dashes at the end,
but in Debian Bookworm, the URLs are not split with dashes
at the end, and the bug does not appear to be triggered
in Bookworm.
This patch makes the assumption that the gtkimhtml widgets
stored in a PidginConversation normally resize in an
alternating manner. However, when the bug is triggered,
only the "entry" gtkimhtml member of PidginConversation
resizes, so we allow "entry" to resize only up to 3 times
in a row.
Testing Done:
Compiled and tested on several desktop environments on a few
GNU/Linux distros by pasting the link mentioned
here https://issues.imfreedom.org/issue/PIDGIN-17413 moving
the cursor at the beginning of the buffer, and holding
the spacebar pressed.
Bugs closed: PIDGIN-16753, PIDGIN-16999, PIDGIN-17287, PIDGIN-17413, PIDGIN-17430, PIDGIN-17568, PIDGIN-17602
Reviewed at https://reviews.imfreedom.org/r/1342/
|
|
|
|
|
|
|
|
|
|
|
| |
right-clicking the topic bar.
Testing Done:
Tested on Debian and Windows. Right-clicking showed the correct context menu.
Bugs closed: PIDGIN-17523
Reviewed at https://reviews.imfreedom.org/r/1381/
|
|
|
|
|
|
|
|
|
|
|
|
| |
This might also fix some other things, like getsockname
error #10014
Testing Done:
Tested on Windows and Linux. Executed some file transfers over IRC and they worked.
Bugs closed: PIDGIN-17175
Reviewed at https://reviews.imfreedom.org/r/1382/
|
|
|
|
|
|
|
|
|
| |
Testing Done:
Compiled
Bugs closed: PIDGIN-9675
Reviewed at https://reviews.imfreedom.org/r/1379/
|
|
|
|
|
|
|
|
|
| |
Testing Done:
* Installed en_US and some other dictionaries with both installers.
* Verified they were installed properly
* Verified the English dictionary worked.
Reviewed at https://reviews.imfreedom.org/r/1303/
|
|
|
|
|
|
| |
Bugs closed: PIDGIN-17575
Reviewed at https://reviews.imfreedom.org/r/1242/
|
|
|
|
|
|
|
| |
Testing Done:
Opened a purple-spasm chat and detected no more leaks in valgrind coming from gdk_color_to_string.
Reviewed at https://reviews.imfreedom.org/r/1244/
|
|
|
|
|
|
|
|
|
|
|
| |
I'm not sure if we needed the code that I duplicated but I really don't want to
rock the board anymore with this function. This causes all unit tests to pass
and everthing seems okay now?
Testing Done:
Ran the unit tests with TZ values of empty, `Asia/Kathmandu` and `Pacific/Auckland`.
Reviewed at https://reviews.imfreedom.org/r/1238/
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the callback is run only once, the source ID should be
set to 0 so that the source ID won t be an invalid value.
This avoids a GLib critical on removing the invalid Source ID
Testing Done:
Build and run pidgin and verified that the GLib warning has gone in logs
Reviewed at https://reviews.imfreedom.org/r/1123/
|
|
|
|
|
|
|
| |
Testing Done:
Ran `make distcheck`
Reviewed at https://reviews.imfreedom.org/r/1048/
|
| |
|
|
|
|
|
|
|
| |
Testing Done:
Ran `make distcheck`
Reviewed at https://reviews.imfreedom.org/r/1043/
|
|
|
|
|
|
|
|
|
| |
Testing Done:
Ran the unit tests with all sorts of values for `TZ` and made sure they passed.
Bugs closed: PIDGIN-17552
Reviewed at https://reviews.imfreedom.org/r/931/
|
|
|
|
|
|
|
| |
Testing Done:
Ran the plan locally and verified it was working as expected.
Reviewed at https://reviews.imfreedom.org/r/958/
|
|
|
|
|
|
|
|
|
|
|
| |
JabberBuddyResource is handled internally, but it's free function, which is static, does in fact free the thread_id as well.
Testing Done:
Compiled
Bugs closed: PIDGIN-17547
Reviewed at https://reviews.imfreedom.org/r/932/
|
|
|
|
|
|
|
| |
Testing Done:
Compiled
Reviewed at https://reviews.imfreedom.org/r/929/
|
|
|
|
|
|
|
| |
Testing Done:
Ran `make check`
Reviewed at https://reviews.imfreedom.org/r/927/
|
| |
|
|
|
|
|
|
|
| |
Testing Done:
Ran `make distcheck`
Reviewed at https://reviews.imfreedom.org/r/925/
|
|
|
|
|
|
|
| |
Testing Done:
Ran the unit tests with the normal `./autogen.sh` as well as a setup for fuzzing.
Reviewed at https://reviews.imfreedom.org/r/923/
|
|
|
|
|
|
|
| |
Testing Done:
Ran all of the fuzzers, made sure they were able to add new corpra.
Reviewed at https://reviews.imfreedom.org/r/920/
|
|
|
|
|
|
|
|
|
|
|
|
| |
While `g_string_free` is NULL-safe, the assert for passing it in breaks
ossfuzz. This can happen if there is no `src=` in the `img` as expected.
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35029
Testing Done:
Ran the test case from the bug against `fuzz_html_to_xhtml`
Reviewed at https://reviews.imfreedom.org/r/921/
|
|
|
|
|
|
|
|
|
|
|
| |
The output is set to `NULL`, but the internal data list is not freed if it happened to get something put into it.
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35816
Testing Done:
Ran `pidgin_utils_fuzzer` on the test case in the bug report.
Reviewed at https://reviews.imfreedom.org/r/924/
|
|
|
|
|
|
|
|
|
| |
This should eliminate the need for https://gitweb.gentoo.org/repo/gentoo.git/tree/net-im/pidgin/files/pidgin-2.13.0-disable-one-jid-test.patch
Testing Done:
Compiled with and with out `--disable-idn`, also added a `#warning` during testing to verify if the code was being include properly.
Reviewed at https://reviews.imfreedom.org/r/922/
|
|
|
|
|
|
|
|
|
| |
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34996
Testing Done:
Ran the test case from the bug against `fuzz_html_to_xhtml`
Reviewed at https://reviews.imfreedom.org/r/913/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The failure may occur any time in the middle of parsing, and `xpd->current` may
not actually be pointing to the root of the parsed tree. Thus we need to walk
back up before freeing the xmlnode.
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34988
Testing Done:
Ran the reproducer testcase on `fuzz_xml`
Reviewed at https://reviews.imfreedom.org/r/911/
|
|
|
|
|
|
|
|
|
| |
This patch came from Haiku and was part of their GSoC project for creating a libpurple UI. The original patch can be found at https://github.com/haikuports/haikuports/commit/85fd8fe1ba987c82bc94968a82531c05247b52ad
Testing Done:
Compile only.
Reviewed at https://reviews.imfreedom.org/r/916/
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This was found by Thomas Roth <code@stacksmashing.net>, Dominik Maier
<mail@dmnk.co>, and Fabian Freyer <mail@fabianfreyer.de>.
Testing Done:
Compiled and ran the `purple_markup_linkify_fuzzer` from the google oss-fuzz project to verify the fix.
Reviewed at https://reviews.imfreedom.org/r/781/
|
|
|
|
|
|
|
|
|
| |
bunch of little things
Testing Done:
Ran the fuzzers locally
Reviewed at https://reviews.imfreedom.org/r/782/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Testing Done:
Hi!
I built and tested all of these fuzzers for libpurple.
You can build them by first building pidgin/libpurple with `--enable-fuzzing` then going into `libpurple/tests` and run `make check`. After that you can run these fuzzers. With a dictionary if you want :)
for example:
```bash
$ ./fuzz_markup_strip_html -dict=dictionaries/html.dict
Dictionary: 465 entries
INFO: Seed: 2274862685
INFO: Loaded 1 modules (3 inline 8-bit counters): 3 [0x5a4ec0, 0x5a4ec3),
INFO: Loaded 1 PC tables (3 PCs): 3 [0x568ee8,0x568f18),
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes
INFO: A corpus is not provided, starting from an empty corpus
#2 INITED cov: 2 ft: 2 corp: 1/1b exec/s: 0 rss: 30Mb
#1048576 pulse cov: 2 ft: 2 corp: 1/1b lim: 4096 exec/s: 524288 rss: 789Mb
#2097152 pulse cov: 2 ft: 2 corp: 1/1b lim: 4096 exec/s: 524288 rss: 792Mb
```
Best Regards,
Jordy Zomer
Reviewed at https://reviews.imfreedom.org/r/760/
|
|
|
|
|
|
|
|
|
|
|
|
| |
This started as a patch on https://issues.imfreedom.org/issue/PIDGIN-17518
but I cleaned it up a bit as well.
Testing Done:
Followed the unit tests that are documented in the diff.
Bugs closed: PIDGIN-17518
Reviewed at https://reviews.imfreedom.org/r/667/
|
|
|
|
|
|
|
| |
Testing Done:
Compiled and verified the developer information window was correct.
Reviewed at https://reviews.imfreedom.org/r/773/
|
|
|
|
|
|
|
| |
Testing Done:
Compile only.
Reviewed at https://reviews.imfreedom.org/r/771/
|
|
|
|
|
|
|
|
|
| |
just directed to the website
Testing Done:
Compiled
Reviewed at https://reviews.imfreedom.org/r/768/
|
|
|
|
|
|
|
| |
Testing Done:
None, it's a text file.
Reviewed at https://reviews.imfreedom.org/r/769/
|
|
|
|
|
|
|
| |
Testing Done:
Compiled but I grepped the code to make sure there aren't any side effects. `PURPLE_WEBSITE` is only used for opening the site or in plugin info and `PURPLE_DEVEL_WEBSITE` is disabled in the about box and spammed to the logs from `core.c` to report errors.
Reviewed at https://reviews.imfreedom.org/r/766/
|
|
|
|
|
|
| |
Bugs closed: PIDGIN-17520
Reviewed at https://reviews.imfreedom.org/r/759/
|
|
|
|
|
|
|
| |
Testing Done:
Ran locally
Reviewed at https://reviews.imfreedom.org/r/749/
|
|
|
|
|
|
|
|
|
| |
Testing Done:
Compiled using clang with `-Wlogical-not-parentheses` and verified the warning was gone.
Bugs closed: PIDGIN-17528
Reviewed at https://reviews.imfreedom.org/r/731/
|
|
|
|
|
|
|
|
|
| |
Testing Done:
Set an xmpp conference topic to "this\r\nis\r\na\r\nstupid\r\ntopic" and verified it didn't expand the infopane.
Bugs closed: PIDGIN-16704
Reviewed at https://reviews.imfreedom.org/r/730/
|
|
|
|
|
|
|
|
|
|
| |
This patch originated from https://bugs.gentoo.org/461482 but is being applied
by Gary Kramlich <grim@reaperworld.com>
Testing Done:
Configured only, worked fine on debian unstable.
Reviewed at https://reviews.imfreedom.org/r/729/
|
|
|
|
|
|
|
| |
Testing Done:
Compiled
Reviewed at https://reviews.imfreedom.org/r/724/
|
| |
|
|
|
|
|
|
|
| |
Testing Done:
Ran make distcheck, about to test on windows
Reviewed at https://reviews.imfreedom.org/r/723/
|
|
|
|
|
|
|
| |
Testing Done:
Verified that scanbuild no longer detected the errors.
Reviewed at https://reviews.imfreedom.org/r/716/
|
|
|
|
|
|
|
|
|
|
|
| |
Also update mk-ca-bundle.pl as the version we had was very old.
Testing Done:
Verified bundles updated and clean works.
Bugs closed: PIDGIN-17535
Reviewed at https://reviews.imfreedom.org/r/722/
|
|
|
|
|
|
|
|
|
| |
Testing Done:
Built the installer with the official nsis release and verified everything works including with mandatory aslr turned on.
Bugs closed: PIDGIN-17524
Reviewed at https://reviews.imfreedom.org/r/721/
|