summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Hunt <chrahunt@gmail.com>2020-08-05 19:58:22 -0400
committerPradyun Gedam <pradyunsg@users.noreply.github.com>2020-08-11 16:55:07 +0530
commitb9e403b1730e8555018794f758e7a9fc871e3833 (patch)
treea88cb41ac69ea8d709ed8712eebf1c9abe99b4db
parent0ebe453140ccf2a8c3c537b4800fd2d7b97715e5 (diff)
downloadpip-b9e403b1730e8555018794f758e7a9fc871e3833.tar.gz
Merge pull request #8716 from McSinyx/fix-range-request-cache
Disable caching for range requests
-rw-r--r--news/50cf024d-0a74-44c8-b3e9-483dd826fff2.trivial0
-rw-r--r--src/pip/_internal/network/lazy_wheel.py6
2 files changed, 4 insertions, 2 deletions
diff --git a/news/50cf024d-0a74-44c8-b3e9-483dd826fff2.trivial b/news/50cf024d-0a74-44c8-b3e9-483dd826fff2.trivial
new file mode 100644
index 000000000..e69de29bb
--- /dev/null
+++ b/news/50cf024d-0a74-44c8-b3e9-483dd826fff2.trivial
diff --git a/src/pip/_internal/network/lazy_wheel.py b/src/pip/_internal/network/lazy_wheel.py
index 16be0d297..a0f9e151d 100644
--- a/src/pip/_internal/network/lazy_wheel.py
+++ b/src/pip/_internal/network/lazy_wheel.py
@@ -194,8 +194,10 @@ class LazyZipOverHTTP(object):
def _stream_response(self, start, end, base_headers=HEADERS):
# type: (int, int, Dict[str, str]) -> Response
"""Return HTTP response to a range request from start to end."""
- headers = {'Range': 'bytes={}-{}'.format(start, end)}
- headers.update(base_headers)
+ headers = base_headers.copy()
+ headers['Range'] = 'bytes={}-{}'.format(start, end)
+ # TODO: Get range requests to be correctly cached
+ headers['Cache-Control'] = 'no-cache'
return self._session.get(self._url, headers=headers, stream=True)
def _merge(self, start, end, left, right):