From 5ae08663dbc88d5372880c1c04b7cc7d196adfa6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Bidoul?= Date: Sun, 2 Apr 2023 18:39:45 +0200 Subject: Update comment --- src/pip/_internal/pyproject.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pip/_internal/pyproject.py b/src/pip/_internal/pyproject.py index 57fef5707..eb8e12b2d 100644 --- a/src/pip/_internal/pyproject.py +++ b/src/pip/_internal/pyproject.py @@ -91,7 +91,7 @@ def load_pyproject_toml( # If we haven't worked out whether to use PEP 517 yet, # and the user hasn't explicitly stated a preference, # we do so if the project has a pyproject.toml file - # or if we cannot import setuptools. + # or if we cannot import setuptools or wheels. # We fallback to PEP 517 when without setuptools or without the wheel package, # so setuptools can be installed as a default build backend. -- cgit v1.2.1 From 2ff2d0e375e163792e5dec8ef48481074c86e90a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Bidoul?= Date: Sun, 2 Apr 2023 18:49:34 +0200 Subject: Deprecate legacy projects ignoring config settings In the future the presence of config settings will auto enable pep517. --- news/11915.removal.rst | 3 +++ src/pip/_internal/req/req_install.py | 9 +++++++++ 2 files changed, 12 insertions(+) create mode 100644 news/11915.removal.rst diff --git a/news/11915.removal.rst b/news/11915.removal.rst new file mode 100644 index 000000000..e54b5d574 --- /dev/null +++ b/news/11915.removal.rst @@ -0,0 +1,3 @@ +Using ``--config-settings`` with projects that don't have a ``pyproject.toml`` now print +a deprecation warning. In the future the presence of config settings will automatically +enable the default build backend for legacy projects and pass the setttings to it. diff --git a/src/pip/_internal/req/req_install.py b/src/pip/_internal/req/req_install.py index f0b7c5bcb..2c628d36e 100644 --- a/src/pip/_internal/req/req_install.py +++ b/src/pip/_internal/req/req_install.py @@ -477,6 +477,15 @@ class InstallRequirement: ) if pyproject_toml_data is None: + if self.config_settings: + deprecated( + reason=f"Config settings are ignored for project {self}.", + replacement=( + "to use --use-pep517 or add a " + "pyproject.toml file to the project" + ), + gone_in="23.3", + ) self.use_pep517 = False return -- cgit v1.2.1