delta/postgresql.git, branch REL8_4_21

Stamp 8.4.21.

2014-03-17T19:39:12+00:00

Release notes for 9.3.4, 9.2.8, 9.1.13, 9.0.17, 8.4.21.

2014-03-17T19:28:38+00:00

Translation updates

2014-03-17T01:57:28+00:00

Fix advertised dispsize for libpq's sslmode connection parameter.

2014-03-17T01:43:57+00:00

"8" was correct back when "disable" was the longest allowed value, but
since "verify-full" was added, it should be "12".  Given the lack of
complaints, I wouldn't be surprised if nobody is actually using these
values ... but still, if they're in the API, they should be right.

Noticed while pursuing a different problem.  It's been wrong for quite
a long time, so back-patch to all supported branches.

Update time zone data files to tzdata release 2014a.

2014-03-15T17:36:57+00:00

DST law changes in Fiji, Turkey; historical changes in Israel, Ukraine.

Add missing #include.

2014-03-14T15:47:03+00:00

Commit 31400a673 and siblings added a check_stack_depth() call in
contrib/intarray/_int_bool.c, but neglected to note that in our oldest
branches that file didn't have the #include that defines that function.
This results in a fortunately-harmless compiler warning.  Per buildfarm.

Prevent interrupts while reporting non-ERROR elog messages.

2014-03-14T00:59:57+00:00

This should eliminate the risk of recursive entry to syslog(3), which
appears to be the cause of the hang reported in bug #9551 from James
Morton.

Arguably, the real problem here is auth.c's willingness to turn on
ImmediateInterruptOK while executing fairly wide swaths of backend code.
We may well need to work at narrowing the code ranges in which the
authentication_timeout interrupt is enabled.  For the moment, though,
this is a cheap and reasonably noninvasive fix for a field-reported
failure; the other approach would be complex and not necessarily
bug-free itself.

Back-patch to all supported branches.

In WAL replay, restore GIN metapage unconditionally to avoid torn page.

2014-03-12T08:10:04+00:00

We don't take a full-page image of the GIN metapage; instead, the WAL record
contains all the information required to reconstruct it from scratch. But
to avoid torn page hazards, we must re-initialize it from the WAL record
every time, even if it already has a greater LSN, similar to how normal full
page images are restored.

This was highly unlikely to cause any problems in practice, because the GIN
metapage is small. We rely on an update smaller than a 512 byte disk sector
to be atomic elsewhere, at least in pg_control. But better safe than sorry,
and this would be easy to overlook if more fields are added to the metapage
so that it's no longer small.

Reported by Noah Misch. Backpatch to all supported versions.

Fix dangling smgr_owner pointer when a fake relcache entry is freed.

2014-03-07T11:43:28+00:00

A fake relcache entry can "own" a SmgrRelation object, like a regular
relcache entry. But when it was free'd, the owner field in SmgrRelation
was not cleared, so it was left pointing to free'd memory.

Amazingly this apparently hasn't caused crashes in practice, or we would've
heard about it earlier. Andres found this with Valgrind.

Report and fix by Andres Freund, with minor modifications by me. Backpatch
to all supported versions.

Avoid memcpy() with same source and destination address.

2014-03-07T11:43:28+00:00

The behavior of that is undefined, although unlikely to lead to problems in
practice.

Found by running regression tests with Valgrind.