delta/postgresql.git/src/bin, branch master

ICU: check for U_STRING_NOT_TERMINATED_WARNING.

2023-05-17T21:18:45+00:00

Fixes memory error in cases where the length of the language name
returned by uloc_getLanguage() is exactly ULOC_LANG_CAPACITY, in which
case the status is set to U_STRING_NOT_TERMINATED_WARNING.

Also check in call sites for other ICU functions that are expected to
return a C string to be safe (no bug is known at these other call
sites).

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/2098874d-c111-41e4-9063-30bcf135226b@gmail.com

Revert "Add USER SET parameter values for pg_db_role_setting"

2023-05-17T17:28:57+00:00

This reverts commit 096dd80f3ccc and its fixups beecbe8e5001, afdd9f7f0e00,
529da086ba, db93e739ac61.

Catversion is bumped.

Discussion: https://postgr.es/m/d46f9265-ff3c-6743-2278-6772598233c2%40pgmasters.net

pg_dump: Error message improvements

2023-05-17T17:13:08+00:00

Remove spurious semicolon from one error message, and print the
offending value of a parameter reported as invalid in another.

pg_dump: Have _EndLO report errno after CFH->write_func() failure

2023-05-17T16:55:51+00:00

Other callers of that function do things this way, but this one didn't
get the memo.

Advance input pointer when LZ4 compressing data

2023-05-17T14:49:34+00:00

LZ4File_write() did not advance the input pointer on subsequent invocations of
LZ4F_compressUpdate(). As a result the generated compressed output would be a
compressed version of the same input chunk.

Tests failed to catch this error because the data would comfortably fit
within the default buffer size, as a single chunk. Tests have been added
to provide adequate coverage of multi-chunk compression.

WriteDataToArchiveLZ4() which is also using LZ4F_compressUpdate() did
not suffer from this omission.

Author: Georgios Kokolatos 
Reported-by: Michael Paquier 
Discussion: https://postgr.es/m/ZFhCyn4Gm2eu60rB%40paquier.xyz

Null-terminate the output buffer of LZ4Stream_gets

2023-05-17T14:35:30+00:00

LZ4Stream_gets did not null-terminate its output buffer. The callers expected
the buffer to be null-terminated and passed it around to functions such as
sscanf with unintended consequences.

Author: Georgios Kokolatos 
Reported-by: Alexander Lakhin 
Discussion: https://postgr.es/m/94ae9bca-5ebb-1e68-bb7b-4f32e89fefbe@gmail.com

psql: Adjust capitalization of table heading

2023-05-16T04:13:59+00:00

for consistency with surrounding headings

Fix incorrect TAP test ordering

2023-05-15T05:11:22+00:00

Using a test function before a possible skip_all is incorrect.  If the
skip_all is called, the test output will become incorrect and the test
file will fail.

a4f23f9b3c introduced a new test before skip_all.  After discussion,
this doesn't really need to be a test.  Instead, we just bail out if
the condition is not satisfied.

Discussion: https://www.postgresql.org/message-id/af5567a1-aea6-fbdb-7e4b-d1e23a43c43b@enterprisedb.com

Fix whitespace inconsistencies

2023-05-15T04:27:40+00:00

Tighten usage of PSQL_WATCH_PAGER.

2023-05-12T20:11:14+00:00

Don't use PSQL_WATCH_PAGER when stdin/stdout are not a terminal.
This corresponds to the restrictions on when other commands will
use [PSQL_]PAGER.  There isn't a lot of sense in trying to use a
pager in non-interactive cases, and doing so allows an environment
setting to break our tests.

Also, ignore PSQL_WATCH_PAGER if it is set but empty or all-blank,
for the same reasons we ignore such settings of [PSQL_]PAGER (see
commit 18f8f784c).

No documentation change is really needed, since there is nothing
suggesting that these constraints on [PSQL_]PAGER didn't already
apply to PSQL_WATCH_PAGER too.  But I rearranged the text
a little to make it read more naturally (IMHO anyway).

Per report from Pavel Stehule.  Back-patch to v15 where
PSQL_WATCH_PAGER was introduced.

Discussion: https://postgr.es/m/CAFj8pRDTwFzmEWdA-gdAcUh0ZnxUioSfTMre71WyB_wNJy-8gw@mail.gmail.com