<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/postgresql.git/src/test/thread/Makefile, branch master</title>
<subtitle>git.postgresql.org: git/postgresql.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/'/>
<entry>
<title>Remove the option to build thread_test.c outside configure.</title>
<updated>2020-10-21T16:08:48+00:00</updated>
<author>
<name>Tom Lane</name>
<email>tgl@sss.pgh.pa.us</email>
</author>
<published>2020-10-21T16:08:48+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/commit/?id=8a2121185b26d7eb439860c7a96a08c0aa3c8508'/>
<id>8a2121185b26d7eb439860c7a96a08c0aa3c8508</id>
<content type='text'>
Theoretically one could go into src/test/thread and build/run this
program there.  In practice, that hasn't worked since 96bf88d52,
and probably much longer on some platforms (likely including just
the sort of hoary leftovers where this test might be of interest).
While it wouldn't be too hard to repair the breakage, the fact that
nobody has noticed for two years shows that there is zero usefulness
in maintaining this build pathway.  Let's get rid of it and decree
that thread_test.c is *only* meant to be built/used in configure.

Given that decision, it makes sense to put thread_test.c under config/
and get rid of src/test/thread altogether, so that's what I did.

In passing, update src/test/README, which had been ignored by some
not-so-recent additions of subdirectories.

Discussion: https://postgr.es/m/227659.1603041612@sss.pgh.pa.us
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Theoretically one could go into src/test/thread and build/run this
program there.  In practice, that hasn't worked since 96bf88d52,
and probably much longer on some platforms (likely including just
the sort of hoary leftovers where this test might be of interest).
While it wouldn't be too hard to repair the breakage, the fact that
nobody has noticed for two years shows that there is zero usefulness
in maintaining this build pathway.  Let's get rid of it and decree
that thread_test.c is *only* meant to be built/used in configure.

Given that decision, it makes sense to put thread_test.c under config/
and get rid of src/test/thread altogether, so that's what I did.

In passing, update src/test/README, which had been ignored by some
not-so-recent additions of subdirectories.

Discussion: https://postgr.es/m/227659.1603041612@sss.pgh.pa.us
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyrights for 2020</title>
<updated>2020-01-01T17:21:45+00:00</updated>
<author>
<name>Bruce Momjian</name>
<email>bruce@momjian.us</email>
</author>
<published>2020-01-01T17:21:45+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/commit/?id=7559d8ebfa11d98728e816f6b655582ce41150f3'/>
<id>7559d8ebfa11d98728e816f6b655582ce41150f3</id>
<content type='text'>
Backpatch-through: update all files in master, backpatch legal files through 9.4
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Backpatch-through: update all files in master, backpatch legal files through 9.4
</pre>
</div>
</content>
</entry>
<entry>
<title>Ensure link commands list *.o files before LDFLAGS.</title>
<updated>2019-01-02T18:57:54+00:00</updated>
<author>
<name>Tom Lane</name>
<email>tgl@sss.pgh.pa.us</email>
</author>
<published>2019-01-02T18:57:42+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/commit/?id=69ae9dcb444a667533344562f134444856fb3414'/>
<id>69ae9dcb444a667533344562f134444856fb3414</id>
<content type='text'>
It's important for link commands to list *.o input files before -l
switches for libraries, as library code may not get pulled into the link
unless referenced by an earlier command-line entry.  This is certainly
necessary for static libraries (.a style).  Apparently on some platforms
it is also necessary for shared libraries, as reported by Donald Dong.

We often put -l switches for within-tree libraries into LDFLAGS, meaning
that link commands that list *.o files after LDFLAGS are hazardous.
Most of our link commands got this right, but a few did not.  In
particular, places that relied on gmake's default implicit link rule
failed, because that puts LDFLAGS first.  Fix that by overriding the
built-in rule with our own.  The implicit link rules in
src/makefiles/Makefile.* for single-.o-file shared libraries mostly
got this wrong too, so fix them.  I also changed the link rules for the
backend and a couple of other places for consistency, even though they
are not (currently) at risk because they aren't adding any -l switches
to LDFLAGS.

Arguably, the real problem here is that we're abusing LDFLAGS by
putting -l switches in it and we should stop doing that.  But changing
that would be quite invasive, so I'm not eager to do so.

Perhaps this is a candidate for back-patching, but so far it seems
that problems can only be exhibited in test code we don't normally
build, and at least some of the problems are new in HEAD anyway.
So I'll refrain for now.

Donald Dong and Tom Lane

Discussion: https://postgr.es/m/CAKABAquXn-BF-vBeRZxhzvPyfMqgGuc74p8BmQZyCFDpyROBJQ@mail.gmail.com
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It's important for link commands to list *.o input files before -l
switches for libraries, as library code may not get pulled into the link
unless referenced by an earlier command-line entry.  This is certainly
necessary for static libraries (.a style).  Apparently on some platforms
it is also necessary for shared libraries, as reported by Donald Dong.

We often put -l switches for within-tree libraries into LDFLAGS, meaning
that link commands that list *.o files after LDFLAGS are hazardous.
Most of our link commands got this right, but a few did not.  In
particular, places that relied on gmake's default implicit link rule
failed, because that puts LDFLAGS first.  Fix that by overriding the
built-in rule with our own.  The implicit link rules in
src/makefiles/Makefile.* for single-.o-file shared libraries mostly
got this wrong too, so fix them.  I also changed the link rules for the
backend and a couple of other places for consistency, even though they
are not (currently) at risk because they aren't adding any -l switches
to LDFLAGS.

Arguably, the real problem here is that we're abusing LDFLAGS by
putting -l switches in it and we should stop doing that.  But changing
that would be quite invasive, so I'm not eager to do so.

Perhaps this is a candidate for back-patching, but so far it seems
that problems can only be exhibited in test code we don't normally
build, and at least some of the problems are new in HEAD anyway.
So I'll refrain for now.

Donald Dong and Tom Lane

Discussion: https://postgr.es/m/CAKABAquXn-BF-vBeRZxhzvPyfMqgGuc74p8BmQZyCFDpyROBJQ@mail.gmail.com
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyright for 2019</title>
<updated>2019-01-02T17:44:25+00:00</updated>
<author>
<name>Bruce Momjian</name>
<email>bruce@momjian.us</email>
</author>
<published>2019-01-02T17:44:25+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/commit/?id=97c39498e5ca9208d3de5a443a2282923619bf91'/>
<id>97c39498e5ca9208d3de5a443a2282923619bf91</id>
<content type='text'>
Backpatch-through: certain files through 9.4
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Backpatch-through: certain files through 9.4
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyright for 2018</title>
<updated>2018-01-03T04:30:12+00:00</updated>
<author>
<name>Bruce Momjian</name>
<email>bruce@momjian.us</email>
</author>
<published>2018-01-03T04:30:12+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/commit/?id=9d4649ca49416111aee2c84b7e4441a0b7aa2fac'/>
<id>9d4649ca49416111aee2c84b7e4441a0b7aa2fac</id>
<content type='text'>
Backpatch-through: certain files through 9.3
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Backpatch-through: certain files through 9.3
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyright via script for 2017</title>
<updated>2017-01-03T18:48:53+00:00</updated>
<author>
<name>Bruce Momjian</name>
<email>bruce@momjian.us</email>
</author>
<published>2017-01-03T18:48:53+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/commit/?id=1d25779284fe1ba08ecd57e647292a9deb241376'/>
<id>1d25779284fe1ba08ecd57e647292a9deb241376</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyright for 2016</title>
<updated>2016-01-02T18:33:40+00:00</updated>
<author>
<name>Bruce Momjian</name>
<email>bruce@momjian.us</email>
</author>
<published>2016-01-02T18:33:40+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/commit/?id=ee943004466418595363d567f18c053bae407792'/>
<id>ee943004466418595363d567f18c053bae407792</id>
<content type='text'>
Backpatch certain files through 9.1
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Backpatch certain files through 9.1
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyright for 2015</title>
<updated>2015-01-06T16:43:47+00:00</updated>
<author>
<name>Bruce Momjian</name>
<email>bruce@momjian.us</email>
</author>
<published>2015-01-06T16:43:47+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/commit/?id=4baaf863eca5412e07a8441b3b7e7482b7a8b21a'/>
<id>4baaf863eca5412e07a8441b3b7e7482b7a8b21a</id>
<content type='text'>
Backpatch certain files through 9.0
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Backpatch certain files through 9.0
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyright for 2014</title>
<updated>2014-01-07T21:05:30+00:00</updated>
<author>
<name>Bruce Momjian</name>
<email>bruce@momjian.us</email>
</author>
<published>2014-01-07T21:05:30+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/commit/?id=7e04792a1cbd1763edf72474f6b1fbad2cd0ad31'/>
<id>7e04792a1cbd1763edf72474f6b1fbad2cd0ad31</id>
<content type='text'>
Update all files in head, and files COPYRIGHT and legal.sgml in all back
branches.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update all files in head, and files COPYRIGHT and legal.sgml in all back
branches.
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyrights for 2013</title>
<updated>2013-01-01T22:15:01+00:00</updated>
<author>
<name>Bruce Momjian</name>
<email>bruce@momjian.us</email>
</author>
<published>2013-01-01T22:15:01+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/postgresql.git/commit/?id=bd61a623ace3f3db8da1c7936416706968ae6ec2'/>
<id>bd61a623ace3f3db8da1c7936416706968ae6ec2</id>
<content type='text'>
Fully update git head, and update back branches in ./COPYRIGHT and
legal.sgml files.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fully update git head, and update back branches in ./COPYRIGHT and
legal.sgml files.
</pre>
</div>
</content>
</entry>
</feed>
