diff options
| author | Jeff Davis <jdavis@postgresql.org> | 2023-04-21 08:19:41 -0700 |
|---|---|---|
| committer | Jeff Davis <jdavis@postgresql.org> | 2023-04-21 08:21:04 -0700 |
| commit | 5bcb15b8163a38f4875372888160628d4d872404 (patch) | |
| tree | 195cda703a6cd80ab64fa7ecba3af3617f3bd9da | |
| parent | e2e34dfff5e75ee52655053e94ad2acd51335d81 (diff) | |
| download | postgresql-5bcb15b8163a38f4875372888160628d4d872404.tar.gz | |
Avoid character classification in regex escape parsing.
For regex escape sequences, just test directly for the relevant ASCII
characters rather than using locale-sensitive character
classification.
This fixes an assertion failure when a locale considers a non-ASCII
character, such as "൧", to be a digit.
Reported-by: Richard Guo
Discussion: https://postgr.es/m/CAMbWs49Q6UoKGeT8pBkMtJGJd+16CBFZaaWUk9Du+2ERE5g_YA@mail.gmail.com
Backpatch-through: 11
| -rw-r--r-- | src/backend/regex/regc_lex.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/src/backend/regex/regc_lex.c b/src/backend/regex/regc_lex.c index d573032db6..4e6fa5c613 100644 --- a/src/backend/regex/regc_lex.c +++ b/src/backend/regex/regc_lex.c @@ -750,7 +750,11 @@ lexescape(struct vars *v) assert(!ATEOS()); c = *v->now++; - if (!iscalnum(c)) + + /* if it's not alphanumeric ASCII, treat it as a plain character */ + if (!('a' <= c && c <= 'z') && + !('A' <= c && c <= 'Z') && + !('0' <= c && c <= '9')) RETV(PLAIN, c); NOTE(REG_UNONPOSIX); @@ -892,8 +896,11 @@ lexescape(struct vars *v) RETV(PLAIN, c); break; default: - assert(iscalpha(c)); - FAILW(REG_EESCAPE); /* unknown alphabetic escape */ + /* + * Throw an error for unrecognized ASCII alpha escape sequences, + * which reserves them for future use if needed. + */ + FAILW(REG_EESCAPE); break; } assert(NOTREACHED); |