diff options
| author | Bruce Momjian <bruce@momjian.us> | 2001-09-06 03:13:34 +0000 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2001-09-06 03:13:34 +0000 |
| commit | e30b283f30c39648abc17e14b709ad93f53aac95 (patch) | |
| tree | a3258bb5d7c2dfd999b58779aac76d44e7437f25 /src/interfaces/jdbc/org/postgresql/jdbc2/Connection.java | |
| parent | d99794e613a74fd4810f51db4f1af405fd3b5507 (diff) | |
| download | postgresql-e30b283f30c39648abc17e14b709ad93f53aac95.tar.gz | |
Attached is my attempt to clean up the horrors of the ExecSQL() method in
the JDBC driver.
I've done this by extracting it into a new method object called
QueryExecutor (should go into org/postgresql/core/) and then taking it
apart into different methods in that class.
A short summary:
* Extracted ExecSQL() from Connection into a method object called
QueryExecutor.
* Moved ReceiveFields() from Connection to QueryExecutor.
* Extracted parts of the original ExecSQL() method body into smaller
methods on QueryExecutor.
* Bug fix: The instance variable "pid" in Connection was used in two
places with different meaning. Both were probably in dead code, but it's
fixed anyway.
Anders Bengtsson
Diffstat (limited to 'src/interfaces/jdbc/org/postgresql/jdbc2/Connection.java')
| -rw-r--r-- | src/interfaces/jdbc/org/postgresql/jdbc2/Connection.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/interfaces/jdbc/org/postgresql/jdbc2/Connection.java b/src/interfaces/jdbc/org/postgresql/jdbc2/Connection.java index 5b4c17d7c4..f705693983 100644 --- a/src/interfaces/jdbc/org/postgresql/jdbc2/Connection.java +++ b/src/interfaces/jdbc/org/postgresql/jdbc2/Connection.java @@ -17,7 +17,7 @@ import org.postgresql.largeobject.*; import org.postgresql.util.*; /** - * $Id: Connection.java,v 1.10 2001/08/24 16:50:16 momjian Exp $ + * $Id: Connection.java,v 1.11 2001/09/06 03:13:34 momjian Exp $ * * A Connection represents a session with a specific database. Within the * context of a Connection, SQL statements are executed and results are @@ -204,7 +204,7 @@ public class Connection extends org.postgresql.Connection implements java.sql.Co * This overides the method in org.postgresql.Connection and returns a * ResultSet. */ - protected java.sql.ResultSet getResultSet(org.postgresql.Connection conn, java.sql.Statement stat,Field[] fields, Vector tuples, String status, int updateCount, int insertOID) throws SQLException + public java.sql.ResultSet getResultSet(org.postgresql.Connection conn, java.sql.Statement stat,Field[] fields, Vector tuples, String status, int updateCount, int insertOID) throws SQLException { // In 7.1 we now test concurrency to see which class to return. If we are not working with a // Statement then default to a normal ResultSet object. |