summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* MemSet() must not cast its pointer argument to int32* until after it hasTom Lane2005-07-181-4/+5
| | | | | | | checked that the pointer is actually word-aligned. Casting a non-aligned pointer to int32* is technically illegal per the C spec, and some recent versions of gcc actually generate bad code for the memset() when given such a pointer. Per report from Andrew Morrow.
* Make pg_regress accept a command-line option for the temporary installation'sTom Lane2005-07-172-5/+19
| | | | | | | port number, and use a default value for it that is dependent on the configuration-time DEF_PGPORT. Should make the world safe for running parallel 'make check' in different branches. Back-patch as far as 7.4 so that this actually is useful.
* Fix create_unique_plan() so it doesn't generate useless entries in theTom Lane2005-07-151-28/+45
| | | | | | | | output targetlist of the Unique or HashAgg plan. This code was OK when written, but subsequent changes to use "physical tlists" where possible had broken it: given an input subplan that has extra variables added to avoid a projection step, it would copy those extra variables into the upper tlist, which is pointless since a projection has to happen anyway.
* Check for out-of-range varoattno in deparse_context_for_subplan.Tom Lane2005-07-151-5/+11
| | | | | | | I have seen this case in CVS tip due to new "physical tlist" optimization for subqueries. I believe it probably can't happen in existing releases, but the check is not going to hurt anything, so backpatch to 8.0 just in case.
* Fix overenthusiastic optimization of 'x IN (SELECT DISTINCT ...)' and relatedTom Lane2005-07-153-45/+210
| | | | | | | cases: we can't just consider whether the subquery's output is unique on its own terms, we have to check whether the set of output columns we are going to use will be unique. Per complaint from Luca Pireddu and test case from Michael Fuhr.
* Adjust permissions checking for ALTER OWNER commands: instead ofTom Lane2005-07-1412-109/+229
| | | | | | | | | | | requiring superuserness always, allow an owner to reassign ownership to any role he is a member of, if that role would have the right to create a similar object. These three requirements essentially state that the would-be alterer has enough privilege to DROP the existing object and then re-CREATE it as the new role; so we might as well let him do it in one step. The ALTER TABLESPACE case is a bit squirrely, but the whole concept of non-superuser tablespace owners is pretty dubious anyway. Stephen Frost, code review by Tom Lane.
* Enable multi-byte thousands_sep and decimal_point for numericsep.Bruce Momjian2005-07-141-37/+39
|
* Make better thousands_sep default based on decimal marker value.Bruce Momjian2005-07-141-2/+4
|
* Change numericsep to a boolean, and make it locale-aware.Bruce Momjian2005-07-144-71/+89
|
* Add numeric separator support for latex and troff output methods.Bruce Momjian2005-07-141-19/+67
|
* barebones variable name -> tuples_only, for consistency.Bruce Momjian2005-07-142-51/+51
|
* Fix malloc length for new numeric separator patch.Bruce Momjian2005-07-141-62/+26
| | | | Centralize malloc into function.
* Integrate autovacuum functionality into the backend. There's still aTom Lane2005-07-1423-87/+1451
| | | | | few loose ends to be dealt with, but it seems to work. Alvaro Herrera, based on the contrib code by Matthew O'Connor.
* Fix a couple of bogus comments, per Alvaro.Tom Lane2005-07-132-5/+5
|
* Remove extraneous space after -L ... it confuses SHLIB_LINK filter -LTom Lane2005-07-131-2/+2
| | | | hack.
* Fix unwanted side-effects of recent SHLIB_LINK -L patch on existingTom Lane2005-07-131-6/+9
| | | | hacking of SHLIB_LINK for HPUX.
* Fix #elif spacing too.Bruce Momjian2005-07-131-1/+2
|
* Fix libpq memory leak during PQreset() --- closePGconn() was notTom Lane2005-07-131-2/+30
| | | | freeing all transient state of the PGconn object.
* Fix pgindent to not have blank line before #else in variable definitionBruce Momjian2005-07-131-2/+3
| | | | section of a function.
* Add backslashes to parentheses in awk regex because if not, they areBruce Momjian2005-07-131-6/+6
| | | | treated as regex groups.
* Move -L flag around for shared builds:Bruce Momjian2005-07-131-2/+2
| | | | | | | | | | | | I wrote: > So either we code up some intelligence to put the "C" in the right > position or we have to pass down "A B" and "D" separately from the > main makefile. The following patch might just do the former. Please try it out. Peter E.
* Hack around the discrepancy between default library search paths forTom Lane2005-07-121-1/+8
| | | | | gcc and for HP's ld on HPUX. There may be better ways to do this, but this seems to work for me...
* Fix plperl crash with list value return for an array result type.Tom Lane2005-07-121-3/+3
| | | | Reported by Michael Fuhr, fixed by Andrew Dunstan.
* Improve comments for AdjustIntervalForTypmod.Bruce Momjian2005-07-126-25/+14
| | | | Blank line adjustments.
* Change 5e0 to 5.0, for consistency.Bruce Momjian2005-07-123-33/+33
|
* Fix plperl to do recursion safely, and fix a problem with array results.Tom Lane2005-07-123-19/+128
| | | | Add suitable regression tests. Andrew Dunstan
* Missed adding extra argument to array_recv in a couple of placesTom Lane2005-07-102-6/+8
| | | | (harmless, actually, but let's be tidy).
* Change typreceive function API so that receive functions get the sameTom Lane2005-07-1017-137/+325
| | | | | | | optional arguments as text input functions, ie, typioparam OID and atttypmod. Make all the datatypes that use typmod enforce it the same way in typreceive as they do in typinput. This fixes a problem with failure to enforce length restrictions during COPY FROM BINARY.
* Rename xmalloc to pg_malloc for consistency with psql usage.Bruce Momjian2005-07-103-25/+26
| | | | Add missing plperl include.
* Reverse pg_malloc patch because psql/print.c is used in scripts filesBruce Momjian2005-07-101-11/+62
| | | | that don't have pg_malloc.
* Use failure-safe pg_malloc consistently in psql/print.c.Bruce Momjian2005-07-101-62/+11
|
* Following up a previous thought I had, yesterday I realised how toBruce Momjian2005-07-101-6/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | return arays nicely without having to make the plperl programmer aware of anything. The attached patch allows plperl to return an arrayref where the function returns an array type. It silently calls a perl function to stringify the array before passing it to the pg array parser. Non-array returns are handled as before (i.e. passed through this process) so it is backwards compatible. I will presently submit regression tests and docs. example: andrew=# create or replace function blah() returns text[][] language plperl as $$ return [['a"b','c,d'],['e\\f','g']]; $$; CREATE FUNCTION andrew=# select blah(); blah ----------------------------- {{"a\"b","c,d"},{"e\\f",g}} This would complete half of the TODO item: . Pass arrays natively instead of as text between plperl and postgres (The other half is translating pg array arguments to perl arrays - that will have to wait for 8.1). Some of this patch is adapted from a previously submitted patch from Sergej Sergeev. Both he and Abhijit Menon-Sen have looked it over briefly and tentatively said it looks ok. Andrew Dunstan
* The attached patch implements spi_query() and spi_fetchrow() functionsBruce Momjian2005-07-105-1/+125
| | | | | | | | | | | | | | | | | for PL/Perl, to avoid loading the entire result set into memory as the existing spi_exec_query() function does. Here's how one might use the new functions: $x = spi_query("select ..."); while (defined ($y = spi_fetchrow($x))) { ... return_next(...); } The changes do not affect the spi_exec_query() interface in any way. Abhijit Menon-Sen
* Add --encoding to pg_dump.Bruce Momjian2005-07-101-2/+18
| | | | | | | | | | | | The Problem: Occassionally a DBA needs to dump a database to a new encoding. In instances where the current encoding, (or lack of an encoding, like SQL_ASCII) is poorly supported on the target database server, it can be useful to dump into a particular encoding. But, currently the only way to set the encoding of a pg_dump file is to change client_encoding in postgresql.conf and restart postmaster. This is more than a little awkward for production systems. Magnus Hagander
* This patch implements putting language handlers for the optional PLsBruce Momjian2005-07-104-47/+125
| | | | | | | | | | | | | | | | into pg_catalog rather than public, and supports dumping languages whose handlers are found there. This will make it easier to drop the public schema if desired. Unlike the previous patch, the comments have been updated and I have reformatted some code to meet Alvarro's request to stick to 80 cols. (I actually aghree with this - it makes printing the code much nicer). I think I did the right thing w.r.t versions earlier than 7.3, but I have no real way of checking, so that should be checked by someone with more/older knowledge than me ;-) Andrew Dunstan
* This patch addresses the problem mentioned in the "process crashBruce Momjian2005-07-107-4/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when a plpython function returns unicode" thread: http://archives.postgresql.org/pgsql-bugs/2005-06/msg00105.php In several places PL/Python was calling PyObject_Str() and then PyString_AsString() without checking if the former had returned NULL to indicate an error. PyString_AsString() doesn't expect a NULL argument, so passing one causes a segmentation fault. This patch adds checks for NULL and raises errors via PLy_elog(), which prints details of the underlying Python exception. The patch also adds regression tests for these checks. All tests pass on my Solaris 9 box running HEAD and Python 2.4.1. In one place the patch doesn't call PLy_elog() because that could cause infinite recursion; see the comment I added. I'm not sure how to test that particular case or whether it's even possible to get an error there: the value that the code should check is the Python exception type, so I wonder if a NULL value "shouldn't happen." This patch converts NULL to "Unknown Exception" but I wonder if an Assert() would be appropriate. The patch is against HEAD but the same changes should be applied to earlier versions because they have the same problem. The patch might not apply cleanly against earlier versions -- will the committer take care of little differences or should I submit different versions of the patch? Michael Fuhr
* I made the patch that implements regexp_replace again.Bruce Momjian2005-07-109-54/+397
| | | | | | | | | | | | | | | | | | | | | | | The specification of this function is as follows. regexp_replace(source text, pattern text, replacement text, [flags text]) returns text Replace string that matches to regular expression in source text to replacement text. - pattern is regular expression pattern. - replacement is replace string that can use '\1'-'\9', and '\&'. '\1'-'\9': back reference to the n'th subexpression. '\&' : entire matched string. - flags can use the following values: g: global (replace all) i: ignore case When the flags is not specified, case sensitive, replace the first instance only. Atsushi Ogawa
* Add psql \pset numericsep to allow output numbers like 100,000.0 orBruce Momjian2005-07-104-86/+295
| | | | | | 100.000,0. Eugen Nedelcu
* Fix config file lexer to not barf if postgresql.conf ends with a commentTom Lane2005-07-081-2/+2
| | | | that has no terminating newline. Per report from maps.on at gmx.net.
* Try connecting to both postgres and template1 databases to do the initialTom Lane2005-07-081-28/+46
| | | | | | | | | inspection of shared catalogs. This allows pg_dumpall to continue to work with pre-8.1 servers that likely won't have a database named postgres. Also, suppress output of SYSID options for users and groups, since server no longer does anything with these except emit a rude message. There is much more to be done to update pg_dumpall for the roles feature, but this at least makes it usable again. Per gripe from Chris K-L.
* Make libpq_gettext save and restore errno in a Windows-compatible way.Tom Lane2005-07-081-1/+5
| | | | Also, back-patch fix into back branches.
* testing activitymailPostgreSQL Daemon2005-07-081-1/+1
|
* Remove some dead code for handling XLOG_DBASE_CREATE_OLD andNeil Conway2005-07-083-103/+6
| | | | | | XLOG_DBASE_DROP_OLD WAL records -- these records are no longer created in current sources. Adjust numbering of XLOG_DBASE_CREATE and XLOG_DBASE_DROP and bump the catversion. Patch from Gavin Sherry, adjusted by Neil Conway.
* Even though I'd like to see full_page_writes go away before 8.1,Tom Lane2005-07-081-5/+4
| | | | | a minimum requirement is that it not completely break the system meanwhile. Put the test in the right place.
* Track dependencies on shared objects (which is to say, roles; we alreadyTom Lane2005-07-0737-82/+1685
| | | | | | | have adequate mechanisms for tracking the contents of databases and tablespaces). This solves the longstanding problem that you can drop a user who still owns objects and/or has access permissions. Alvaro Herrera, with some kibitzing from Tom Lane.
* Fix plperl expected output.Bruce Momjian2005-07-071-1/+0
| | | | Andrew Dunstan
* pg_column_size() cleanup for messages and code cleanup.Bruce Momjian2005-07-071-14/+6
| | | | Mark Kirkwood
* Currently, nonfatal warnings are not trapped (as they should be) byBruce Momjian2005-07-064-2/+54
| | | | | | | | plperl - the attached small patch remedies that omission, and adds a small regression test for error and warning output - the new regression input and expected output are in separate attached files. Andrew Dunstan
* Currently, nonfatal warnings are not trapped (as they should be) byBruce Momjian2005-07-062-3/+7
| | | | | | plperl - the attached small patch remedies that omission. Andrew Dunstan
* Complete zic patch backout by removing NO_PGPORT workaround.Bruce Momjian2005-07-062-7/+7
|