summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Undo 8.4-era lobotomization of subquery pullup rules.Tom Lane2012-01-271-69/+149
| | | | | | | | | | | | | | | | | | | After the planner was fixed to convert some IN/EXISTS subqueries into semijoins or antijoins, we had to prevent it from doing that in some cases where the plans risked getting much worse. The reason the plans got worse was that in the unoptimized implementation, subqueries could reference parameters from the outer query at any join level, and so full table scans could be avoided even if they were one or more levels of join below where the semi/anti join would be. Now that we have sufficient mechanism in the planner to handle such cases properly, it should no longer be necessary to play dumb here. This reverts commits 07b9936a0f10d746e5076239813a5e938f2f16be and cd1f0d04bf06938c0ee5728fc8424d62bcf2eef3. The latter was a stopgap fix that wasn't really sufficiently analyzed at the time. Rather than just restricting ourselves to cases where the new join can be stacked on the right-hand input, we should also consider whether it can be stacked on the left-hand input.
* Use parameterized paths to generate inner indexscans more flexibly.Tom Lane2012-01-2725-2272/+3865
| | | | | | | | | | | | | | | | | | | This patch fixes the planner so that it can generate nestloop-with- inner-indexscan plans even with one or more levels of joining between the indexscan and the nestloop join that is supplying the parameter. The executor was fixed to handle such cases some time ago, but the planner was not ready. This should improve our plans in many situations where join ordering restrictions formerly forced complete table scans. There is probably a fair amount of tuning work yet to be done, because of various heuristics that have been added to limit the number of parameterized paths considered. However, we are not going to find out what needs to be adjusted until the code gets some real-world use, so it's time to get it in there where it can be tested easily. Note API change for index AM amcostestimate functions. I'm not aware of any non-core index AMs, but if there are any, they will need minor adjustments.
* Show default privileges in information schemaPeter Eisentraut2012-01-277-18/+79
| | | | | | | | | | | | Hitherto, the information schema only showed explicitly granted privileges that were visible in the *acl catalog columns. If no privileges had been granted, the implicit privileges were not shown. To fix that, add an SQL-accessible version of the acldefault() function, and use that inside the aclexplode() calls to substitute the catalog-specific default privilege set for null values. reviewed by Abhijit Menon-Sen
* Revert unfortunate whitespace changePeter Eisentraut2012-01-271-0/+2
| | | | | | | In e5e2fc842c418432756d8b5825ff107c6c5fc4c3, blank lines were removed after a comment block, which now looks as though the comment refers to the immediately following code, but it actually refers to the preceding code. So put the blank lines back.
* Disallow ALTER DOMAIN on non-domain type everywherePeter Eisentraut2012-01-273-6/+20
| | | | | | This has been the behavior already in most cases, but through omission, ALTER DOMAIN / OWNER TO and ALTER DOMAIN / SET SCHEMA would silently work on non-domain types as well.
* Hide most variable-length fields from Form_pg_* structsPeter Eisentraut2012-01-2732-49/+85
| | | | | | | | | | | | | Those fields only appear in the structs so that genbki.pl can create the BKI bootstrap files for the catalogs. But they are not actually usable from C. So hiding them can prevent coding mistakes, saves stack space, and can help the compiler. In certain catalogs, the first variable-length field has been kept visible after manual inspection. These exceptions are noted in C comments. reviewed by Tom Lane
* Do not access indclass through Form_pg_indexPeter Eisentraut2012-01-271-1/+16
| | | | | | | | | | | | Normally, accessing variable-length members of catalog structures past the first one doesn't work at all. Here, it happened to work because indnatts was checked to be 1, and so the defined FormData_pg_index layout, using int2vector[1] and oidvector[1] for variable-length arrays, happened to match the actual memory layout. But it's a very fragile assumption, and it's not in a performance-critical path, so code it properly using heap_getattr() instead. bug analysis by Tom Lane
* Initialize the new bgwriterLatch field properly.Heikki Linnakangas2012-01-271-0/+1
| | | | Peter Geoghegan
* pg_dump: Move connection-setup code to a separate function.Robert Haas2012-01-271-65/+74
| | | | | | | | Parallel dump will need to repeat these steps for each new connection, so it's better to have this logic in its own function. Extracted (with some changes) from a much larger patch by Joachim Wieland.
* Adjust tuplesort.c based on the fact that we never use the OS's qsort().Robert Haas2012-01-261-12/+12
| | | | | | | | | | Our own qsort_arg() implementation doesn't have the defect previously observed to affect only QNX 4, so it seems sufficiently to assert that it isn't broken rather than retesting. Also, update a few comments to clarify why it's valuable to retain a tie-break rule based on CTID during index builds. Peter Geoghegan, with slight tweaks by me.
* Be more clear when a new column name collides with a system column name.Robert Haas2012-01-264-21/+49
| | | | | | | | | We now use the same error message for ALTER TABLE .. ADD COLUMN or ALTER TABLE .. RENAME COLUMN that we do for CREATE TABLE. The old message was accurate, but might be confusing to users not aware of our system columns. Vik Reykja, with some changes by me, and further proofreading by Tom Lane
* Make bgwriter sleep longer when it has no work to do, to save electricity.Heikki Linnakangas2012-01-264-26/+163
| | | | | | | | | To make it wake up promptly when activity starts again, backends nudge it by setting a latch in MarkBufferDirty(). The latch is kept set while bgwriter is active, so there is very little overhead from that when the system is busy. It is only armed before going into longer sleep. Peter Geoghegan, with some changes by me.
* Add missing #include, to suppress compiler warning.Robert Haas2012-01-261-0/+1
|
* Fix a copy/pasted typo in several commentsMagnus Hagander2012-01-261-3/+3
|
* Add deadlock counter to pg_stat_databaseMagnus Hagander2012-01-268-6/+81
| | | | | | | Adds a counter that tracks number of deadlocks that occurred in each database to pg_stat_database. Magnus Hagander, reviewed by Jaime Casanova
* Classify DROP operations by whether or not they are user-initiated.Robert Haas2012-01-2614-30/+61
| | | | | | | This doesn't do anything useful just yet, but is intended as supporting infrastructure for allowing sepgsql to sensibly check DROP permissions. KaiGai Kohei and Robert Haas
* Track temporary file count and size in pg_stat_databaseMagnus Hagander2012-01-268-23/+125
| | | | | | | | Add counters for number and size of temporary files used for spill-to-disk queries for each database to the pg_stat_database view. Tomas Vondra, review by Magnus Hagander
* Damage control for yesterday's CheckIndexCompatible changes.Robert Haas2012-01-263-26/+25
| | | | | | Rip out a regression test that doesn't play well with settings put in place by the build farm, and rewrite the code in CheckIndexCompatible in a hopefully more transparent style.
* Instrument index-only scans to count heap fetches performed.Robert Haas2012-01-253-0/+7
| | | | Patch by me; review by Tom Lane, Jeff Davis, and Peter Geoghegan.
* Have \copy go through SendQueryAlvaro Herrera2012-01-255-126/+250
| | | | | | | | | | | | | | | | This enables a bunch of features, notably ON_ERROR_ROLLBACK. It also makes COPY failure (either in the server or psql) as a whole behave more sanely in psql. Additionally, having more commands in the same command line as COPY works better (though since psql splits lines at semicolons, this doesn't matter much unless you're using -c). Also tighten a couple of switches on PQresultStatus() to add PGRES_COPY_BOTH support and stop assuming that unknown statuses received are errors; have those print diagnostics where warranted. Author: Noah Misch
* Make CheckIndexCompatible simpler and more bullet-proof.Robert Haas2012-01-253-55/+67
| | | | | | | | | This gives up the "don't rewrite the index" behavior in a couple of relatively unimportant cases, such as changing between an array type and an unconstrained domain over that array type, in return for making this code more future-proof. Noah Misch
* Allow pg_basebackup from standby node with safety checking.Simon Riggs2012-01-2510-44/+459
| | | | | | | Base backup follows recommended procedure, plus goes to great lengths to ensure that partial page writes are avoided. Jun Ishizuka and Fujii Masao, with minor modifications
* Add pg_trigger_depth() functionAlvaro Herrera2012-01-255-1/+206
| | | | | | | | | | This reports the depth level of triggers currently in execution, or zero if not called from inside a trigger. No catversion bump in this patch, but you have to initdb if you want access to the new function. Author: Kevin Grittner
* Add new replication mode synchronous_commit = 'write'.Simon Riggs2012-01-246-44/+98
| | | | | | | | | Replication occurs only to memory on standby, not to disk, so provides additional performance if user wishes to reduce durability level slightly. Adds concept of multiple independent sync rep queues. Fujii Masao and Simon Riggs
* Remove quotes around format_type_be() outputPeter Eisentraut2012-01-241-1/+1
| | | | format_type_be() takes care of any needed quoting itself.
* Suppress variable-clobbered-by-longjmp warning seen with older gcc versions.Tom Lane2012-01-241-1/+1
|
* Suppress possibly-uninitialized-variable warning seen with older gcc versions.Tom Lane2012-01-241-3/+3
|
* Reduce tab outdent of "error handling" GUC comments in postgresql.conf,Bruce Momjian2012-01-241-2/+2
| | | | to match surrounding outdenting.
* Adjustments to regression tests for security_barrier views.Robert Haas2012-01-243-86/+96
| | | | | | | | | Drop the role we create, so regression tests pass even when run more than once against the same cluster, a problem noted by Tom Lane and Jeff Janes. Also, rename the temporary role so that it starts with "regress_", to make it unlikely that we'll collide with an existing role name while running "make installcheck", per further gripe from Tom Lane.
* Resolve timing issue with logging locks for Hot Standby.Simon Riggs2012-01-234-44/+88
| | | | | | | | | | We log AccessExclusiveLocks for replay onto standby nodes, but because of timing issues on ProcArray it is possible to log a lock that is still held by a just committed transaction that is very soon to be removed. To avoid any timing issue we avoid applying locks made by transactions with InvalidXid. Simon Riggs, bug report Tom Lane, diagnosis Pavan Deolasee
* ALTER <thing> [IF EXISTS] ... allows silent DDL if required,Simon Riggs2012-01-2314-29/+461
| | | | | | e.g. ALTER FOREIGN TABLE IF EXISTS foo RENAME TO bar Pavel Stehule
* psql: Add support for tab completion of GRANT/REVOKE rolePeter Eisentraut2012-01-211-10/+53
| | | | | | Previously, only GRANT/REVOKE privilege was supported. reviewed by Pavel Stehule
* Check number of fields in IDENTIFY_SYSTEM responseMagnus Hagander2012-01-203-7/+15
| | | | Jaime Casanova
* Further doc cleanups from the pg_stat_activity changesMagnus Hagander2012-01-201-1/+1
| | | | Fujii Masao
* Add bitwise AND, OR, and NOT operators for macaddr data type.Robert Haas2012-01-197-1/+119
| | | | Brendan Jurd, reviewed by Fujii Masao
* Separate state from query string in pg_stat_activityMagnus Hagander2012-01-199-71/+159
| | | | | | | | | | | | | | | | This separates the state (running/idle/idleintransaction etc) into it's own field ("state"), and leaves the query field containing just query text. The query text will now mean "current query" when a query is running and "last query" in other states. Accordingly,the field has been renamed from current_query to query. Since backwards compatibility was broken anyway to make that, the procpid field has also been renamed to pid - along with the same field in pg_stat_replication for consistency. Scott Mead and Magnus Hagander, review work from Greg Smith
* Make pg_relation_size() and friends return NULL if the object doesn't exist.Heikki Linnakangas2012-01-191-35/+84
| | | | | | | That avoids errors when the functions are used in queries like "SELECT pg_relation_size(oid) FROM pg_class", and a table is dropped concurrently. Phil Sorber
* Fix corner case in cleanup of transactions using SSI.Heikki Linnakangas2012-01-181-3/+23
| | | | | | | | | | | | | | | | | When the only remaining active transactions are READ ONLY, we do a "partial cleanup" of committed transactions because certain types of conflicts aren't possible anymore. For committed r/w transactions, we release the SIREAD locks but keep the SERIALIZABLEXACT. However, for committed r/o transactions, we can go further and release the SERIALIZABLEXACT too. The problem was with the latter case: we were returning the SERIALIZABLEXACT to the free list without removing it from the finished list. The only real change in the patch is the SHMQueueDelete line, but I also reworked some of the surrounding code to make it obvious that r/o and r/w transactions are handled differently -- the existing code felt a bit too clever. Dan Ports
* Show psql timing output for failed queries as well as successful onesMagnus Hagander2012-01-181-1/+1
| | | | | This is useful for example when a long-runing statement such as CREATE INDEX fails after a long time.
* Fix warning about unused variableMagnus Hagander2012-01-181-3/+1
|
* Regression tests for security_barrier views.Robert Haas2012-01-173-0/+636
| | | | KaiGai Kohei
* Catch fatal flex errors in the GUC file lexer.Robert Haas2012-01-171-12/+53
| | | | | | | | | This prevents the postmaster from unexpectedly croaking if postgresql.conf contains something like: include 'invalid_directory_name' Noah Misch. Reviewed by Tom Lane and myself.
* fastgetattr is in access/htup.h, not access/heapam.hRobert Haas2012-01-161-1/+1
| | | | Noted by Peter Geoghegan
* Disallow merging ONLY constraints in children tablesAlvaro Herrera2012-01-162-9/+32
| | | | | | | | | | | | When creating a child table, or when attaching an existing table as child of another, we must not allow inheritable constraints to be merged with non-inheritable ones, because then grandchildren would not properly get the constraint. This would violate the grandparent's expectations. Bugs noted by Robert Haas. Author: Nikhil Sontakke
* psql: Fix memory leakPeter Eisentraut2012-01-161-0/+3
| | | | | | | | The command \password username leaked memory.
* Prevent adding relations to a concurrently dropped schema.Robert Haas2012-01-167-59/+158
| | | | | | | | | | | | | | | | | | | | | | | | | In the previous coding, it was possible for a relation to be created via CREATE TABLE, CREATE VIEW, CREATE SEQUENCE, CREATE FOREIGN TABLE, etc. in a schema while that schema was meanwhile being concurrently dropped. This led to a pg_class entry with an invalid relnamespace value. The same problem could occur if a relation was moved using ALTER .. SET SCHEMA while the target schema was being concurrently dropped. This patch prevents both of those scenarios by locking the schema to which the relation is being added using AccessShareLock, which conflicts with the AccessExclusiveLock taken by DROP. As a desirable side effect, this also prevents the use of CREATE OR REPLACE VIEW to queue for an AccessExclusiveLock on a relation on which you have no rights: that will now fail immediately with a permissions error, before trying to obtain a lock. We need similar protection for all other object types, but as everything other than relations uses a slightly different set of code paths, I'm leaving that for a separate commit. Original complaint (as far as I could find) about CREATE by Nikhil Sontakke; risk for ALTER .. SET SCHEMA pointed out by Tom Lane; further details by Dan Farina; patch by me; review by Hitoshi Harada.
* Improve efficiency of recent changes to plperl's sv2cstr().Andrew Dunstan2012-01-154-9/+23
| | | | | | Along the way, add a missing dependency in the GNUmakefile. Alex Hunsaker, with a slight adjustment by me.
* Fix poll() implementation of WaitLatchOrSocket to notice postmaster death.Heikki Linnakangas2012-01-151-1/+6
| | | | | | | When the remote end of the pipe is closed, select() reports the fd as readable, but poll() has a separate POLLHUP return code for that. Spotted by Peter Geoghegan.
* Allow a user to kill his own queries using pg_cancel_backend()Magnus Hagander2012-01-151-10/+70
| | | | | | | | | Allows a user to use pg_cancel_queries() to cancel queries in other backends if they are running under the same role. pg_terminate_backend() still requires superuser permissoins. Short patch, many authors working on the bikeshed: Magnus Hagander, Josh Kupershmidt, Edward Muller, Greg Smith.
* Detect invalid permutations in isolationtesterAlvaro Herrera2012-01-141-1/+47
| | | | | | | | isolationtester is now able to continue running other permutations when it detects that one of them is invalid, which is useful during initial development of spec files. Author: Alexander Shulgin
View Lorry Controller Status