From 5d6728e588c37a4e458db9d55b308c8a3832a944 Mon Sep 17 00:00:00 2001 From: Peter Geoghegan Date: Mon, 10 Apr 2023 11:15:41 -0700 Subject: Fix nbtree posting list update desc output. We cannot use the generic array_desc approach with per-tuple nbtree posting list update metadata because array_desc can only deal with fixed width elements (e.g., page offset numbers). Using array_desc led to incorrect rmgr descriptions for updates from nbtree DELETE/VACUUM WAL records. To fix, add specialized code to describe the update metadata as array elements in desc output. We now iterate over the update metadata using an approach that matches related REDO routines. Also stop showing the updates offset number array separately in nbtree DELETE/VACUUM desc output. It's redundant information, since the same page offset numbers appear in the description of each individual update element. Also make some small tweaks to the way that we format arrays in all desc routines (not just nbtree desc routines) to make arrays a little less verbose. Oversight in commit 1c453cfd, which enhanced the nbtree rmgr desc routines. Author: Peter Geoghegan Discussion: https://postgr.es/m/CAH2-WzkbYuvwYKm-Y-72QEh6SPMQcAo9uONv+mR3bMGcu9E_Cg@mail.gmail.com --- doc/src/sgml/pgwalinspect.sgml | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) (limited to 'doc') diff --git a/doc/src/sgml/pgwalinspect.sgml b/doc/src/sgml/pgwalinspect.sgml index b3712be009..a1a4422fb4 100644 --- a/doc/src/sgml/pgwalinspect.sgml +++ b/doc/src/sgml/pgwalinspect.sgml @@ -71,19 +71,19 @@ after the in_lsn argument. For example: -postgres=# SELECT * FROM pg_get_wal_record_info('0/E84F5E8'); --[ RECORD 1 ]----+-------------------------------------------------- -start_lsn | 0/E84F5E8 -end_lsn | 0/E84F620 -prev_lsn | 0/E84F5A8 +postgres=# SELECT * FROM pg_get_wal_record_info('0/E419E28'); +-[ RECORD 1 ]----+------------------------------------------------- +start_lsn | 0/E419E28 +end_lsn | 0/E419E68 +prev_lsn | 0/E419D78 xid | 0 resource_manager | Heap2 record_type | VACUUM -record_length | 50 +record_length | 58 main_data_length | 2 fpi_length | 0 -description | nunused: 1, unused: [ 22 ] -block_ref | blkref #0: rel 1663/16389/20884 fork main blk 126 +description | nunused: 5, unused: [1, 2, 3, 4, 5] +block_ref | blkref #0: rel 1663/16385/1249 fork main blk 364 @@ -144,18 +144,18 @@ block_ref | references. Returns one row per block reference per WAL record. For example: -postgres=# SELECT * FROM pg_get_wal_block_info('0/10E9D80', '0/10E9DC0'); +postgres=# SELECT * FROM pg_get_wal_block_info('0/1230278', '0/12302B8'); -[ RECORD 1 ]-----+----------------------------------- -start_lsn | 0/10E9D80 -end_lsn | 0/10E9DC0 -prev_lsn | 0/10E9860 +start_lsn | 0/1230278 +end_lsn | 0/12302B8 +prev_lsn | 0/122FD40 block_id | 0 reltablespace | 1663 reldatabase | 1 -relfilenode | 2690 +relfilenode | 2658 relforknumber | 0 -relblocknumber | 5 -xid | 117 +relblocknumber | 11 +xid | 341 resource_manager | Btree record_type | INSERT_LEAF record_length | 64 @@ -163,8 +163,8 @@ main_data_length | 2 block_data_length | 16 block_fpi_length | 0 block_fpi_info | -description | off 14 -block_data | \x00005400020010001407000000000000 +description | off: 46 +block_data | \x00002a00070010402630000070696400 block_fpi_data | -- cgit v1.2.1