From 4fb92718be654b38652dfe893d075f3862e84eae Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 23 Mar 2006 04:22:37 +0000 Subject: Fix plpgsql to pass only one copy of any given plpgsql variable into a SQL command or expression, rather than one copy for each textual occurrence as it did before. This might result in some small performance improvement, but the compelling reason to do it is that not doing so can result in unexpected grouping failures because the main SQL parser won't see different parameter numbers as equivalent. Add a regression test for the failure case. Per report from Robert Davidson. --- src/test/regress/sql/plpgsql.sql | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'src/test/regress/sql/plpgsql.sql') diff --git a/src/test/regress/sql/plpgsql.sql b/src/test/regress/sql/plpgsql.sql index a2d65817b1..19e145be65 100644 --- a/src/test/regress/sql/plpgsql.sql +++ b/src/test/regress/sql/plpgsql.sql @@ -2309,3 +2309,18 @@ end; $proc$ language plpgsql; select for_vect(); + +-- regression test: verify that multiple uses of same plpgsql datum within +-- a SQL command all get mapped to the same $n parameter. The return value +-- of the SELECT is not important, we only care that it doesn't fail with +-- a complaint about an ungrouped column reference. +create function multi_datum_use(p1 int) returns bool as $$ +declare + x int; + y int; +begin + select into x,y unique1/p1, unique1/$1 from tenk1 group by unique1/p1; + return x = y; +end$$ language plpgsql; + +select multi_datum_use(42); -- cgit v1.2.1