sysctl: fix crash -- thanks Steinar Gunderson #423704

3 files changed, 11 insertions, 3 deletions

diff --git a/NEWS b/NEWS
index 16b3b5e..12c945a 100644
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ ps: man page less ambiguous
 top: normal exit code should be 0          #341272 #354255
 pgrep: usage error should exit with 2       #413383
 vmstat: use EXIT_FAILURE -- thanks Yoshio Nakamura   #425492
+sysctl: fix crash -- thanks Steinar Gunderson      #423704
 
 procps-3.2.6 --> procps-3.2.7
 
diff --git a/TODO b/TODO
index 0fd07c6..3a61258 100644
--- a/TODO
+++ b/TODO
@@ -37,13 +37,20 @@ ones get filled in with something logical -- entries must never be deleted!
 
 Add all the stuff Solaris has. This would also replace ptrace.
 
+---------------------- watch --------------------------
+
+Tolerate UTF-8.
+
+Tolerate color, bold, underline, etc. #129334
+
+Tolerate stderr.  #420377 #155227 #225549
+
 ---------------------- w --------------------------
 
 The LOGIN@ column sometimes has a space in it. This makes correct
 scripting difficult.
 
-Verify that DNS control does not give a user the power to specify
-arbitrary data for the FROM column. (could set root's VGA color map!)
+Time formats are demented.
 
 ---------------------- vmstat --------------------------
 
diff --git a/sysctl.c b/sysctl.c
index 0c0e73a..1470df9 100644
--- a/sysctl.c
+++ b/sysctl.c
@@ -135,7 +135,7 @@ static int ReadSetting(const char *restrict const name) {
    }
 
    /* used to open the file */
-   tmpname = malloc(strlen(name)+strlen(PROC_PATH)+1);
+   tmpname = malloc(strlen(name)+strlen(PROC_PATH)+2);
    strcpy(tmpname, PROC_PATH);
    strcat(tmpname, name); 
    slashdot(tmpname+strlen(PROC_PATH),'.','/'); /* change . to / */