summaryrefslogtreecommitdiff
path: root/NEWS
diff options
context:
space:
mode:
authorTodd Lewis <todd_lewis@unc.edu>2021-10-25 19:38:10 -0400
committerCraig Small <csmall@dropbear.xyz>2021-10-26 18:13:48 +1100
commite500ba6d97c858931bd1409bd433c88bfffd4598 (patch)
tree33c9ccb140969fec0d2ad455f4cc123543f244ae /NEWS
parent2f293dbf745a9ac2566c90aa4e854657deafd3ee (diff)
downloadprocps-ng-e500ba6d97c858931bd1409bd433c88bfffd4598.tar.gz
fix uid/gid > 2^31
This MR revisits a partial fix from 2018. The problem stems from incorrect handling of unsigned 32-bit uid_ts and gid_ts as signed when values are large - i.e. when the high bit is set. In that case, pgrep and pkill fail to identify processes by uid. (They succeed when finding the same processes by username.) The primary fix for this is to impliment the "FIXME" comment in proc/readproc.h, the implementation of which allows the removal of the (int) casts from the partial fix from 2018. The other fixed code in this MR consists of tests in strict_atol() that detects and errors out on overflows. References: Merge !146
Diffstat (limited to 'NEWS')
-rw-r--r--NEWS1
1 files changed, 1 insertions, 0 deletions
diff --git a/NEWS b/NEWS
index 5f41025..8313463 100644
--- a/NEWS
+++ b/NEWS
@@ -7,6 +7,7 @@ procps-ng-NEXT
* library: add support for accessing autogroups
* pkill: Check for lt- variants of program name issue #192
* pgrep: Add newline after regex error message merge #91
+ * pgrep: Fix selection where uid/gid > 2^31 merge !146
* ps: Add OOM and OOMADJ fields issue #198
* ps: Add IO Accounting fields issue #184
* ps: Add PSS and USS fields issue #112