summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNed Batchelder <ned@nedbatchelder.com>2021-03-11 19:18:12 -0500
committerNed Batchelder <ned@nedbatchelder.com>2021-03-11 19:18:12 -0500
commit1d83d59ffacd0736411e492786f83953d247819f (patch)
treed7a3ce3a93213d0ac889fcac8670658cb966db1f
parentebbf3d5d59aaf638f7650db848c6583cafda8315 (diff)
downloadpython-coveragepy-git-1d83d59ffacd0736411e492786f83953d247819f.tar.gz
refactor: remove unused test class setting
unittest_mixins would check that files got created if a test made a temporary directory, so that we could trim down making temp dirs needlessly. But we don't use unittest_mixins any more, so this setting does nothing. Remove it.
-rw-r--r--tests/mixins.py5
-rw-r--r--tests/test_api.py4
-rw-r--r--tests/test_cmdline.py1
-rw-r--r--tests/test_coverage.py4
-rw-r--r--tests/test_data.py4
5 files changed, 0 insertions, 18 deletions
diff --git a/tests/mixins.py b/tests/mixins.py
index e8068be4..7492e90c 100644
--- a/tests/mixins.py
+++ b/tests/mixins.py
@@ -56,11 +56,6 @@ class TempDirMixin(object):
# created.
run_in_temp_dir = True
- # Set this if you aren't creating any files with make_file, but still want
- # the temp directory. This will stop the test behavior checker from
- # complaining.
- no_files_in_temp_dir = False
-
@pytest.fixture(autouse=True)
def _temp_dir(self, tmpdir_factory):
"""Create a temp dir for the tests, if they want it."""
diff --git a/tests/test_api.py b/tests/test_api.py
index 93b14c58..e7f02738 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -791,10 +791,6 @@ class NamespaceModuleTest(UsingModulesMixin, CoverageTest):
class IncludeOmitTestsMixin(UsingModulesMixin, CoverageTest):
"""Test methods for coverage methods taking include and omit."""
- # We don't write any source files, but the data file will collide with
- # other tests if we don't have a temp dir.
- no_files_in_temp_dir = True
-
def filenames_in(self, summary, filenames):
"""Assert the `filenames` are in the keys of `summary`."""
for filename in filenames.split():
diff --git a/tests/test_cmdline.py b/tests/test_cmdline.py
index 5c5ea0ef..adbbc619 100644
--- a/tests/test_cmdline.py
+++ b/tests/test_cmdline.py
@@ -765,7 +765,6 @@ class CmdLineWithFilesTest(BaseCmdLineTest):
"""Test the command line in ways that need temp files."""
run_in_temp_dir = True
- no_files_in_temp_dir = True
def test_debug_data(self):
data = CoverageData()
diff --git a/tests/test_coverage.py b/tests/test_coverage.py
index 30a8edc5..6cec3dd7 100644
--- a/tests/test_coverage.py
+++ b/tests/test_coverage.py
@@ -1849,10 +1849,6 @@ class ModuleTest(CoverageTest):
class ReportingTest(CoverageTest):
"""Tests of some reporting behavior."""
- # We don't make any temporary files, but we need an empty directory to run
- # the tests in.
- no_files_in_temp_dir = True
-
def test_no_data_to_report_on_annotate(self):
# Reporting with no data produces a nice message and no output
# directory.
diff --git a/tests/test_data.py b/tests/test_data.py
index 190231c7..30e6df60 100644
--- a/tests/test_data.py
+++ b/tests/test_data.py
@@ -106,8 +106,6 @@ class DataTestHelpers(CoverageTest):
class CoverageDataTest(DataTestHelpers, CoverageTest):
"""Test cases for CoverageData."""
- no_files_in_temp_dir = True
-
def test_empty_data_is_false(self):
covdata = CoverageData()
assert not covdata
@@ -560,8 +558,6 @@ class CoverageDataInTempDirTest(DataTestHelpers, CoverageTest):
class CoverageDataFilesTest(DataTestHelpers, CoverageTest):
"""Tests of CoverageData file handling."""
- no_files_in_temp_dir = True
-
def test_reading_missing(self):
self.assert_doesnt_exist(".coverage")
covdata = CoverageData()