diff options
| author | Ned Batchelder <ned@nedbatchelder.com> | 2022-09-07 17:50:38 -0400 |
|---|---|---|
| committer | Ned Batchelder <ned@nedbatchelder.com> | 2022-09-13 07:06:34 -0400 |
| commit | c784c559fa37407dfec6abc7734cb61bd5e7cc7f (patch) | |
| tree | d3ea1d6c9c6cb51b6ca4c257cc19180041b10f45 | |
| parent | 186817f345cfc0aa6953a171ec2cf25b7fbb90dd (diff) | |
| download | python-coveragepy-git-c784c559fa37407dfec6abc7734cb61bd5e7cc7f.tar.gz | |
style: adapt to latest pylint concerns
Before these changes, these violations happened:
```
lint run-test: commands[6] | python -m pylint --notes= coverage tests doc ci igor.py setup.py __main__.py
************* Module coverage.parser
coverage/parser.py:1290 I: Useless suppression of 'too-many-function-args' (useless-suppression)
************* Module ci.download_gha_artifacts
ci/download_gha_artifacts.py:18 W: Missing timeout argument for method 'requests.get' can cause your program to hang indefinitely (missing-timeout)
ci/download_gha_artifacts.py:54 W: Missing timeout argument for method 'requests.get' can cause your program to hang indefinitely (missing-timeout)
************* Module ci.trigger_build_kits
ci/trigger_build_kits.py:21 W: Missing timeout argument for method 'requests.post' can cause your program to hang indefinitely (missing-timeout)
************* Module ci.github_releases
ci/github_releases.py:138 E: Too many positional arguments for function call (too-many-function-args)
ci/github_releases.py:138 I: Useless suppression of 'no-value-for-parameter' (useless-suppression)
************* Module ci.comment_on_fixes
ci/comment_on_fixes.py:30 W: Missing timeout argument for method 'requests.get' can cause your program to hang indefinitely (missing-timeout)
ci/comment_on_fixes.py:37 W: Missing timeout argument for method 'requests.get' can cause your program to hang indefinitely (missing-timeout)
ci/comment_on_fixes.py:49 W: Missing timeout argument for method 'requests.post' can cause your program to hang indefinitely (missing-timeout)
************* Module ci.parse_relnotes
ci/parse_relnotes.py:126 E: Too many positional arguments for function call (too-many-function-args)
ci/parse_relnotes.py:126 I: Useless suppression of 'no-value-for-parameter' (useless-suppression)
```
| -rw-r--r-- | ci/github_releases.py | 2 | ||||
| -rw-r--r-- | ci/parse_relnotes.py | 2 | ||||
| -rw-r--r-- | coverage/parser.py | 1 | ||||
| -rw-r--r-- | pylintrc | 1 |
4 files changed, 3 insertions, 3 deletions
diff --git a/ci/github_releases.py b/ci/github_releases.py index 9f21d027..166011fb 100644 --- a/ci/github_releases.py +++ b/ci/github_releases.py @@ -135,4 +135,4 @@ def update_github_releases(json_filename, repo): update_release(gh_session, url, relnote) if __name__ == "__main__": - update_github_releases(*sys.argv[1:]) # pylint: disable=no-value-for-parameter + update_github_releases(*sys.argv[1:3]) diff --git a/ci/parse_relnotes.py b/ci/parse_relnotes.py index cdb8526c..deebae5d 100644 --- a/ci/parse_relnotes.py +++ b/ci/parse_relnotes.py @@ -123,4 +123,4 @@ def parse(md_filename, json_filename): json.dump(list(relnotes(markdown.splitlines(True))), jf, indent=4) if __name__ == "__main__": - parse(*sys.argv[1:]) # pylint: disable=no-value-for-parameter + parse(*sys.argv[1:3]) diff --git a/coverage/parser.py b/coverage/parser.py index 7ef67d2c..3dbfbf30 100644 --- a/coverage/parser.py +++ b/coverage/parser.py @@ -1287,7 +1287,6 @@ class AstArcAnalyzer: self.add_arc(start, -start, None, f"didn't finish the {noun} on line {start}") return _code_object__expression_callable - # pylint: disable=too-many-function-args _code_object__Lambda = _make_expression_code_method("lambda") _code_object__GeneratorExp = _make_expression_code_method("generator expression") _code_object__DictComp = _make_expression_code_method("dictionary comprehension") @@ -74,6 +74,7 @@ disable= import-outside-toplevel, self-assigning-variable, consider-using-with, + missing-timeout, # Formatting stuff superfluous-parens, # Messages that are noisy for now, eventually maybe we'll turn them on: |