diff options
| author | Ned Batchelder <ned@nedbatchelder.com> | 2020-06-28 17:31:09 -0400 |
|---|---|---|
| committer | Ned Batchelder <ned@nedbatchelder.com> | 2020-06-28 17:31:09 -0400 |
| commit | b436f4459a2fbc69f7a1376693782c7bd115b2bd (patch) | |
| tree | b02875a1e96510b15e9b8ab0071d3b389fa78602 | |
| parent | 221caf0deeb5a27a851afeab1687dc6485ada517 (diff) | |
| download | python-coveragepy-git-b436f4459a2fbc69f7a1376693782c7bd115b2bd.tar.gz | |
Provide more information in the fail-under message
| -rw-r--r-- | coverage/cmdline.py | 5 | ||||
| -rw-r--r-- | tests/test_process.py | 10 |
2 files changed, 12 insertions, 3 deletions
diff --git a/coverage/cmdline.py b/coverage/cmdline.py index d557ddf1..62edc207 100644 --- a/coverage/cmdline.py +++ b/coverage/cmdline.py @@ -629,7 +629,10 @@ class CoverageScript(object): fail_under = self.coverage.get_option("report:fail_under") precision = self.coverage.get_option("report:precision") if should_fail_under(total, fail_under, precision): - print("fail-under has failed") + msg = "total of {total:.{p}f} is less than fail-under={fail_under:.{p}f}".format( + total=total, fail_under=fail_under, p=precision, + ) + print("Coverage failure:", msg) return FAIL_UNDER return OK diff --git a/tests/test_process.py b/tests/test_process.py index 0428db75..8f8b009c 100644 --- a/tests/test_process.py +++ b/tests/test_process.py @@ -1236,13 +1236,19 @@ class FailUnderTest(CoverageTest): def test_report_43_is_not_ok(self): st, out = self.run_command_status("coverage report --fail-under=44") self.assertEqual(st, 2) - self.assertEqual(self.last_line_squeezed(out), "fail-under has failed") + self.assertEqual( + self.last_line_squeezed(out), + "Coverage failure: total of 43 is less than fail-under=44" + ) def test_report_42p86_is_not_ok(self): self.make_file(".coveragerc", "[report]\nprecision = 2") st, out = self.run_command_status("coverage report --fail-under=42.88") self.assertEqual(st, 2) - self.assertEqual(self.last_line_squeezed(out), "fail-under has failed") + self.assertEqual( + self.last_line_squeezed(out), + "Coverage failure: total of 42.86 is less than fail-under=42.88" + ) class FailUnderNoFilesTest(CoverageTest): |