From 9f29efdf20c5dcfe49e85cc61c0839730be2462e Mon Sep 17 00:00:00 2001 From: Mike Fiedler Date: Sun, 23 Dec 2018 20:19:39 -0500 Subject: Disallow impossible values for fail_under Since there's no way were likely to achieve greater than 100% code coverage, disallow usage of any value above 100. Resolves #743 Signed-off-by: Mike Fiedler --- coverage/results.py | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'coverage') diff --git a/coverage/results.py b/coverage/results.py index cab8796e..9be16b15 100644 --- a/coverage/results.py +++ b/coverage/results.py @@ -283,6 +283,10 @@ def should_fail_under(total, fail_under, precision): Returns True if the total should fail. """ + # We can never achieve higher than 100% coverage + if fail_under > 100.0: + raise ValueError("`fail_under` is greater than 100. Please use 100 or lower.") + # Special case for fail_under=100, it must really be 100. if fail_under == 100.0 and total != 100.0: return True -- cgit v1.2.1