summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarc Mueller <30130371+cdce8p@users.noreply.github.com>2021-02-28 16:40:36 +0100
committerPierre Sassoulas <pierre.sassoulas@gmail.com>2021-02-28 18:14:22 +0100
commitd8f2fab9b0505ae6cea442726b2ee09fb3336a2c (patch)
treefe28a6abf654e66572ea3de80516625c848ddfca
parentb88d2208fdf99868663a49b93cdff547f08ce225 (diff)
downloadastroid-git-d8f2fab9b0505ae6cea442726b2ee09fb3336a2c.tar.gz
Small improvements
-rw-r--r--astroid/brain/brain_typing.py8
-rw-r--r--tests/unittest_brain.py4
2 files changed, 6 insertions, 6 deletions
diff --git a/astroid/brain/brain_typing.py b/astroid/brain/brain_typing.py
index 021eb5e0..16b6e848 100644
--- a/astroid/brain/brain_typing.py
+++ b/astroid/brain/brain_typing.py
@@ -17,6 +17,7 @@ from astroid import (
InferenceError,
)
+PY39 = sys.version_info[:2] >= (3, 9)
TYPING_NAMEDTUPLE_BASENAMES = {"NamedTuple", "typing.NamedTuple"}
TYPING_TYPEVARS = {"TypeVar", "NewType"}
@@ -98,8 +99,6 @@ def infer_typedDict( # pylint: disable=invalid-name
node: nodes.FunctionDef, ctx: context.InferenceContext = None
) -> None:
"""Replace TypedDict FunctionDef with ClassDef."""
- if sys.version_info < (3, 9):
- return
class_def = nodes.ClassDef(
name="TypedDict",
doc=node.doc,
@@ -120,4 +119,7 @@ MANAGER.register_transform(
nodes.Subscript, inference_tip(infer_typing_attr), _looks_like_typing_subscript
)
-MANAGER.register_transform(nodes.FunctionDef, infer_typedDict, _looks_like_typedDict)
+if PY39:
+ MANAGER.register_transform(
+ nodes.FunctionDef, infer_typedDict, _looks_like_typedDict
+ )
diff --git a/tests/unittest_brain.py b/tests/unittest_brain.py
index 0eb6dfce..40ee7dc3 100644
--- a/tests/unittest_brain.py
+++ b/tests/unittest_brain.py
@@ -1188,9 +1188,7 @@ class TypingBrain(unittest.TestCase):
inferred = next(node.infer())
self.assertIsInstance(inferred, astroid.Instance)
- @pytest.mark.skipif(
- sys.version_info < (3, 8), reason="TypedDict changed from version 3.8 to 3.9"
- )
+ @test_utils.require_version("3.8")
def test_typedDict(self):
node = builder.extract_node(
"""