summaryrefslogtreecommitdiff
path: root/astroid/inference.py
diff options
context:
space:
mode:
authorClaudiu Popa <pcmanticore@gmail.com>2018-06-12 12:33:28 +0200
committerClaudiu Popa <pcmanticore@gmail.com>2018-06-12 12:50:30 +0200
commit9799ad2a86d4c8bd1ecc6cb9008fbebd5df91a4e (patch)
tree7b9f24ed9bd2b61eca03bc881669edaa9e37fad1 /astroid/inference.py
parentd4ae039a8514fb1c894e42f4cc5f0af9fea8a72c (diff)
downloadastroid-git-9799ad2a86d4c8bd1ecc6cb9008fbebd5df91a4e.tar.gz
Remove useless TODOs that are either issues in the issue tracker or things which we'll never get to fix/change
Diffstat (limited to 'astroid/inference.py')
-rw-r--r--astroid/inference.py9
1 files changed, 2 insertions, 7 deletions
diff --git a/astroid/inference.py b/astroid/inference.py
index fc63abcc..76401f86 100644
--- a/astroid/inference.py
+++ b/astroid/inference.py
@@ -163,7 +163,6 @@ def infer_name(self, context=None):
if not stmts:
# Try to see if the name is enclosed in a nested function
# and use the higher (first function) scope for searching.
- # TODO: should this be promoted to other nodes as well?
parent_function = _higher_function_scope(self.scope())
if parent_function:
_, stmts = parent_function.lookup(self.name)
@@ -682,23 +681,19 @@ def _infer_binary_operation(left, right, binary_opnode, context, flow_factory):
yield util.Uninferable
return
- # TODO(cpopa): since the inference engine might return
- # more values than are actually possible, we decide
- # to return util.Uninferable if we have union types.
if all(map(_is_not_implemented, results)):
continue
not_implemented = sum(1 for result in results
if _is_not_implemented(result))
if not_implemented and not_implemented != len(results):
- # Can't decide yet what this is, not yet though.
+ # Can't infer yet what this is.
yield util.Uninferable
return
for result in results:
yield result
return
- # TODO(cpopa): yield a BadBinaryOperationMessage here,
- # since the operation is not supported
+ # The operation doesn't seem to be supported so let the caller know about it
yield util.BadBinaryOperationMessage(left_type, binary_opnode.op, right_type)