Fix code review comments.

Added aliases for inferred() and assign_type(), refactor some uses of
ternary if, remove some now-unused internal functions in rebuilder,
replaced the mutating docstring function with one that returns values
as well as side-effects, change back to lazy-object-proxy, and add keyword
args to the Module call in rebuilder.

1 files changed, 21 insertions, 0 deletions

diff --git a/astroid/mixins.py b/astroid/mixins.py
index bd63700f..6edccfbe 100644
--- a/astroid/mixins.py
+++ b/astroid/mixins.py
@@ -58,12 +58,26 @@ class FilterStmtsMixin(object):
     def assign_type(self):
         return self
 
+    def ass_type(self):
+        warnings.warn('%s.ass_type() is deprecated, '
+                      'use %s.assign_type() instead.'
+                      % (type(self).__name__, type(self).__name__),
+                      PendingDeprecationWarning)
+        return self.assign_type()
+
 
 class AssignTypeMixin(object):
 
     def assign_type(self):
         return self
 
+    def ass_type(self):
+        warnings.warn('%s.ass_type() is deprecated, '
+                      'use %s.assign_type() instead.'
+                      % (type(self).__name__, type(self).__name__),
+                      PendingDeprecationWarning)
+        return self.assign_type()
+
     def _get_filtered_stmts(self, lookup_node, node, _stmts, mystmt):
         """method used in filter_stmts"""
         if self is mystmt:
@@ -80,6 +94,13 @@ class ParentAssignTypeMixin(AssignTypeMixin):
     def assign_type(self):
         return self.parent.assign_type()
 
+    def ass_type(self):
+        warnings.warn('%s.ass_type() is deprecated, '
+                      'use %s.assign_type() instead.'
+                      % (type(self).__name__, type(self).__name__),
+                      PendingDeprecationWarning)
+        return self.assign_type()
+
 
 class ImportFromMixin(FilterStmtsMixin):
     """MixIn for From and Import Nodes"""