From 33a14971c34fcd15deb2b18b50c9bd411eb6ed74 Mon Sep 17 00:00:00 2001 From: Bartek Sokorski Date: Thu, 19 Jan 2023 01:33:20 +0100 Subject: Fix issues reported by flake8 --- tests/test_context.py | 12 +++++++++--- tests/test_saferef.py | 4 ++-- tests/test_signals.py | 26 +++++++++++++++----------- tests/test_utilities.py | 2 +- 4 files changed, 27 insertions(+), 17 deletions(-) (limited to 'tests') diff --git a/tests/test_context.py b/tests/test_context.py index 020014c..f45cba7 100644 --- a/tests/test_context.py +++ b/tests/test_context.py @@ -5,7 +5,9 @@ def test_temp_connection(): sig = Signal() canary = [] - receiver = lambda sender: canary.append(sender) + + def receiver(sender): + canary.append(sender) sig.send(1) with sig.connected_to(receiver): @@ -20,7 +22,9 @@ def test_temp_connection_for_sender(): sig = Signal() canary = [] - receiver = lambda sender: canary.append(sender) + + def receiver(sender): + canary.append(sender) with sig.connected_to(receiver, sender=2): sig.send(1) @@ -34,7 +38,9 @@ def test_temp_connection_failure(): sig = Signal() canary = [] - receiver = lambda sender: canary.append(sender) + + def receiver(sender): + canary.append(sender) class Failure(Exception): pass diff --git a/tests/test_saferef.py b/tests/test_saferef.py index f510ff3..123183b 100644 --- a/tests/test_saferef.py +++ b/tests/test_saferef.py @@ -60,14 +60,14 @@ class TestSaferef(unittest.TestCase): def setUp(self): ts = [] ss = [] - for x in range(100): + for _ in range(100): t = _Sample1() ts.append(t) s = safe_ref(t.x, self._closure) ss.append(s) ts.append(_sample2) ss.append(safe_ref(_sample2, self._closure)) - for x in range(30): + for _ in range(30): t = _Sample3() ts.append(t) s = safe_ref(t, self._closure) diff --git a/tests/test_signals.py b/tests/test_signals.py index 864afc8..0879b5c 100644 --- a/tests/test_signals.py +++ b/tests/test_signals.py @@ -191,17 +191,20 @@ def test_signal_signals_weak_sender(): def test_empty_bucket_growth(): + def senders(): + return ( + len(sig._by_sender), + sum(len(i) for i in sig._by_sender.values()), + ) + + def receivers(): + return ( + len(sig._by_receiver), + sum(len(i) for i in sig._by_receiver.values()), + ) + sentinel = Sentinel() sig = blinker.Signal() - senders = lambda: ( - len(sig._by_sender), - sum(len(i) for i in sig._by_sender.values()), - ) - receivers = lambda: ( - len(sig._by_receiver), - sum(len(i) for i in sig._by_receiver.values()), - ) - receiver1 = sentinel.make_receiver("receiver1") receiver2 = sentinel.make_receiver("receiver2") @@ -245,7 +248,7 @@ def test_meta_connect_failure(): pytest.raises(TypeError, sig.connect, receiver) assert not sig.receivers assert not sig._by_receiver - assert sig._by_sender == {src.blinker.base.ANY_ID: set()} + assert sig._by_sender == {blinker.base.ANY_ID: set()} blinker.receiver_connected._clear_state() @@ -461,7 +464,8 @@ def test_no_double_send(): def test_has_receivers(): - received = lambda sender: None + def received(_): + return None sig = blinker.Signal() assert not sig.has_receivers_for(None) diff --git a/tests/test_utilities.py b/tests/test_utilities.py index 6df9b42..a07a53a 100644 --- a/tests/test_utilities.py +++ b/tests/test_utilities.py @@ -19,6 +19,6 @@ def test_symbols(): def test_pickled_symbols(): foo = symbol("foo") - for protocol in 0, 1, 2: + for _ in 0, 1, 2: roundtrip = pickle.loads(pickle.dumps(foo)) assert roundtrip is foo -- cgit v1.2.1