diff options
| author | Kubilay Kocak <koobs@users.noreply.github.com> | 2019-06-25 02:30:13 +0000 |
|---|---|---|
| committer | Paul Ganssle <paul@ganssle.io> | 2019-11-02 20:30:44 -0400 |
| commit | 38a5cd8486b08818c72e51efa8ca40151670bdeb (patch) | |
| tree | a9bf06127b5982306d5c5bf334283c7b23d3a085 | |
| parent | 3629d671ac13df86b94152dcb65a4041c892555e (diff) | |
| download | dateutil-git-38a5cd8486b08818c72e51efa8ca40151670bdeb.tar.gz | |
Fix test_tzlocal_offset_equal[GMT-tzoff1]
test_tzlocal_offset_equal[GMT-tzoff1] fails if a system does not
have a defined (installed) GMT timezone, for example if "Link Etc/GMT GMT"
is not defined in the zoneinfo configuration:
> assert tz.tzlocal() == tzoff
E AssertionError: assert tzlocal() == tzoffset(u'GMT', 0)
E -tzlocal()
E +tzoffset(u'GMT', 0)
An example of such a configuration is FreeBSD, who's default timezone is
UTC [1][2]. This configuration results in any "non-present" or undefined TZ
name being returned/processed as the default timezone name (in FreeBSD's
case, UTC).
Further, POSIX does not recognize [3] TZ=GMT or TZ=UTC as valid values
because they neither start with a colon nor contain a numeric offset hour
field.
Accordingly, update the GMT value for this parametrized test to GMT0, a
specific (not aliased) timezone, making it more robust to system
configuration differences.
[1] https://svnweb.freebsd.org/changeset/base/130332
[2] https://svnweb.freebsd.org/changeset/base/199405
[3] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html
| -rw-r--r-- | changelog.d/928.bugfix.rst | 1 | ||||
| -rw-r--r-- | dateutil/test/test_tz.py | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/changelog.d/928.bugfix.rst b/changelog.d/928.bugfix.rst new file mode 100644 index 0000000..01d19a4 --- /dev/null +++ b/changelog.d/928.bugfix.rst @@ -0,0 +1 @@ +Fixed issue where ``test_tzlocal_offset_equal`` would fail in certain environments (such as FreeBSD) due to an invalid assumption about what time zone names are provided. Reported and fixed by Kubilay Kocak (gh issue #918, pr #928). diff --git a/dateutil/test/test_tz.py b/dateutil/test/test_tz.py index d628826..6cd8ea0 100644 --- a/dateutil/test/test_tz.py +++ b/dateutil/test/test_tz.py @@ -993,7 +993,7 @@ def test_tzlocal_local_time_trim_colon(): @mark_tzlocal_nix @pytest.mark.parametrize('tzvar, tzoff', [ ('EST5', tz.tzoffset('EST', -18000)), - ('GMT', tz.tzoffset('GMT', 0)), + ('GMT0', tz.tzoffset('GMT', 0)), ('YAKT-9', tz.tzoffset('YAKT', timedelta(hours=9))), ('JST-9', tz.tzoffset('JST', timedelta(hours=9))), ]) |