diff options
author | ?ric Araujo <merwok@netwok.org> | 2012-02-15 17:39:48 +0100 |
---|---|---|
committer | ?ric Araujo <merwok@netwok.org> | 2012-02-15 17:39:48 +0100 |
commit | 32119c7e0942a0532644ff248b88b91d6bbc4881 (patch) | |
tree | 13c2c8a6a85043e4b1a3ed07b86049bccefa6abe | |
parent | ce3d2240908c84bbe7b9762b09ba3ffcfe44e7a5 (diff) | |
parent | ba827083256d2e791781f9d210c0f2808569c3be (diff) | |
download | disutils2-32119c7e0942a0532644ff248b88b91d6bbc4881.tar.gz |
Merge #1326113 fix from default
-rw-r--r-- | CHANGES.txt | 2 | ||||
-rw-r--r-- | distutils2/command/build_ext.py | 3 | ||||
-rw-r--r-- | distutils2/tests/test_command_build_ext.py | 12 |
3 files changed, 9 insertions, 8 deletions
diff --git a/CHANGES.txt b/CHANGES.txt index 62e2b54..140fb9c 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -164,6 +164,8 @@ CONTRIBUTORS.txt for full names. Bug numbers refer to http://bugs.python.org/. - #11805: Add multiple value syntax for package_data in setup.cfg [éric] - #13712: Don't map package_data to extra_files when converting a setup.py script with pysetup create [éric] +- #1326113: build_ext now correctly parses multiple values given to the + --libraries option [éric] 1.0a3 - 2010-10-08 diff --git a/distutils2/command/build_ext.py b/distutils2/command/build_ext.py index 4c3eadf..8e90ce4 100644 --- a/distutils2/command/build_ext.py +++ b/distutils2/command/build_ext.py @@ -159,8 +159,7 @@ class build_ext(Command): if plat_py_include != py_include: self.include_dirs.append(plat_py_include) - if isinstance(self.libraries, str): - self.libraries = [self.libraries] + self.ensure_string_list('libraries') # Life is easier if we're not forever checking for None, so # simplify these options to empty lists if unset diff --git a/distutils2/tests/test_command_build_ext.py b/distutils2/tests/test_command_build_ext.py index b9f8cc2..492da8b 100644 --- a/distutils2/tests/test_command_build_ext.py +++ b/distutils2/tests/test_command_build_ext.py @@ -141,21 +141,21 @@ class BuildExtTestCase(support.TempdirManager, # make sure cmd.libraries is turned into a list # if it's a string cmd = build_ext(dist) - cmd.libraries = 'my_lib' + cmd.libraries = 'my_lib, other_lib lastlib' cmd.finalize_options() - self.assertEqual(cmd.libraries, ['my_lib']) + self.assertEqual(cmd.libraries, ['my_lib', 'other_lib', 'lastlib']) # make sure cmd.library_dirs is turned into a list # if it's a string cmd = build_ext(dist) - cmd.library_dirs = 'my_lib_dir' + cmd.library_dirs = 'my_lib_dir%sother_lib_dir' % os.pathsep cmd.finalize_options() - self.assertIn('my_lib_dir', cmd.library_dirs) + self.assertEqual(cmd.library_dirs, ['my_lib_dir', 'other_lib_dir']) # make sure rpath is turned into a list - # if it's a list of os.pathsep's paths + # if it's a string cmd = build_ext(dist) - cmd.rpath = os.pathsep.join(['one', 'two']) + cmd.rpath = 'one%stwo' % os.pathsep cmd.finalize_options() self.assertEqual(cmd.rpath, ['one', 'two']) |