From a511445037974f3f013bf3473378cf46c7656938 Mon Sep 17 00:00:00 2001 From: Julien Courteau Date: Sat, 21 Apr 2012 17:51:00 -0400 Subject: Fix typo --- distutils2/metadata.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/distutils2/metadata.py b/distutils2/metadata.py index bcb766b..02ddf7a 100644 --- a/distutils2/metadata.py +++ b/distutils2/metadata.py @@ -480,7 +480,7 @@ class Metadata(object): return value def check(self, strict=False, restructuredtext=False): - """Check if the metadata is compliant. If strict is False then raise if + """Check if the metadata is compliant. If strict is True then raise if no Name or Version are provided""" self.set_metadata_version() -- cgit v1.2.1 From 5d5463009a93746b987f941b5698cf18ff6ec4fa Mon Sep 17 00:00:00 2001 From: Julien Courteau Date: Sat, 21 Apr 2012 20:59:06 -0400 Subject: fix: setup.py register fails if description has ReST uncompatible with Sphinx (#13614) --- distutils2/metadata.py | 3 +++ distutils2/tests/test_metadata.py | 9 +++++++++ 2 files changed, 12 insertions(+) diff --git a/distutils2/metadata.py b/distutils2/metadata.py index 02ddf7a..8ea4d53 100644 --- a/distutils2/metadata.py +++ b/distutils2/metadata.py @@ -35,6 +35,9 @@ try: def system_message(self, level, message, *children, **kwargs): self.messages.append((level, message, children, kwargs)) + return nodes.system_message(message, level=level, type=self. + levels[level], *children, **kwargs) + _HAS_DOCUTILS = True except ImportError: diff --git a/distutils2/tests/test_metadata.py b/distutils2/tests/test_metadata.py index 4f586cb..80fc278 100644 --- a/distutils2/tests/test_metadata.py +++ b/distutils2/tests/test_metadata.py @@ -379,6 +379,15 @@ class MetadataTestCase(LoggingCatcher, folded_desc = desc.replace('\n', '\n' + (7 * ' ') + '|') self.assertIn(folded_desc, out.getvalue()) + def test_description_invalid_rst(self): + # make sure bad rst is well handled in the description attribute + metadata = Metadata() + description_with_bad_rst = ':funkie:`str`' # Sphinx-specific markup + metadata['description'] = description_with_bad_rst + missing, warnings = metadata.check(restructuredtext=True) + warning = warnings[0][1] + self.assertIn('funkie', warning) + def test_project_url(self): metadata = Metadata() metadata['Project-URL'] = [('one', 'http://ok')] -- cgit v1.2.1