delta/python-packages/gitlab.git, branch fix/parse-cli-objects-camelcase

test(cli): add more real class scenarios

2021-03-07T11:04:06+00:00

fix(cli): fix parsing CLI objects to classnames

2021-03-07T10:58:53+00:00

Merge pull request #1336 from em-/fix/quote-everything

2021-03-06T23:32:16+00:00

fix: handle tags like debian/2%2.6-21 as identifiers

Merge pull request #1344 from JohnVillalovos/jlvillal/mixins

2021-03-06T22:15:55+00:00

chore: add type-hints for gitlab/mixins.py

chore: add type-hints for gitlab/mixins.py

2021-03-06T20:13:50+00:00

  * Added type-hints for gitlab/mixins.py
  * Changed use of filter with a lambda expression to
    list-comprehension. mypy was not able to understand the previous
    code. Also list-comprehension is better :)

Merge pull request #1353 from JohnVillalovos/jlvillal/mypy_base

2021-03-06T19:58:52+00:00

chore: add type hints to gitlab/base.py:RESTManager

Merge pull request #1350 from JohnVillalovos/jlvillal/isinstance

2021-03-06T17:57:08+00:00

chore: Put assert statements inside 'if TYPE_CHECKING:'

Merge pull request #1361 from python-gitlab/renovate/sphinx-3.x

2021-03-06T17:45:08+00:00

chore(deps): update dependency sphinx to v3.5.2

chore(deps): update dependency sphinx to v3.5.2

2021-03-06T13:36:19+00:00

fix: handle tags like debian/2%2.6-21 as identifiers

2021-03-05T00:04:00+00:00

Git refnames are relatively free-form and can contain all sort for
special characters, not just `/` and `#`, see
http://git-scm.com/docs/git-check-ref-format

In particular, Debian's DEP-14 standard for storing packaging in git
repositories mandates the use of the `%` character in tags in some
cases like `debian/2%2.6-21`.

Unfortunately python-gitlab currently only escapes `/` to `%2F` and in
some cases `#` to `%23`. This means that when using the commit API to
retrieve information about the `debian/2%2.6-21` tag only the slash is
escaped before being inserted in the URL path and the `%` is left
untouched, resulting in something like
`/api/v4/projects/123/repository/commits/debian%2F2%2.6-21`. When
urllib3 seees that it detects the invalid `%` escape and then urlencodes
the whole string, resulting in
`/api/v4/projects/123/repository/commits/debian%252F2%252.6-21`, where
the original `/` got escaped twice and produced `%252F`.

To avoid the issue, fully urlencode identifiers and parameters to avoid
the urllib3 auto-escaping in all cases.

Signed-off-by: Emanuele Aina