diff options
| author | Nejc Habjan <hab.nejc@gmail.com> | 2021-12-08 08:31:19 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-08 08:31:19 +0100 |
| commit | 3679591adabae780a74cb29f10f773666a1f8648 (patch) | |
| tree | 13fd5faed4bc11fb0e80e071ddbdb4b19670ccb1 | |
| parent | 3a7d6f6b7d168f00513266f5770624158f49ca2c (diff) | |
| parent | a90eb23cb4903ba25d382c37ce1c0839642ba8fd (diff) | |
| download | gitlab-3679591adabae780a74cb29f10f773666a1f8648.tar.gz | |
Merge pull request #1738 from python-gitlab/jlvillal/pylint_fixes
chore: fix pylint error "expression-not-assigned"
| -rw-r--r-- | gitlab/v4/cli.py | 48 | ||||
| -rw-r--r-- | pyproject.toml | 1 |
2 files changed, 20 insertions, 29 deletions
diff --git a/gitlab/v4/cli.py b/gitlab/v4/cli.py index 1b98193..675f93a 100644 --- a/gitlab/v4/cli.py +++ b/gitlab/v4/cli.py @@ -266,20 +266,16 @@ def _populate_sub_parser_by_class( sub_parser_action.add_argument(f"--{id_attr}", required=True) required, optional, dummy = cli.custom_actions[name][action_name] - [ - sub_parser_action.add_argument( - f"--{x.replace('_', '-')}", required=True - ) - for x in required - if x != cls._id_attr - ] - [ - sub_parser_action.add_argument( - f"--{x.replace('_', '-')}", required=False - ) - for x in optional - if x != cls._id_attr - ] + for x in required: + if x != cls._id_attr: + sub_parser_action.add_argument( + f"--{x.replace('_', '-')}", required=True + ) + for x in optional: + if x != cls._id_attr: + sub_parser_action.add_argument( + f"--{x.replace('_', '-')}", required=False + ) if mgr_cls.__name__ in cli.custom_actions: name = mgr_cls.__name__ @@ -293,20 +289,16 @@ def _populate_sub_parser_by_class( sub_parser_action.add_argument("--sudo", required=False) required, optional, dummy = cli.custom_actions[name][action_name] - [ - sub_parser_action.add_argument( - f"--{x.replace('_', '-')}", required=True - ) - for x in required - if x != cls._id_attr - ] - [ - sub_parser_action.add_argument( - f"--{x.replace('_', '-')}", required=False - ) - for x in optional - if x != cls._id_attr - ] + for x in required: + if x != cls._id_attr: + sub_parser_action.add_argument( + f"--{x.replace('_', '-')}", required=True + ) + for x in optional: + if x != cls._id_attr: + sub_parser_action.add_argument( + f"--{x.replace('_', '-')}", required=False + ) def extend_parser(parser: argparse.ArgumentParser) -> argparse.ArgumentParser: diff --git a/pyproject.toml b/pyproject.toml index 6e83a2e..2aa5b1d 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -55,7 +55,6 @@ disable = [ "consider-using-sys-exit", "cyclic-import", "duplicate-code", - "expression-not-assigned", "fixme", "implicit-str-concat", "import-outside-toplevel", |