diff options
author | Charles <charles.fayal@uconn.edu> | 2020-01-30 18:41:21 +0200 |
---|---|---|
committer | Charles <charles.fayal@uconn.edu> | 2020-01-30 21:22:26 +0200 |
commit | 2cf12c7973e139c4932da1f31c33bb7658b132f7 (patch) | |
tree | 70b10a6cfd343c1de0f8f7d476bda1a345db77e4 | |
parent | e512cddd30f3047230e8eedb79d98dc06e93a77b (diff) | |
download | gitlab-2cf12c7973e139c4932da1f31c33bb7658b132f7.tar.gz |
fix(docs and tests): update docs and tests for set_approvers
Updated the docs with the new set_approvers arguments, and updated tests with the arg as well.
-rw-r--r-- | docs/gl_objects/mr_approvals.rst | 2 | ||||
-rwxr-xr-x | tools/ee-test.py | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/docs/gl_objects/mr_approvals.rst b/docs/gl_objects/mr_approvals.rst index b5de88c..9d38db0 100644 --- a/docs/gl_objects/mr_approvals.rst +++ b/docs/gl_objects/mr_approvals.rst @@ -56,5 +56,5 @@ Change project-level or MR-level MR allowed approvers:: project.approvals.set_approvers(approver_ids=[105], approver_group_ids=[653, 654]) - mr.approvals.set_approvers(approver_ids=[105], + mr.approvals.set_approvers(approvals_required = 1, approver_ids=[105], approver_group_ids=[653, 654]) diff --git a/tools/ee-test.py b/tools/ee-test.py index 82adf5c..af12957 100755 --- a/tools/ee-test.py +++ b/tools/ee-test.py @@ -37,7 +37,7 @@ approval.reset_approvals_on_push = not v approval.save() approval = project1.approvals.get() assert v != approval.reset_approvals_on_push -project1.approvals.set_approvers([1], []) +project1.approvals.set_approvers(1, [1], []) approval = project1.approvals.get() assert approval.approvers[0]["user"]["id"] == 1 @@ -50,7 +50,7 @@ approval.approvals_required = 3 approval.save() approval = mr.approvals.get() assert approval.approvals_required == 3 -mr.approvals.set_approvers([1], []) +mr.approvals.set_approvers(1, [1], []) approval = mr.approvals.get() assert approval.approvers[0]["user"]["id"] == 1 |