diff options
| author | Max Wittig <max.wittig95@gmail.com> | 2020-03-08 11:44:53 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-08 11:44:53 +0100 |
| commit | ca37d23fd3d5a9ab19f5aeb2000ac32c503caeb1 (patch) | |
| tree | e4aa72b0438047cadb4b66a7ad5945c2083d0f71 | |
| parent | e5afb554bf4bcc28555bde4030f50558f175a53b (diff) | |
| parent | 99d959f74d06cca8df3f2d2b3a4709faba7799cb (diff) | |
| download | gitlab-ca37d23fd3d5a9ab19f5aeb2000ac32c503caeb1.tar.gz | |
Merge pull request #1038 from nejch/fix/allow-empty-create-data
Fix: do not require empty data dict for create()
| -rw-r--r-- | docs/gl_objects/access_requests.rst | 4 | ||||
| -rw-r--r-- | docs/gl_objects/projects.rst | 4 | ||||
| -rw-r--r-- | gitlab/mixins.py | 5 | ||||
| -rw-r--r-- | tools/python_test_v4.py | 2 |
4 files changed, 9 insertions, 6 deletions
diff --git a/docs/gl_objects/access_requests.rst b/docs/gl_objects/access_requests.rst index e890ce0..467c3e5 100644 --- a/docs/gl_objects/access_requests.rst +++ b/docs/gl_objects/access_requests.rst @@ -37,8 +37,8 @@ List access requests from projects and groups:: Create an access request:: - p_ar = project.accessrequests.create({}) - g_ar = group.accessrequests.create({}) + p_ar = project.accessrequests.create() + g_ar = group.accessrequests.create() Approve an access request:: diff --git a/docs/gl_objects/projects.rst b/docs/gl_objects/projects.rst index 8c3526c..1878757 100644 --- a/docs/gl_objects/projects.rst +++ b/docs/gl_objects/projects.rst @@ -103,7 +103,7 @@ Delete a project:: Fork a project:: - fork = project.forks.create({}) + fork = project.forks.create() # fork to a specific namespace fork = project.forks.create({'namespace': 'myteam'}) @@ -255,7 +255,7 @@ generated by GitLab you need to: # Create the export p = gl.projects.get(my_project) - export = p.exports.create({}) + export = p.exports.create() # Wait for the 'finished' status export.refresh() diff --git a/gitlab/mixins.py b/gitlab/mixins.py index 8544499..dde11d0 100644 --- a/gitlab/mixins.py +++ b/gitlab/mixins.py @@ -170,7 +170,7 @@ class CreateMixin(object): return getattr(self, "_create_attrs", (tuple(), tuple())) @exc.on_http_error(exc.GitlabCreateError) - def create(self, data, **kwargs): + def create(self, data=None, **kwargs): """Create a new object. Args: @@ -186,6 +186,9 @@ class CreateMixin(object): GitlabAuthenticationError: If authentication is not correct GitlabCreateError: If the server cannot perform the request """ + if data is None: + data = {} + self._check_missing_create_attrs(data) files = {} diff --git a/tools/python_test_v4.py b/tools/python_test_v4.py index 0703ee3..90aa7f1 100644 --- a/tools/python_test_v4.py +++ b/tools/python_test_v4.py @@ -949,7 +949,7 @@ settings.save() [current_project.delete() for current_project in projects] # project import/export -ex = admin_project.exports.create({}) +ex = admin_project.exports.create() ex.refresh() count = 0 while ex.export_status != "finished": |