diff options
author | Frantisek Lachman <flachman@redhat.com> | 2019-08-14 09:58:58 +0200 |
---|---|---|
committer | Frantisek Lachman <flachman@redhat.com> | 2019-08-14 10:04:00 +0200 |
commit | 6e204ce819fc8bdd5359325ed7026a48d63f8103 (patch) | |
tree | 052da5eb4934abae9fdc01d077437ad86f7f62b4 | |
parent | 8fc8e35c63d7ebd80408ae002693618ca16488a7 (diff) | |
download | gitlab-6e204ce819fc8bdd5359325ed7026a48d63f8103.tar.gz |
fix: remove empty list default arguments
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
-rw-r--r-- | gitlab/v4/objects.py | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py index a283112..0f709fe 100644 --- a/gitlab/v4/objects.py +++ b/gitlab/v4/objects.py @@ -2490,7 +2490,7 @@ class ProjectMergeRequestApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTMan _update_uses_post = True @exc.on_http_error(exc.GitlabUpdateError) - def set_approvers(self, approver_ids=[], approver_group_ids=[], **kwargs): + def set_approvers(self, approver_ids=None, approver_group_ids=None, **kwargs): """Change MR-level allowed approvers and approver groups. Args: @@ -2501,6 +2501,9 @@ class ProjectMergeRequestApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTMan GitlabAuthenticationError: If authentication is not correct GitlabUpdateError: If the server failed to perform the request """ + approver_ids = approver_ids or [] + approver_group_ids = approver_group_ids or [] + path = "%s/%s/approvers" % (self._parent.manager.path, self._parent.get_id()) data = {"approver_ids": approver_ids, "approver_group_ids": approver_group_ids} self.gitlab.http_put(path, post_data=data, **kwargs) @@ -3692,7 +3695,7 @@ class ProjectApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTManager): _update_uses_post = True @exc.on_http_error(exc.GitlabUpdateError) - def set_approvers(self, approver_ids=[], approver_group_ids=[], **kwargs): + def set_approvers(self, approver_ids=None, approver_group_ids=None, **kwargs): """Change project-level allowed approvers and approver groups. Args: @@ -3703,6 +3706,8 @@ class ProjectApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTManager): GitlabAuthenticationError: If authentication is not correct GitlabUpdateError: If the server failed to perform the request """ + approver_ids = approver_ids or [] + approver_group_ids = approver_group_ids or [] path = "/projects/%s/approvers" % self._parent.get_id() data = {"approver_ids": approver_ids, "approver_group_ids": approver_group_ids} |