summaryrefslogtreecommitdiff
path: root/gitlab/mixins.py
diff options
context:
space:
mode:
authorJohn L. Villalovos <john@sodarock.com>2021-03-07 11:31:23 -0800
committerNejc Habjan <hab.nejc@gmail.com>2021-04-17 17:09:41 +0200
commitaee1f496c1f414c1e30909767d53ae624fe875e7 (patch)
tree04a7fe9d8f77cffeae733bb8dd3447911995f3a1 /gitlab/mixins.py
parent8603248f73d8c751023fbfd2a394c5b7d939af7f (diff)
downloadgitlab-aee1f496c1f414c1e30909767d53ae624fe875e7.tar.gz
chore: have _create_attrs & _update_attrs be a namedtuple
Convert _create_attrs and _update_attrs to use a NamedTuple (RequiredOptional) to help with code readability. Update all code to use the NamedTuple.
Diffstat (limited to 'gitlab/mixins.py')
-rw-r--r--gitlab/mixins.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/gitlab/mixins.py b/gitlab/mixins.py
index fd77904..a809151 100644
--- a/gitlab/mixins.py
+++ b/gitlab/mixins.py
@@ -267,7 +267,7 @@ class CreateMixin(_RestManagerBase):
def _check_missing_create_attrs(self, data: Dict[str, Any]) -> None:
missing = []
- for attr in self._create_attrs[0]:
+ for attr in self._create_attrs.required:
if attr not in data:
missing.append(attr)
continue
@@ -339,7 +339,7 @@ class UpdateMixin(_RestManagerBase):
# Remove the id field from the required list as it was previously moved
# to the http path.
required = tuple(
- [k for k in self._update_attrs[0] if k != self._obj_cls._id_attr]
+ [k for k in self._update_attrs.required if k != self._obj_cls._id_attr]
)
missing = []
for attr in required:
@@ -518,7 +518,7 @@ class SaveMixin(_RestObjectBase):
def _get_updated_data(self) -> Dict[str, Any]:
updated_data = {}
- for attr in self.manager._update_attrs[0]:
+ for attr in self.manager._update_attrs.required:
# Get everything required, no matter if it's been updated
updated_data[attr] = getattr(self, attr)
# Add the updated attributes