diff options
author | Gauvain Pocentek <gauvain@pocentek.net> | 2017-06-05 11:14:13 +0200 |
---|---|---|
committer | Gauvain Pocentek <gauvain@pocentek.net> | 2017-06-05 11:14:13 +0200 |
commit | b776c5ee66a84f89acd4126ea729c77196e07f66 (patch) | |
tree | ee9ffcf444278bbb73f868b41542f3688df28b31 /gitlab/mixins.py | |
parent | f2c4a6e0e27eb5af795dd1a4281014502c1ff1e4 (diff) | |
download | gitlab-b776c5ee66a84f89acd4126ea729c77196e07f66.tar.gz |
Add tests for managers mixins
Diffstat (limited to 'gitlab/mixins.py')
-rw-r--r-- | gitlab/mixins.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/gitlab/mixins.py b/gitlab/mixins.py index ed3b204..670f33d 100644 --- a/gitlab/mixins.py +++ b/gitlab/mixins.py @@ -17,6 +17,7 @@ import gitlab from gitlab import base +from gitlab import exceptions class GetMixin(object): @@ -93,13 +94,15 @@ class GetFromListMixin(ListMixin): object: The generated RESTObject. Raises: - GitlabGetError: If the server cannot perform the request. + AttributeError: If the object could not be found in the list """ gen = self.list() for obj in gen: if str(obj.get_id()) == str(id): return obj + raise exceptions.GitlabHttpError(404, "Not found") + class RetrieveMixin(ListMixin, GetMixin): pass @@ -141,7 +144,7 @@ class CreateMixin(object): if hasattr(self, '_sanitize_data'): data = self._sanitize_data(data, 'create') # Handle specific URL for creation - path = kwargs.get('path', self.path) + path = kwargs.pop('path', self.path) server_data = self.gitlab.http_post(path, post_data=data, **kwargs) return self._obj_cls(self, server_data) |