diff options
| author | John L. Villalovos <john@sodarock.com> | 2021-06-12 15:05:36 -0700 |
|---|---|---|
| committer | John L. Villalovos <john@sodarock.com> | 2021-09-07 08:19:39 -0700 |
| commit | c9b5d3bac8f7c1f779dd57653f718dd0fac4db4b (patch) | |
| tree | 925700991c94a5a71797d6992b97c5b90ed74089 /gitlab/v4/cli.py | |
| parent | b8a47bae3342400a411fb9bf4bef3c15ba91c98e (diff) | |
| download | gitlab-c9b5d3bac8f7c1f779dd57653f718dd0fac4db4b.tar.gz | |
chore: improve type-hinting for managers
The 'managers' are dynamically created. This unfortunately means that
we don't have any type-hints for them and so editors which understand
type-hints won't know that they are valid attributes.
* Add the type-hints for the managers we define.
* Add a unit test that makes sure that the type-hints and the
'_managers' attribute are kept in sync with each other.
* Add unit test that makes sure specified managers in '_managers'
have a name ending in 'Managers' to keep with current convention.
* Make RESTObject._managers always present with a default value of
None.
* Fix a type-issue revealed now that mypy knows what the type is
Diffstat (limited to 'gitlab/v4/cli.py')
| -rw-r--r-- | gitlab/v4/cli.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/gitlab/v4/cli.py b/gitlab/v4/cli.py index 2fc1986..6986552 100644 --- a/gitlab/v4/cli.py +++ b/gitlab/v4/cli.py @@ -99,7 +99,10 @@ class GitlabCLI(object): def do_project_export_download(self) -> None: try: project = self.gl.projects.get(int(self.args["project_id"]), lazy=True) - data = project.exports.get().download() + export_status = project.exports.get() + if TYPE_CHECKING: + assert export_status is not None + data = export_status.download() sys.stdout.buffer.write(data) except Exception as e: |