summaryrefslogtreecommitdiff
path: root/gitlab/v4/objects.py
diff options
context:
space:
mode:
authorGauvain Pocentek <gauvain@pocentek.net>2018-03-17 16:46:18 +0100
committerGauvain Pocentek <gauvain@pocentek.net>2018-03-17 16:46:18 +0100
commit1940feec3dbb099dc3d671cd14ba756e7d34b071 (patch)
tree50c516a33507c9c92ab88c90189445acf5a65cf7 /gitlab/v4/objects.py
parent455a8fc8cab12bbcbf35f04053da84ec0ed1c5c6 (diff)
downloadgitlab-1940feec3dbb099dc3d671cd14ba756e7d34b071.tar.gz
Implement attribute types to handle special cases
Some attributes need to be parsed/modified to work with the API (for instance lists). This patch provides two attribute types that will simplify parts of the code, and fix some CLI bugs. Fixes #443
Diffstat (limited to 'gitlab/v4/objects.py')
-rw-r--r--gitlab/v4/objects.py24
1 files changed, 6 insertions, 18 deletions
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py
index e1763a5..348775e 100644
--- a/gitlab/v4/objects.py
+++ b/gitlab/v4/objects.py
@@ -23,6 +23,7 @@ from gitlab.base import * # noqa
from gitlab import cli
from gitlab.exceptions import * # noqa
from gitlab.mixins import * # noqa
+from gitlab import types
from gitlab import utils
VISIBILITY_PRIVATE = 'private'
@@ -315,12 +316,7 @@ class UserManager(CRUDMixin, RESTManager):
'website_url', 'skip_confirmation', 'external', 'organization',
'location')
)
-
- def _sanitize_data(self, data, action):
- new_data = data.copy()
- if 'confirm' in data:
- new_data['confirm'] = str(new_data['confirm']).lower()
- return new_data
+ _types = {'confirm': types.LowercaseStringAttribute}
class CurrentUserEmail(ObjectDeleteMixin, RESTObject):
@@ -528,6 +524,7 @@ class GroupIssueManager(GetFromListMixin, RESTManager):
_obj_cls = GroupIssue
_from_parent_attrs = {'group_id': 'id'}
_list_filters = ('state', 'labels', 'milestone', 'order_by', 'sort')
+ _types = {'labels': types.ListAttribute}
class GroupMember(SaveMixin, ObjectDeleteMixin, RESTObject):
@@ -736,6 +733,7 @@ class IssueManager(GetFromListMixin, RESTManager):
_path = '/issues'
_obj_cls = Issue
_list_filters = ('state', 'labels', 'order_by', 'sort')
+ _types = {'labels': types.ListAttribute}
class License(RESTObject):
@@ -1346,12 +1344,7 @@ class ProjectIssueManager(CRUDMixin, RESTManager):
_update_attrs = (tuple(), ('title', 'description', 'assignee_id',
'milestone_id', 'labels', 'created_at',
'updated_at', 'state_event', 'due_date'))
-
- def _sanitize_data(self, data, action):
- new_data = data.copy()
- if 'labels' in data:
- new_data['labels'] = ','.join(data['labels'])
- return new_data
+ _types = {'labels': types.ListAttribute}
class ProjectMember(SaveMixin, ObjectDeleteMixin, RESTObject):
@@ -1669,12 +1662,7 @@ class ProjectMergeRequestManager(CRUDMixin, RESTManager):
'description', 'state_event', 'labels',
'milestone_id'))
_list_filters = ('iids', 'state', 'order_by', 'sort')
-
- def _sanitize_data(self, data, action):
- new_data = data.copy()
- if 'labels' in data:
- new_data['labels'] = ','.join(data['labels'])
- return new_data
+ _types = {'labels': types.ListAttribute}
class ProjectMilestone(SaveMixin, ObjectDeleteMixin, RESTObject):